From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752209AbbIOXuS (ORCPT ); Tue, 15 Sep 2015 19:50:18 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54898 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752050AbbIOXuL (ORCPT ); Tue, 15 Sep 2015 19:50:11 -0400 Date: Tue, 15 Sep 2015 16:50:09 -0700 (PDT) Message-Id: <20150915.165009.293831022941705256.davem@davemloft.net> To: Julia.Lawall@lip6.fr Cc: gerrit@erg.abdn.ac.uk, sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 34/39] dccp: drop null test before destroy functions From: David Miller In-Reply-To: <1442146532-9100-35-git-send-email-Julia.Lawall@lip6.fr> References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-35-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Sep 2015 16:50:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Date: Sun, 13 Sep 2015 14:15:27 +0200 > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x; > @@ > > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > > @@ > expression x; > @@ > > -if (x != NULL) { > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > x = NULL; > -} > // > > Signed-off-by: Julia Lawall Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Tue, 15 Sep 2015 23:50:09 +0000 Subject: Re: [PATCH 34/39] dccp: drop null test before destroy functions Message-Id: <20150915.165009.293831022941705256.davem@davemloft.net> List-Id: References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-35-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1442146532-9100-35-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia.Lawall@lip6.fr Cc: gerrit@erg.abdn.ac.uk, sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Julia Lawall Date: Sun, 13 Sep 2015 14:15:27 +0200 > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x; > @@ > > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > > @@ > expression x; > @@ > > -if (x != NULL) { > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > x = NULL; > -} > // > > Signed-off-by: Julia Lawall Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Tue, 15 Sep 2015 23:50:09 +0000 Subject: Re: [PATCH 34/39] dccp: drop null test before destroy functions Message-Id: <20150915.165009.293831022941705256.davem@davemloft.net> List-Id: References: <1442146532-9100-35-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1442146532-9100-35-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dccp@vger.kernel.org From: Julia Lawall Date: Sun, 13 Sep 2015 14:15:27 +0200 > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x; > @@ > > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > > @@ > expression x; > @@ > > -if (x != NULL) { > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > x = NULL; > -} > // > > Signed-off-by: Julia Lawall Applied.