From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752404AbbIOHop (ORCPT ); Tue, 15 Sep 2015 03:44:45 -0400 Received: from e06smtp07.uk.ibm.com ([195.75.94.103]:53897 "EHLO e06smtp07.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbbIOHoo (ORCPT ); Tue, 15 Sep 2015 03:44:44 -0400 X-Helo: d06dlp01.portsmouth.uk.ibm.com X-MailFrom: heiko.carstens@de.ibm.com X-RcptTo: stable@vger.kernel.org Date: Tue, 15 Sep 2015 09:44:37 +0200 From: Heiko Carstens To: Willy Tarreau Cc: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Martin Schwidefsky Subject: Re: [PATCH 2.6.32 18/62] s390/hibernate: fix save and restore of kernel text section Message-ID: <20150915074437.GB4051@osiris> References: <20150912225607.341984869@1wt.eu> <1442283045.29883.1.camel@decadent.org.uk> <20150915060927.GA4051@osiris> <20150915074149.GB29318@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150915074149.GB29318@1wt.eu> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15091507-0029-0000-0000-000004202B82 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2015 at 09:41:49AM +0200, Willy Tarreau wrote: > On Tue, Sep 15, 2015 at 08:09:27AM +0200, Heiko Carstens wrote: > > On Tue, Sep 15, 2015 at 03:10:45AM +0100, Ben Hutchings wrote: > > > On Sun, 2015-09-13 at 00:56 +0200, Willy Tarreau wrote: > > > > 2.6.32-longterm review patch. If anyone has any objections, please let me know. > > > > > > > > ------------------ > > > > > > > > From: Heiko Carstens > > > > > > > > commit d74419495633493c9cd3f2bbeb7f3529d0edded6 upstream. > > > > > > > > Sebastian reported a crash caused by a jump label mismatch after resume. > > > > This happens because we do not save the kernel text section during suspend > > > > and therefore also do not restore it during resume, but use the kernel image > > > > that restores the old system. > > > [...] > > > > > > I don't think this is needed because jump labels aren't implemented in > > > 2.6.32. But maybe there was some other mechanism that changes the > > > kernel text on s390? > > > > Broken jump labels were the symptons when the problem was reported. However > > we lose everything that modifies kernel text without this patch. > > If it's not jump labels then there is still kprobes around where we have > > the same problem. > > Probably the patch description should have been better. > > OK so in the end you suggest you keep it in both 2.6.32 and 3.2 ? Yes, please.