From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbbIOUWU (ORCPT ); Tue, 15 Sep 2015 16:22:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38999 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbbIOUWT (ORCPT ); Tue, 15 Sep 2015 16:22:19 -0400 Date: Tue, 15 Sep 2015 13:22:18 -0700 From: Greg Kroah-Hartman To: Javier Martinez Canillas Cc: Emilio =?iso-8859-1?Q?L=F3pez?= , Olof Johansson , Kukjin Kim , Krzysztof =?utf-8?Q?Koz=C5=82owski?= , Guenter Roeck , Linux Kernel , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" Subject: Re: [PATCH v2 2/3] platform/chrome: Support reading/writing the vboot context Message-ID: <20150915202218.GA25914@kroah.com> References: <1442234049-18637-1-git-send-email-emilio.lopez@collabora.co.uk> <1442234049-18637-3-git-send-email-emilio.lopez@collabora.co.uk> <55F86E74.9010907@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2015 at 09:43:35PM +0200, Javier Martinez Canillas wrote: > Hello Emilio, > > On Tue, Sep 15, 2015 at 9:16 PM, Emilio López > wrote: > > [snip] > > >>> > >>> obj-$(CONFIG_CHROMEOS_LAPTOP) += chromeos_laptop.o > >>> obj-$(CONFIG_CHROMEOS_PSTORE) += chromeos_pstore.o > >>> -cros_ec_devs-objs := cros_ec_dev.o cros_ec_sysfs.o > >>> cros_ec_lightbar.o > >>> +cros_ec_devs-objs := cros_ec_dev.o > >>> +cros_ec_devs-objs += cros_ec_lightbar.o > >>> +cros_ec_devs-objs += cros_ec_sysfs.o > >>> +cros_ec_devs-objs += cros_ec_vbc.o > >> > >> > >> Why are you changing the Makefile? AFAIK += is usually used when the > >> compilation is conditional based on a Kconfig symbol but since these > >> are build unconditionally, I'll just keep it as foo := bar baz > > > > > > As far as I'm aware, += is append[0]. It's used for stuff like > > obj-$(CONFIG_CHROMEOS_LAPTOP) += chromeos_laptop.o > > because the left part will resolve to "obj-y" or similar, and you want to > > add to it, not replace it. I only changed the Makefile here because the line > > was growing too long, and I thought it looked neater this way; it shouldn't > > cause any functional change apart from the intended one. > > > > [0] https://www.gnu.org/software/make/manual/html_node/Appending.html > > > > Yes, I know how Kbuild works. What I tried to say is that you usually > append based on a Kconfig symbol. In fact even you are mentioning such > an example. > So appending unconditionally like you are doing makes the Makefile > harder to read IMHO. If the line grows to long you can use a backlash > (\) char to split the line. Either format is just fine, don't get too picky here please. From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Tue, 15 Sep 2015 13:22:18 -0700 Subject: [PATCH v2 2/3] platform/chrome: Support reading/writing the vboot context In-Reply-To: References: <1442234049-18637-1-git-send-email-emilio.lopez@collabora.co.uk> <1442234049-18637-3-git-send-email-emilio.lopez@collabora.co.uk> <55F86E74.9010907@collabora.co.uk> Message-ID: <20150915202218.GA25914@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 15, 2015 at 09:43:35PM +0200, Javier Martinez Canillas wrote: > Hello Emilio, > > On Tue, Sep 15, 2015 at 9:16 PM, Emilio L?pez > wrote: > > [snip] > > >>> > >>> obj-$(CONFIG_CHROMEOS_LAPTOP) += chromeos_laptop.o > >>> obj-$(CONFIG_CHROMEOS_PSTORE) += chromeos_pstore.o > >>> -cros_ec_devs-objs := cros_ec_dev.o cros_ec_sysfs.o > >>> cros_ec_lightbar.o > >>> +cros_ec_devs-objs := cros_ec_dev.o > >>> +cros_ec_devs-objs += cros_ec_lightbar.o > >>> +cros_ec_devs-objs += cros_ec_sysfs.o > >>> +cros_ec_devs-objs += cros_ec_vbc.o > >> > >> > >> Why are you changing the Makefile? AFAIK += is usually used when the > >> compilation is conditional based on a Kconfig symbol but since these > >> are build unconditionally, I'll just keep it as foo := bar baz > > > > > > As far as I'm aware, += is append[0]. It's used for stuff like > > obj-$(CONFIG_CHROMEOS_LAPTOP) += chromeos_laptop.o > > because the left part will resolve to "obj-y" or similar, and you want to > > add to it, not replace it. I only changed the Makefile here because the line > > was growing too long, and I thought it looked neater this way; it shouldn't > > cause any functional change apart from the intended one. > > > > [0] https://www.gnu.org/software/make/manual/html_node/Appending.html > > > > Yes, I know how Kbuild works. What I tried to say is that you usually > append based on a Kconfig symbol. In fact even you are mentioning such > an example. > So appending unconditionally like you are doing makes the Makefile > harder to read IMHO. If the line grows to long you can use a backlash > (\) char to split the line. Either format is just fine, don't get too picky here please.