From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 00/14] SCI clocks cleanup
Date: Thu, 17 Sep 2015 07:53:06 +0000 [thread overview]
Message-ID: <20150917075305.GC5414@verge.net.au> (raw)
In-Reply-To: <1442232876-27629-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Thu, Sep 17, 2015 at 04:30:06PM +0900, Simon Horman wrote:
> On Mon, Sep 14, 2015 at 03:14:22PM +0300, Laurent Pinchart wrote:
> > Hello,
> >
> > The SCI driver currently handles two clocks, an interface clock named sci_ick
> > and a functional clock named sci_fck. Studying the datasheets of the SH and
> > ARM SoCs that incorportate (H)SCI(F)([AB]) instances showed (un)surprisingly
> > that the hardware doesn't have a separate controllable interface clock.
> >
> > All the platforms that declare an interface clock for the SCI set it to the
> > clock used as the SCI functional clock. The two clocks can thus be merged on
> > the driver side, which is what this patch series does. The resulting clock is
> > called "fck", and all SH and ARM users (both DT and non-DT) are fixed to name
> > their SCI clocks appropriately.
> >
> > Support for the "sci_ick" name is kept in the sh-sci driver to ensure DT
> > backward compatibility, and support for the "peripheral_clk" clock to not
> > break SH platforms that don't declare device-specific SCI clocks. The later
> > can be removed when all SH platforms will declare their SCI clocks properly.
> >
> > The patches have been developed for an ancien (v3.x for those who were born)
> > kernel and rebased on top of Simon's master branch. I've only compile-tested
> > them after the rebase. Geert, I believe this series is a good preliminary
> > cleanup for the SCI baud rate generator clock support. Could you give it a try
> > as part of your work on that ?
>
> FWIW, given the explanation above, particularly that regarding backwards
> compatibility for DT, I am comfortable with these changes.
I have now looked over the code and it looks good to me:
Acked-by: Simon Horman <horms+renesas@verge.net.au>
prev parent reply other threads:[~2015-09-17 7:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 12:14 [PATCH 00/14] SCI clocks cleanup Laurent Pinchart
2015-09-14 12:14 ` [PATCH 01/14] serial: sh-sci: Drop the interface clock Laurent Pinchart
2015-09-14 12:14 ` Laurent Pinchart
2015-11-02 14:27 ` Geert Uytterhoeven
2015-11-02 14:27 ` Geert Uytterhoeven
2015-09-14 12:26 ` [PATCH 00/14] SCI clocks cleanup Geert Uytterhoeven
2015-09-14 12:37 ` Laurent Pinchart
2015-09-14 12:46 ` Geert Uytterhoeven
2015-09-17 7:30 ` Simon Horman
2015-09-17 7:53 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917075305.GC5414@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.