From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de,
bharata@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector
Date: Thu, 17 Sep 2015 18:03:49 -0500 [thread overview]
Message-ID: <20150917230349.20869.11698@loki> (raw)
In-Reply-To: <55FAE204.8000403@redhat.com>
Quoting Paolo Bonzini (2015-09-17 10:53:40)
>
>
> On 17/09/2015 17:50, Michael Roth wrote:
> > We still need globals for RTAS lookups. I think QOM is our most
> > mature/well-tested interface for managing inter-device
> > relationships/lookups, but I can understand if using
> > root_container/link<DRC> seems off. To me it seem like a nice
> > "freebie" we get from using QOM, and gave us nice guarantees like
> > globally unique paths to correspond to globally unique DRC indexes.
>
> I think it's okay; but I don't really like looking at ->properties
> directly, without an API (which doesn't exist indeed).
Yah, rather than copying qmp_qom_list() I think a proper interface
would've been warranted.
Perhaps an object_link_foreach() that mirrors object_child_foreach()?
For maybe just a more generic object_foreach() with a type mask?
Another approach would be to re-use or genericize qmp_qom_list() but
that seems like extra allocations/cleanup that aren't really
necessary outside of QMP/QAPI return values.
>
> Paolo
>
next prev parent reply other threads:[~2015-09-17 23:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 1:41 [Qemu-devel] [RFCv2 0/2] spapr: Cleanups to dynamic reconfiguration mechanism David Gibson
2015-09-14 1:41 ` [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector David Gibson
2015-09-14 6:23 ` Bharata B Rao
2015-09-14 8:22 ` Alexey Kardashevskiy
2015-09-14 11:45 ` David Gibson
2015-09-14 12:11 ` Paolo Bonzini
2015-09-14 14:06 ` Alexey Kardashevskiy
2015-09-14 14:24 ` Paolo Bonzini
2015-09-16 3:16 ` David Gibson
2015-09-17 15:50 ` Michael Roth
2015-09-17 15:53 ` Paolo Bonzini
2015-09-17 23:03 ` Michael Roth [this message]
2015-09-17 15:01 ` Michael Roth
2015-09-15 0:31 ` David Gibson
2015-09-15 0:30 ` David Gibson
2015-09-15 11:05 ` Paolo Bonzini
2015-09-14 1:41 ` [Qemu-devel] [RFCv2 2/2] spapr: Don't use QOM [*] syntax for DR connectors David Gibson
2015-09-14 4:07 ` Bharata B Rao
2015-09-14 4:14 ` David Gibson
2015-09-14 4:41 ` Bharata B Rao
2015-09-14 5:20 ` David Gibson
2015-09-14 8:13 ` Alexey Kardashevskiy
2015-09-15 4:03 ` Michael Roth
2015-09-15 4:21 ` Michael Roth
2015-09-16 3:18 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917230349.20869.11698@loki \
--to=mdroth@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.