From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 28 Sep 2015 17:08:56 -0400 Subject: [U-Boot] [PATCH] mmc: dw_mmc: Increase timeout to 4 minutes (as in Linux kernel) In-Reply-To: <56094416.5080600@samsung.com> References: <1440769821-24005-1-git-send-email-l.majewski@samsung.com> <1443198325-22460-1-git-send-email-l.majewski@samsung.com> <56094416.5080600@samsung.com> Message-ID: <20150928210856.GG22966@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Sep 28, 2015 at 03:43:50PM +0200, Przemyslaw Marczak wrote: > Hi Lukasz, > > On 09/25/2015 06:25 PM, Lukasz Majewski wrote: > >The commit: d9dbb97be0e4a550457aec5f11afefb446169c90 > >"mmc: dw_mmc: Zap endless timeout" removed endless loop waiting for end > >of dw mmc transfer. > > > >For some workloads - dfu test @ Odroid XU3 (sending 8MiB file) - > >and SD cards (e.g. MicroSD Kingston 4GiB, Adata 4GiB) > >the default timeout is to short. > > > >The new value - 4 minutes (240 seconds) - is the same as the one used in > >Linux kernel driver. Such fix should be good enough until we come up > >with better fix for this issue. > > > > I think, that you should adjust the commit message, because it > describes the result of the real problem which is in the background. > > It doesn't fix the DFU, because it wasn't broken. > What is the real problem and how does this commit fix it? I think this message is good enough (esp since I want to apply it now) and will link back to all of these other messages about it for details. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: