From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965168AbbI2Nla (ORCPT ); Tue, 29 Sep 2015 09:41:30 -0400 Received: from 8bytes.org ([81.169.241.247]:54174 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964989AbbI2NlV (ORCPT ); Tue, 29 Sep 2015 09:41:21 -0400 Date: Tue, 29 Sep 2015 15:41:19 +0200 From: Joerg Roedel To: Julia Lawall Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 38/39] iommu/amd: drop null test before destroy functions Message-ID: <20150929134119.GB7572@8bytes.org> References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-39-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442146532-9100-39-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2015 at 02:15:31PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) { > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > x = NULL; > -} > // > > Signed-off-by: Julia Lawall > > --- > drivers/iommu/amd_iommu_init.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Date: Tue, 29 Sep 2015 13:41:19 +0000 Subject: Re: [PATCH 38/39] iommu/amd: drop null test before destroy functions Message-Id: <20150929134119.GB7572@8bytes.org> List-Id: References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-39-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1442146532-9100-39-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org On Sun, Sep 13, 2015 at 02:15:31PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) { > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > x = NULL; > -} > // > > Signed-off-by: Julia Lawall > > --- > drivers/iommu/amd_iommu_init.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Applied, thanks.