From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754821AbbI3Il2 (ORCPT ); Wed, 30 Sep 2015 04:41:28 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36375 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754095AbbI3IlY (ORCPT ); Wed, 30 Sep 2015 04:41:24 -0400 Date: Wed, 30 Sep 2015 10:44:18 +0200 From: Daniel Vetter To: Julia Lawall Cc: Daniel Vetter , David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sergey.senozhatsky@gmail.com Subject: Re: [Intel-gfx] [PATCH 32/39] drm: i915: drop null test before destroy functions Message-ID: <20150930084418.GC3383@phenom.ffwll.local> Mail-Followup-To: Julia Lawall , Daniel Vetter , David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sergey.senozhatsky@gmail.com References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-33-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442146532-9100-33-git-send-email-Julia.Lawall@lip6.fr> X-Operating-System: Linux phenom 4.1.0-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2015 at 02:15:25PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > // > > Signed-off-by: Julia Lawall Queued for -next, thanks for the patch. -Daniel > > --- > drivers/gpu/drm/i915/i915_dma.c | 19 ++++++------------- > 1 file changed, 6 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index ab37d11..1dc7c21 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1059,12 +1059,9 @@ out_freecsr: > put_bridge: > pci_dev_put(dev_priv->bridge_dev); > free_priv: > - if (dev_priv->requests) > - kmem_cache_destroy(dev_priv->requests); > - if (dev_priv->vmas) > - kmem_cache_destroy(dev_priv->vmas); > - if (dev_priv->objects) > - kmem_cache_destroy(dev_priv->objects); > + kmem_cache_destroy(dev_priv->requests); > + kmem_cache_destroy(dev_priv->vmas); > + kmem_cache_destroy(dev_priv->objects); > kfree(dev_priv); > return ret; > } > @@ -1150,13 +1147,9 @@ int i915_driver_unload(struct drm_device *dev) > if (dev_priv->regs != NULL) > pci_iounmap(dev->pdev, dev_priv->regs); > > - if (dev_priv->requests) > - kmem_cache_destroy(dev_priv->requests); > - if (dev_priv->vmas) > - kmem_cache_destroy(dev_priv->vmas); > - if (dev_priv->objects) > - kmem_cache_destroy(dev_priv->objects); > - > + kmem_cache_destroy(dev_priv->requests); > + kmem_cache_destroy(dev_priv->vmas); > + kmem_cache_destroy(dev_priv->objects); > pci_dev_put(dev_priv->bridge_dev); > kfree(dev_priv); > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 32/39] drm: i915: drop null test before destroy functions Date: Wed, 30 Sep 2015 10:44:18 +0200 Message-ID: <20150930084418.GC3383@phenom.ffwll.local> References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-33-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1442146532-9100-33-git-send-email-Julia.Lawall@lip6.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Julia Lawall Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sergey.senozhatsky@gmail.com, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBTZXAgMTMsIDIwMTUgYXQgMDI6MTU6MjVQTSArMDIwMCwgSnVsaWEgTGF3YWxsIHdy b3RlOgo+IFJlbW92ZSB1bm5lZWRlZCBOVUxMIHRlc3QuCj4gCj4gVGhlIHNlbWFudGljIHBhdGNo IHRoYXQgbWFrZXMgdGhpcyBjaGFuZ2UgaXMgYXMgZm9sbG93czoKPiAoaHR0cDovL2NvY2NpbmVs bGUubGlwNi5mci8pCj4gCj4gLy8gPHNtcGw+Cj4gQEAgZXhwcmVzc2lvbiB4OyBAQAo+IC1pZiAo eCAhPSBOVUxMKQo+ICAgXChrbWVtX2NhY2hlX2Rlc3Ryb3lcfG1lbXBvb2xfZGVzdHJveVx8ZG1h X3Bvb2xfZGVzdHJveVwpKHgpOwo+IC8vIDwvc21wbD4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKdWxp YSBMYXdhbGwgPEp1bGlhLkxhd2FsbEBsaXA2LmZyPgoKUXVldWVkIGZvciAtbmV4dCwgdGhhbmtz IGZvciB0aGUgcGF0Y2guCi1EYW5pZWwKCj4gCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZG1hLmMgfCAgIDE5ICsrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDYgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rt YS5jCj4gaW5kZXggYWIzN2QxMS4uMWRjN2MyMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2RtYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEu Ywo+IEBAIC0xMDU5LDEyICsxMDU5LDkgQEAgb3V0X2ZyZWVjc3I6Cj4gIHB1dF9icmlkZ2U6Cj4g IAlwY2lfZGV2X3B1dChkZXZfcHJpdi0+YnJpZGdlX2Rldik7Cj4gIGZyZWVfcHJpdjoKPiAtCWlm IChkZXZfcHJpdi0+cmVxdWVzdHMpCj4gLQkJa21lbV9jYWNoZV9kZXN0cm95KGRldl9wcml2LT5y ZXF1ZXN0cyk7Cj4gLQlpZiAoZGV2X3ByaXYtPnZtYXMpCj4gLQkJa21lbV9jYWNoZV9kZXN0cm95 KGRldl9wcml2LT52bWFzKTsKPiAtCWlmIChkZXZfcHJpdi0+b2JqZWN0cykKPiAtCQlrbWVtX2Nh Y2hlX2Rlc3Ryb3koZGV2X3ByaXYtPm9iamVjdHMpOwo+ICsJa21lbV9jYWNoZV9kZXN0cm95KGRl dl9wcml2LT5yZXF1ZXN0cyk7Cj4gKwlrbWVtX2NhY2hlX2Rlc3Ryb3koZGV2X3ByaXYtPnZtYXMp Owo+ICsJa21lbV9jYWNoZV9kZXN0cm95KGRldl9wcml2LT5vYmplY3RzKTsKPiAgCWtmcmVlKGRl dl9wcml2KTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiBAQCAtMTE1MCwxMyArMTE0Nyw5IEBAIGlu dCBpOTE1X2RyaXZlcl91bmxvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCWlmIChkZXZf cHJpdi0+cmVncyAhPSBOVUxMKQo+ICAJCXBjaV9pb3VubWFwKGRldi0+cGRldiwgZGV2X3ByaXYt PnJlZ3MpOwo+ICAKPiAtCWlmIChkZXZfcHJpdi0+cmVxdWVzdHMpCj4gLQkJa21lbV9jYWNoZV9k ZXN0cm95KGRldl9wcml2LT5yZXF1ZXN0cyk7Cj4gLQlpZiAoZGV2X3ByaXYtPnZtYXMpCj4gLQkJ a21lbV9jYWNoZV9kZXN0cm95KGRldl9wcml2LT52bWFzKTsKPiAtCWlmIChkZXZfcHJpdi0+b2Jq ZWN0cykKPiAtCQlrbWVtX2NhY2hlX2Rlc3Ryb3koZGV2X3ByaXYtPm9iamVjdHMpOwo+IC0KPiAr CWttZW1fY2FjaGVfZGVzdHJveShkZXZfcHJpdi0+cmVxdWVzdHMpOwo+ICsJa21lbV9jYWNoZV9k ZXN0cm95KGRldl9wcml2LT52bWFzKTsKPiArCWttZW1fY2FjaGVfZGVzdHJveShkZXZfcHJpdi0+ b2JqZWN0cyk7Cj4gIAlwY2lfZGV2X3B1dChkZXZfcHJpdi0+YnJpZGdlX2Rldik7Cj4gIAlrZnJl ZShkZXZfcHJpdik7Cj4gIAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Wed, 30 Sep 2015 08:44:18 +0000 Subject: Re: [Intel-gfx] [PATCH 32/39] drm: i915: drop null test before destroy functions Message-Id: <20150930084418.GC3383@phenom.ffwll.local> List-Id: References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-33-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1442146532-9100-33-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sergey.senozhatsky@gmail.com, Daniel Vetter On Sun, Sep 13, 2015 at 02:15:25PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > // > > Signed-off-by: Julia Lawall Queued for -next, thanks for the patch. -Daniel > > --- > drivers/gpu/drm/i915/i915_dma.c | 19 ++++++------------- > 1 file changed, 6 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index ab37d11..1dc7c21 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1059,12 +1059,9 @@ out_freecsr: > put_bridge: > pci_dev_put(dev_priv->bridge_dev); > free_priv: > - if (dev_priv->requests) > - kmem_cache_destroy(dev_priv->requests); > - if (dev_priv->vmas) > - kmem_cache_destroy(dev_priv->vmas); > - if (dev_priv->objects) > - kmem_cache_destroy(dev_priv->objects); > + kmem_cache_destroy(dev_priv->requests); > + kmem_cache_destroy(dev_priv->vmas); > + kmem_cache_destroy(dev_priv->objects); > kfree(dev_priv); > return ret; > } > @@ -1150,13 +1147,9 @@ int i915_driver_unload(struct drm_device *dev) > if (dev_priv->regs != NULL) > pci_iounmap(dev->pdev, dev_priv->regs); > > - if (dev_priv->requests) > - kmem_cache_destroy(dev_priv->requests); > - if (dev_priv->vmas) > - kmem_cache_destroy(dev_priv->vmas); > - if (dev_priv->objects) > - kmem_cache_destroy(dev_priv->objects); > - > + kmem_cache_destroy(dev_priv->requests); > + kmem_cache_destroy(dev_priv->vmas); > + kmem_cache_destroy(dev_priv->objects); > pci_dev_put(dev_priv->bridge_dev); > kfree(dev_priv); > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch