From: Johan Hovold <johan@kernel.org>
To: Peter Hung <hpeter@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, tom_tsai@fintek.com.tw,
peter_hong@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V5 1/1] usb:serial add Fintek F81532/534 driver
Date: Tue, 27 Oct 2015 15:44:32 +0100 [thread overview]
Message-ID: <20151027144432.GG23708@localhost> (raw)
In-Reply-To: <56284916.1010903@gmail.com>
On Thu, Oct 22, 2015 at 10:25:26AM +0800, Peter Hung wrote:
> Hi Johan,
>
> Johan Hovold 於 2015/9/14 下午 09:33 寫道:
> > On Tue, Jul 21, 2015 at 09:58:19AM +0800, Peter Hung wrote:
>
> >> 4. RS422 Mode
> >> 1. The RTS mode is dont care.
> >> 2. Set M2/M1/M0 as 0/0/0
> >
> > I don't think all gpios should be exported for these ports if they have
> > special functions that the driver could control transparently (e.g. for
> > SER_RS485_RTS_ON_SEND).
>
> Surely, we can hide some setting with definitely setting like
> RS232/RS485, but the settings is only apply to our evaluation board.
>
> Some customers will use our F81532/534 with other brand transceiver IC.
> The pins setting maybe changed, so we decided to separate UART & pins
> settings and let the 3 output pins controllable for customer.
>
> Could I preserve currently UART & pins setting mode ?
If the pins can be set independently of the mode, and in principle be
used as general purpose output-only pins, then you should use the
gpiolib interface.
However, in the last patch it did look like the gpio-implementation was
intertwined with mode selection, something which made it seem like a bad
fit.
Would you be able to separate it, and specifically, make the gpio and
mode-handling generic and not specific for your evaluation board?
Thanks,
Johan
prev parent reply other threads:[~2015-10-27 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 1:58 [PATCH V5 1/1] usb:serial add Fintek F81532/534 driver Peter Hung
2015-09-14 13:33 ` Johan Hovold
2015-09-18 1:16 ` Peter Hung
2015-10-22 2:25 ` Peter Hung
2015-10-27 14:44 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027144432.GG23708@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.