From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbbKPO1k (ORCPT ); Mon, 16 Nov 2015 09:27:40 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:45118 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751929AbbKPO1i (ORCPT ); Mon, 16 Nov 2015 09:27:38 -0500 Date: Mon, 16 Nov 2015 14:11:42 +0000 From: Charles Keepax To: Pavel Machek CC: Mark Brown , , , , , , , , Subject: Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Message-ID: <20151116141142.GE18889@ck-lbox> References: <20151012154715.GF4238@sirena.org.uk> <20151012201137.GA7317@amd> <20151013115355.GC14956@sirena.org.uk> <20151113215812.GA19020@amd> <20151113225355.GU12392@sirena.org.uk> <20151114074400.GA7898@amd> <20151114123931.GW12392@sirena.org.uk> <20151114175915.GA20429@amd> <20151114184940.GY12392@sirena.org.uk> <20151114211633.GE20429@amd> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151114211633.GE20429@amd> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1511160235 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > with device that does not have dev_name initialized. > > > > OK, that'll be the problem then - we're not mapping the supply into the > > individual child device but rather system wide, probably because that > > mapping is being done too early, before we've actually created the > > device. > > Take a look at mfd_add_device(). Yes, we do > regulator_bulk_register_supply_alias() before doing > platform_device_add(). > > > > regulator_bulk_register_supply_alias() results in "Adding alias" > > > stuff, and then drivers/regulator/arizona-micsupp.c tries to register > > > another "MICVDD". > > > > That's fine because all supplies should be namespaced with a device. > > The goal is to say "Supply X on device Y" (we do support exceptions for > > the few cases where there are not yet any devices involved but this > > clearly isn't one of them). Indeed that should be the case. > > Well, clearly someone should tell that to wm5102 > maintainers. Hmm. It looks like driver is marked supported but there > are no names attached? > > WOLFSON MICROELECTRONICS DRIVERS > L: patches@opensource.wolfsonmicro.com > T: git git://opensource.wolfsonmicro.com/linux-2.6-asoc > T: git git://opensource.wolfsonmicro.com/linux-2.6-audioplus > W: > http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-device\ > s > S: Supported > > I guess Charles Keepax should be listed there? The patches mailing list functions as maintainer here. That way anyone who works on upstream Linux stuff here will see the email so you have more chance of someone replying. Also convient for when people leave the company etc. makes for an easy transition. I am afraid though that as in this case you are not always going to get a reply over the weekend. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Date: Mon, 16 Nov 2015 14:11:42 +0000 Message-ID: <20151116141142.GE18889@ck-lbox> References: <20151012154715.GF4238@sirena.org.uk> <20151012201137.GA7317@amd> <20151013115355.GC14956@sirena.org.uk> <20151113215812.GA19020@amd> <20151113225355.GU12392@sirena.org.uk> <20151114074400.GA7898@amd> <20151114123931.GW12392@sirena.org.uk> <20151114175915.GA20429@amd> <20151114184940.GY12392@sirena.org.uk> <20151114211633.GE20429@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by alsa0.perex.cz (Postfix) with ESMTP id 876FD26049A for ; Mon, 16 Nov 2015 15:27:28 +0100 (CET) Content-Disposition: inline In-Reply-To: <20151114211633.GE20429@amd> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pavel Machek Cc: alsa-devel@alsa-project.org, sameo@linux.intel.com, tiwai@suse.de, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com, Mark Brown , lee.jones@linaro.org List-Id: alsa-devel@alsa-project.org On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > with device that does not have dev_name initialized. > > > > OK, that'll be the problem then - we're not mapping the supply into the > > individual child device but rather system wide, probably because that > > mapping is being done too early, before we've actually created the > > device. > > Take a look at mfd_add_device(). Yes, we do > regulator_bulk_register_supply_alias() before doing > platform_device_add(). > > > > regulator_bulk_register_supply_alias() results in "Adding alias" > > > stuff, and then drivers/regulator/arizona-micsupp.c tries to register > > > another "MICVDD". > > > > That's fine because all supplies should be namespaced with a device. > > The goal is to say "Supply X on device Y" (we do support exceptions for > > the few cases where there are not yet any devices involved but this > > clearly isn't one of them). Indeed that should be the case. > > Well, clearly someone should tell that to wm5102 > maintainers. Hmm. It looks like driver is marked supported but there > are no names attached? > > WOLFSON MICROELECTRONICS DRIVERS > L: patches@opensource.wolfsonmicro.com > T: git git://opensource.wolfsonmicro.com/linux-2.6-asoc > T: git git://opensource.wolfsonmicro.com/linux-2.6-audioplus > W: > http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-device\ > s > S: Supported > > I guess Charles Keepax should be listed there? The patches mailing list functions as maintainer here. That way anyone who works on upstream Linux stuff here will see the email so you have more chance of someone replying. Also convient for when people leave the company etc. makes for an easy transition. I am afraid though that as in this case you are not always going to get a reply over the weekend. Thanks, Charles