From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753764AbbKWITF (ORCPT ); Mon, 23 Nov 2015 03:19:05 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:36756 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753738AbbKWITC (ORCPT ); Mon, 23 Nov 2015 03:19:02 -0500 Date: Mon, 23 Nov 2015 08:18:57 +0000 From: Lee Jones To: Pavel Machek Cc: Charles Keepax , Mark Brown , sameo@linux.intel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Message-ID: <20151123081857.GF3098@x1> References: <20151013115355.GC14956@sirena.org.uk> <20151113215812.GA19020@amd> <20151113225355.GU12392@sirena.org.uk> <20151114074400.GA7898@amd> <20151114123931.GW12392@sirena.org.uk> <20151114175915.GA20429@amd> <20151114184940.GY12392@sirena.org.uk> <20151114211633.GE20429@amd> <20151116141142.GE18889@ck-lbox> <20151122065140.GC26074@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151122065140.GC26074@amd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 22 Nov 2015, Pavel Machek wrote: > On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > > > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > > > with device that does not have dev_name initialized. > > > > > > > > OK, that'll be the problem then - we're not mapping the supply into the > > > > individual child device but rather system wide, probably because that > > > > mapping is being done too early, before we've actually created the > > > > device. > > > > > > Take a look at mfd_add_device(). Yes, we do > > > regulator_bulk_register_supply_alias() before doing > > > platform_device_add(). > > > > > > > > regulator_bulk_register_supply_alias() results in "Adding alias" > > > > > stuff, and then drivers/regulator/arizona-micsupp.c tries to register > > > > > another "MICVDD". > > > > > > > > That's fine because all supplies should be namespaced with a device. > > > > The goal is to say "Supply X on device Y" (we do support exceptions for > > > > the few cases where there are not yet any devices involved but this > > > > clearly isn't one of them). > > > > Indeed that should be the case. > > > > > > > > Well, clearly someone should tell that to wm5102 > > > maintainers. Hmm. It looks like driver is marked supported but there > > > are no names attached? > > > > > > WOLFSON MICROELECTRONICS DRIVERS > > > L: patches@opensource.wolfsonmicro.com > > > T: git git://opensource.wolfsonmicro.com/linux-2.6-asoc > > > T: git git://opensource.wolfsonmicro.com/linux-2.6-audioplus > > > W: > > > http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-device\ > > > s > > > S: Supported > > > > > > I guess Charles Keepax should be listed there? > > > > The patches mailing list functions as maintainer here. That way > > anyone who works on upstream Linux stuff here will see the email > > so you have more chance of someone replying. Also convient for > > when people leave the company etc. makes for an easy transition. > > I am afraid though that as in this case you are not always going > > to get a reply over the weekend. > > Well.. maintainer is a responsible person. Yes, you can list a mailing > list in maintainers file.. but mailing list is not going to be > responsible for that. > > Having a real name of person helps; if your name was listed there, I'd > know you (are supposed to be) authoritative person for this. > > I see it will need to be updated from time to time, but having name > really helps. A Mailing List is perfectly adequate for drivers which reside in a maintained subsystem. No requirement to submit names, particularly if there are lots of authorities personnel or if the personalities change regularly. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Date: Mon, 23 Nov 2015 08:18:57 +0000 Message-ID: <20151123081857.GF3098@x1> References: <20151013115355.GC14956@sirena.org.uk> <20151113215812.GA19020@amd> <20151113225355.GU12392@sirena.org.uk> <20151114074400.GA7898@amd> <20151114123931.GW12392@sirena.org.uk> <20151114175915.GA20429@amd> <20151114184940.GY12392@sirena.org.uk> <20151114211633.GE20429@amd> <20151116141142.GE18889@ck-lbox> <20151122065140.GC26074@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by alsa0.perex.cz (Postfix) with ESMTP id 75A372651AF for ; Mon, 23 Nov 2015 09:19:01 +0100 (CET) Received: by wmww144 with SMTP id w144so93615218wmw.0 for ; Mon, 23 Nov 2015 00:19:00 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151122065140.GC26074@amd> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pavel Machek Cc: alsa-devel@alsa-project.org, sameo@linux.intel.com, tiwai@suse.de, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com, Mark Brown , Charles Keepax List-Id: alsa-devel@alsa-project.org T24gU3VuLCAyMiBOb3YgMjAxNSwgUGF2ZWwgTWFjaGVrIHdyb3RlOgoKPiBPbiBNb24gMjAxNS0x MS0xNiAxNDoxMTo0MiwgQ2hhcmxlcyBLZWVwYXggd3JvdGU6Cj4gPiBPbiBTYXQsIE5vdiAxNCwg MjAxNSBhdCAxMDoxNjozM1BNICswMTAwLCBQYXZlbCBNYWNoZWsgd3JvdGU6Cj4gPiA+IEhpT24g U2F0IDIwMTUtMTEtMTQgMTg6NDk6NDAsIE1hcmsgQnJvd24gd3JvdGU6Cj4gPiA+ID4gT24gU2F0 LCBOb3YgMTQsIDIwMTUgYXQgMDY6NTk6MTZQTSArMDEwMCwgUGF2ZWwgTWFjaGVrIHdyb3RlOgo+ ID4gPiA+IAo+ID4gPiA+ID4gV2VsbCwgbWZkX2NvcmUuYyBzZWVtcyB0byBjYWxsIHJlZ3VsYXRv cl9idWxrX3JlZ2lzdGVyX3N1cHBseV9hbGlhcygpCj4gPiA+ID4gPiB3aXRoIGRldmljZSB0aGF0 IGRvZXMgbm90IGhhdmUgZGV2X25hbWUgaW5pdGlhbGl6ZWQuCj4gPiA+ID4gCj4gPiA+ID4gT0ss IHRoYXQnbGwgYmUgdGhlIHByb2JsZW0gdGhlbiAtIHdlJ3JlIG5vdCBtYXBwaW5nIHRoZSBzdXBw bHkgaW50byB0aGUKPiA+ID4gPiBpbmRpdmlkdWFsIGNoaWxkIGRldmljZSBidXQgcmF0aGVyIHN5 c3RlbSB3aWRlLCBwcm9iYWJseSBiZWNhdXNlIHRoYXQKPiA+ID4gPiBtYXBwaW5nIGlzIGJlaW5n IGRvbmUgdG9vIGVhcmx5LCBiZWZvcmUgd2UndmUgYWN0dWFsbHkgY3JlYXRlZCB0aGUKPiA+ID4g PiBkZXZpY2UuCj4gPiA+IAo+ID4gPiBUYWtlIGEgbG9vayBhdCBtZmRfYWRkX2RldmljZSgpLiBZ ZXMsIHdlIGRvCj4gPiA+IHJlZ3VsYXRvcl9idWxrX3JlZ2lzdGVyX3N1cHBseV9hbGlhcygpIGJl Zm9yZSBkb2luZwo+ID4gPiBwbGF0Zm9ybV9kZXZpY2VfYWRkKCkuCj4gPiA+IAo+ID4gPiA+ID4g cmVndWxhdG9yX2J1bGtfcmVnaXN0ZXJfc3VwcGx5X2FsaWFzKCkgcmVzdWx0cyBpbiAiQWRkaW5n IGFsaWFzIgo+ID4gPiA+ID4gc3R1ZmYsIGFuZCB0aGVuIGRyaXZlcnMvcmVndWxhdG9yL2FyaXpv bmEtbWljc3VwcC5jIHRyaWVzIHRvIHJlZ2lzdGVyCj4gPiA+ID4gPiBhbm90aGVyICJNSUNWREQi Lgo+ID4gPiA+IAo+ID4gPiA+IFRoYXQncyBmaW5lIGJlY2F1c2UgYWxsIHN1cHBsaWVzIHNob3Vs ZCBiZSBuYW1lc3BhY2VkIHdpdGggYSBkZXZpY2UuCj4gPiA+ID4gVGhlIGdvYWwgaXMgdG8gc2F5 ICJTdXBwbHkgWCBvbiBkZXZpY2UgWSIgKHdlIGRvIHN1cHBvcnQgZXhjZXB0aW9ucyBmb3IKPiA+ ID4gPiB0aGUgZmV3IGNhc2VzIHdoZXJlIHRoZXJlIGFyZSBub3QgeWV0IGFueSBkZXZpY2VzIGlu dm9sdmVkIGJ1dCB0aGlzCj4gPiA+ID4gY2xlYXJseSBpc24ndCBvbmUgb2YgdGhlbSkuCj4gPiAK PiA+IEluZGVlZCB0aGF0IHNob3VsZCBiZSB0aGUgY2FzZS4KPiA+IAo+ID4gPiAKPiA+ID4gV2Vs bCwgY2xlYXJseSBzb21lb25lIHNob3VsZCB0ZWxsIHRoYXQgdG8gd201MTAyCj4gPiA+IG1haW50 YWluZXJzLiBIbW0uIEl0IGxvb2tzIGxpa2UgZHJpdmVyIGlzIG1hcmtlZCBzdXBwb3J0ZWQgYnV0 IHRoZXJlCj4gPiA+IGFyZSBubyBuYW1lcyBhdHRhY2hlZD8KPiA+ID4gCj4gPiA+IFdPTEZTT04g TUlDUk9FTEVDVFJPTklDUyBEUklWRVJTCj4gPiA+IEw6ICAgICAgcGF0Y2hlc0BvcGVuc291cmNl LndvbGZzb25taWNyby5jb20KPiA+ID4gVDogICAgICBnaXQgZ2l0Oi8vb3BlbnNvdXJjZS53b2xm c29ubWljcm8uY29tL2xpbnV4LTIuNi1hc29jCj4gPiA+IFQ6ICAgICAgZ2l0IGdpdDovL29wZW5z b3VyY2Uud29sZnNvbm1pY3JvLmNvbS9saW51eC0yLjYtYXVkaW9wbHVzCj4gPiA+IFc6Cj4gPiA+ IGh0dHA6Ly9vcGVuc291cmNlLndvbGZzb25taWNyby5jb20vY29udGVudC9saW51eC1kcml2ZXJz LXdvbGZzb24tZGV2aWNlXAo+ID4gPiBzCj4gPiA+IFM6ICAgICAgU3VwcG9ydGVkCj4gPiA+IAo+ ID4gPiBJIGd1ZXNzIENoYXJsZXMgS2VlcGF4IHNob3VsZCBiZSBsaXN0ZWQgdGhlcmU/Cj4gPiAK PiA+IFRoZSBwYXRjaGVzIG1haWxpbmcgbGlzdCBmdW5jdGlvbnMgYXMgbWFpbnRhaW5lciBoZXJl LiBUaGF0IHdheQo+ID4gYW55b25lIHdobyB3b3JrcyBvbiB1cHN0cmVhbSBMaW51eCBzdHVmZiBo ZXJlIHdpbGwgc2VlIHRoZSBlbWFpbAo+ID4gc28geW91IGhhdmUgbW9yZSBjaGFuY2Ugb2Ygc29t ZW9uZSByZXBseWluZy4gQWxzbyBjb252aWVudCBmb3IKPiA+IHdoZW4gcGVvcGxlIGxlYXZlIHRo ZSBjb21wYW55IGV0Yy4gbWFrZXMgZm9yIGFuIGVhc3kgdHJhbnNpdGlvbi4KPiA+IEkgYW0gYWZy YWlkIHRob3VnaCB0aGF0IGFzIGluIHRoaXMgY2FzZSB5b3UgYXJlIG5vdCBhbHdheXMgZ29pbmcK PiA+IHRvIGdldCBhIHJlcGx5IG92ZXIgdGhlIHdlZWtlbmQuCj4gCj4gV2VsbC4uIG1haW50YWlu ZXIgaXMgYSByZXNwb25zaWJsZSBwZXJzb24uIFllcywgeW91IGNhbiBsaXN0IGEgbWFpbGluZwo+ IGxpc3QgaW4gbWFpbnRhaW5lcnMgZmlsZS4uIGJ1dCBtYWlsaW5nIGxpc3QgaXMgbm90IGdvaW5n IHRvIGJlCj4gcmVzcG9uc2libGUgZm9yIHRoYXQuCj4gCj4gSGF2aW5nIGEgcmVhbCBuYW1lIG9m IHBlcnNvbiBoZWxwczsgaWYgeW91ciBuYW1lIHdhcyBsaXN0ZWQgdGhlcmUsIEknZAo+IGtub3cg eW91IChhcmUgc3VwcG9zZWQgdG8gYmUpIGF1dGhvcml0YXRpdmUgcGVyc29uIGZvciB0aGlzLgo+ IAo+IEkgc2VlIGl0IHdpbGwgbmVlZCB0byBiZSB1cGRhdGVkIGZyb20gdGltZSB0byB0aW1lLCBi dXQgaGF2aW5nIG5hbWUKPiByZWFsbHkgaGVscHMuCgpBIE1haWxpbmcgTGlzdCBpcyBwZXJmZWN0 bHkgYWRlcXVhdGUgZm9yIGRyaXZlcnMgd2hpY2ggcmVzaWRlIGluIGEKbWFpbnRhaW5lZCBzdWJz eXN0ZW0uICBObyByZXF1aXJlbWVudCB0byBzdWJtaXQgbmFtZXMsIHBhcnRpY3VsYXJseSBpZgp0 aGVyZSBhcmUgbG90cyBvZiBhdXRob3JpdGllcyBwZXJzb25uZWwgb3IgaWYgdGhlIHBlcnNvbmFs aXRpZXMgY2hhbmdlCnJlZ3VsYXJseS4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVj dHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0 d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxv ZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRl dmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxt YW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK