* [PATCH] nvmet: Improve device_path output
@ 2015-11-23 13:59 Ian Bakshan
2015-11-23 15:46 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Ian Bakshan @ 2015-11-23 13:59 UTC (permalink / raw
Add '\n' when printing device path.
Signed-off-by: Ian Bakshan <ianb at mellanox.com>
Reviewed-by: Sagi Grimberg <sagig at mellanox.com>
---
drivers/nvme/target/configfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index 3a108b9..8b9b170 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -23,7 +23,7 @@ CONFIGFS_ATTR_OPS(nvmet_ns);
static ssize_t nvmet_ns_device_path_show(struct nvmet_ns *ns, char *page)
{
- return sprintf(page, "%s", ns->device_path);
+ return sprintf(page, "%s\n", ns->device_path);
}
static ssize_t nvmet_ns_device_path_store(struct nvmet_ns *ns, const char *page,
--
1.8.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvmet: Improve device_path output
2015-11-23 13:59 [PATCH] nvmet: Improve device_path output Ian Bakshan
@ 2015-11-23 15:46 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2015-11-23 15:46 UTC (permalink / raw
On Mon, Nov 23, 2015@03:59:13PM +0200, Ian Bakshan wrote:
> Add '\n' when printing device path.
>
> Signed-off-by: Ian Bakshan <ianb at mellanox.com>
> Reviewed-by: Sagi Grimberg <sagig at mellanox.com>
Thanks, this looks sensibe. Note that it can't currently handle
a newline at the input side either, they might be even more useful to
fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvmet: Improve device_path output
@ 2015-12-21 8:39 Ian Bakshan
0 siblings, 0 replies; 3+ messages in thread
From: Ian Bakshan @ 2015-12-21 8:39 UTC (permalink / raw
Add '\n' when printing device path.
Signed-off-by: Ian Bakshan <ianb at mellanox.com>
Reviewed-by: Sagi Grimberg <sagig at mellanox.com>
---
drivers/nvme/target/configfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index 3a108b9..8b9b170 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -23,7 +23,7 @@ CONFIGFS_ATTR_OPS(nvmet_ns);
static ssize_t nvmet_ns_device_path_show(struct nvmet_ns *ns, char *page)
{
- return sprintf(page, "%s", ns->device_path);
+ return sprintf(page, "%s\n", ns->device_path);
}
static ssize_t nvmet_ns_device_path_store(struct nvmet_ns *ns, const char *page,
--
1.8.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-21 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-23 13:59 [PATCH] nvmet: Improve device_path output Ian Bakshan
2015-11-23 15:46 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2015-12-21 8:39 Ian Bakshan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.