From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3 2/2] doc: correct Rings-based PMD section in the NIC Drivers guides Date: Fri, 27 Nov 2015 16:17:22 +0000 Message-ID: <20151127161721.GC27472@bricha3-MOBL3> References: <1448640460-25249-1-git-send-email-bernard.iremonger@intel.com> <1448640460-25249-3-git-send-email-bernard.iremonger@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Bernard Iremonger Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C18515683 for ; Fri, 27 Nov 2015 17:18:28 +0100 (CET) Content-Disposition: inline In-Reply-To: <1448640460-25249-3-git-send-email-bernard.iremonger@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 27, 2015 at 04:07:40PM +0000, Bernard Iremonger wrote: > Correct the sample code in the pcap_ring.rst file to match the latest > rte_eth_ring.c code. > > The parameters to the rte_eth_from_rings() function have changed since > the documentation was written. > The API change occurred before DPDK 1.8 when the rst files were added. > The original documentation on which the pcap_ring.rst file was based was > not correct. > > Fixes: correct the sample code in the pcap_ring.rst file. This is not a standard fixes line. Please add the following alias to your .gitconfig and then use "git fixline " to produce a correct fixes line identifying the commit being fixed. [alias] fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' /Bruce