On Mon, Nov 30, 2015 at 12:37:17PM +0100, Pavel Machek wrote: > Hi! Please submit patches in the format covered in SubmittingPatches. > + ret = of_property_read_u32(arizona->dev->of_node, > + "wlf,codec-number", &arizona->pdata.codec_num); Why does this make sense - what information is this adding?