From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754656AbbLDBOk (ORCPT ); Thu, 3 Dec 2015 20:14:40 -0500 Received: from mga14.intel.com ([192.55.52.115]:51335 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752516AbbLDBOi (ORCPT ); Thu, 3 Dec 2015 20:14:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,378,1444719600"; d="scan'208";a="612245837" Subject: [PATCH 09/34] x86, pkeys: store protection in high VMA flags To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, Dave Hansen , dave.hansen@linux.intel.com From: Dave Hansen Date: Thu, 03 Dec 2015 17:14:37 -0800 References: <20151204011424.8A36E365@viggo.jf.intel.com> In-Reply-To: <20151204011424.8A36E365@viggo.jf.intel.com> Message-Id: <20151204011437.1F3BB55E@viggo.jf.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Hansen vma->vm_flags is an 'unsigned long', so has space for 32 flags on 32-bit architectures. The high 32 bits are unused on 64-bit platforms. We've steered away from using the unused high VMA bits for things because we would have difficulty supporting it on 32-bit. Protection Keys are not available in 32-bit mode, so there is no concern about supporting this feature in 32-bit mode or on 32-bit CPUs. This patch carves out 4 bits from the high half of vma->vm_flags and allows architectures to set config option to make them available. Sparse complains about these constants unless we explicitly call them "UL". Signed-off-by: Dave Hansen --- b/arch/x86/Kconfig | 1 + b/include/linux/mm.h | 7 +++++++ b/mm/Kconfig | 3 +++ 3 files changed, 11 insertions(+) diff -puN arch/x86/Kconfig~pkeys-07-eat-high-vma-flags arch/x86/Kconfig --- a/arch/x86/Kconfig~pkeys-07-eat-high-vma-flags 2015-12-03 16:21:22.042508764 -0800 +++ b/arch/x86/Kconfig 2015-12-03 16:21:22.050509127 -0800 @@ -152,6 +152,7 @@ config X86 select VIRT_TO_BUS select X86_DEV_DMA_OPS if X86_64 select X86_FEATURE_NAMES if PROC_FS + select ARCH_USES_HIGH_VMA_FLAGS if X86_INTEL_MEMORY_PROTECTION_KEYS config INSTRUCTION_DECODER def_bool y diff -puN include/linux/mm.h~pkeys-07-eat-high-vma-flags include/linux/mm.h --- a/include/linux/mm.h~pkeys-07-eat-high-vma-flags 2015-12-03 16:21:22.044508855 -0800 +++ b/include/linux/mm.h 2015-12-03 16:21:22.051509173 -0800 @@ -158,6 +158,13 @@ extern unsigned int kobjsize(const void #define VM_NOHUGEPAGE 0x40000000 /* MADV_NOHUGEPAGE marked this vma */ #define VM_MERGEABLE 0x80000000 /* KSM may merge identical pages */ +#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS +#define VM_HIGH_ARCH_0 0x100000000UL /* bit only usable on 64-bit architectures */ +#define VM_HIGH_ARCH_1 0x200000000UL /* bit only usable on 64-bit architectures */ +#define VM_HIGH_ARCH_2 0x400000000UL /* bit only usable on 64-bit architectures */ +#define VM_HIGH_ARCH_3 0x800000000UL /* bit only usable on 64-bit architectures */ +#endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */ + #if defined(CONFIG_X86) # define VM_PAT VM_ARCH_1 /* PAT reserves whole VMA at once (x86) */ #elif defined(CONFIG_PPC) diff -puN mm/Kconfig~pkeys-07-eat-high-vma-flags mm/Kconfig --- a/mm/Kconfig~pkeys-07-eat-high-vma-flags 2015-12-03 16:21:22.046508946 -0800 +++ b/mm/Kconfig 2015-12-03 16:21:22.051509173 -0800 @@ -668,3 +668,6 @@ config ZONE_DEVICE config FRAME_VECTOR bool + +config ARCH_USES_HIGH_VMA_FLAGS + bool _ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by kanga.kvack.org (Postfix) with ESMTP id 533576B025C for ; Thu, 3 Dec 2015 20:14:47 -0500 (EST) Received: by pacwq6 with SMTP id wq6so553298pac.1 for ; Thu, 03 Dec 2015 17:14:47 -0800 (PST) Received: from mga01.intel.com (mga01.intel.com. [192.55.52.88]) by mx.google.com with ESMTP id w13si15460192pas.108.2015.12.03.17.14.37 for ; Thu, 03 Dec 2015 17:14:38 -0800 (PST) Subject: [PATCH 09/34] x86, pkeys: store protection in high VMA flags From: Dave Hansen Date: Thu, 03 Dec 2015 17:14:37 -0800 References: <20151204011424.8A36E365@viggo.jf.intel.com> In-Reply-To: <20151204011424.8A36E365@viggo.jf.intel.com> Message-Id: <20151204011437.1F3BB55E@viggo.jf.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, Dave Hansen , dave.hansen@linux.intel.com From: Dave Hansen vma->vm_flags is an 'unsigned long', so has space for 32 flags on 32-bit architectures. The high 32 bits are unused on 64-bit platforms. We've steered away from using the unused high VMA bits for things because we would have difficulty supporting it on 32-bit. Protection Keys are not available in 32-bit mode, so there is no concern about supporting this feature in 32-bit mode or on 32-bit CPUs. This patch carves out 4 bits from the high half of vma->vm_flags and allows architectures to set config option to make them available. Sparse complains about these constants unless we explicitly call them "UL". Signed-off-by: Dave Hansen --- b/arch/x86/Kconfig | 1 + b/include/linux/mm.h | 7 +++++++ b/mm/Kconfig | 3 +++ 3 files changed, 11 insertions(+) diff -puN arch/x86/Kconfig~pkeys-07-eat-high-vma-flags arch/x86/Kconfig --- a/arch/x86/Kconfig~pkeys-07-eat-high-vma-flags 2015-12-03 16:21:22.042508764 -0800 +++ b/arch/x86/Kconfig 2015-12-03 16:21:22.050509127 -0800 @@ -152,6 +152,7 @@ config X86 select VIRT_TO_BUS select X86_DEV_DMA_OPS if X86_64 select X86_FEATURE_NAMES if PROC_FS + select ARCH_USES_HIGH_VMA_FLAGS if X86_INTEL_MEMORY_PROTECTION_KEYS config INSTRUCTION_DECODER def_bool y diff -puN include/linux/mm.h~pkeys-07-eat-high-vma-flags include/linux/mm.h --- a/include/linux/mm.h~pkeys-07-eat-high-vma-flags 2015-12-03 16:21:22.044508855 -0800 +++ b/include/linux/mm.h 2015-12-03 16:21:22.051509173 -0800 @@ -158,6 +158,13 @@ extern unsigned int kobjsize(const void #define VM_NOHUGEPAGE 0x40000000 /* MADV_NOHUGEPAGE marked this vma */ #define VM_MERGEABLE 0x80000000 /* KSM may merge identical pages */ +#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS +#define VM_HIGH_ARCH_0 0x100000000UL /* bit only usable on 64-bit architectures */ +#define VM_HIGH_ARCH_1 0x200000000UL /* bit only usable on 64-bit architectures */ +#define VM_HIGH_ARCH_2 0x400000000UL /* bit only usable on 64-bit architectures */ +#define VM_HIGH_ARCH_3 0x800000000UL /* bit only usable on 64-bit architectures */ +#endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */ + #if defined(CONFIG_X86) # define VM_PAT VM_ARCH_1 /* PAT reserves whole VMA at once (x86) */ #elif defined(CONFIG_PPC) diff -puN mm/Kconfig~pkeys-07-eat-high-vma-flags mm/Kconfig --- a/mm/Kconfig~pkeys-07-eat-high-vma-flags 2015-12-03 16:21:22.046508946 -0800 +++ b/mm/Kconfig 2015-12-03 16:21:22.051509173 -0800 @@ -668,3 +668,6 @@ config ZONE_DEVICE config FRAME_VECTOR bool + +config ARCH_USES_HIGH_VMA_FLAGS + bool _ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org