From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] libxl: update check-xl-disk-parse Date: Wed, 9 Dec 2015 10:15:35 +0000 Message-ID: <20151209101535.GB23818@citrix.com> References: <1449604931-1477-1-git-send-email-wei.liu2@citrix.com> <1449655577.16124.166.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a6bmj-000696-UO for xen-devel@lists.xenproject.org; Wed, 09 Dec 2015 10:15:46 +0000 Content-Disposition: inline In-Reply-To: <1449655577.16124.166.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Xen-devel , Jim Fehlig , Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Wed, Dec 09, 2015 at 10:06:17AM +0000, Ian Campbell wrote: > On Tue, 2015-12-08 at 20:02 +0000, Wei Liu wrote: > > The block-attach command now returns 1 when fails. Update first test > > case to expect return value 1 instead of 255. > > > > The parser now doesn't generate output for default values. Remove them > > from expected output. > > This it looks good. > > > The "discard=" variant is never not supported, so delete two test cases > > with that variant. > > I don't follow (the double negative "never not" doesn't help). > Duh, I didn't intend to use double negation. > However, assuming you are saying that discard= is always supported, I don't > then see the rationale for removing the test. Of course we do want to test > things which are supported. > No, it is not supported. I dug into mailing list archive last night and confirmed that Ian J asked Olaf to remove such variant. Those test cases were residual from a previous version Olaf failed to remove. Wei.