From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbbLILyX (ORCPT ); Wed, 9 Dec 2015 06:54:23 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:41958 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969AbbLILyV (ORCPT ); Wed, 9 Dec 2015 06:54:21 -0500 Date: Wed, 9 Dec 2015 11:53:39 +0000 From: One Thousand Gnomes To: Dan Carpenter Cc: "James E.J. Bottomley" , Ondrej Zary , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hannes Reinecke Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init() Message-ID: <20151209115339.46a09d94@lxorguk.ukuu.org.uk> In-Reply-To: <20151209102453.GE3173@mwanda> References: <55B9CA3B.1030205@suse.de> <20151209102453.GE3173@mwanda> Organization: Intel Corporation X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Dec 2015 13:24:53 +0300 Dan Carpenter wrote: > On 64 bit CPUs there is a memory corruption bug on probe(). It should > be a u32 pointer instead of an unsigned long pointer or we write past > the end of the setupdata[] array. > > Signed-off-by: Dan Carpenter > Reviewed-by: Hannes Reinecke > --- > Resending because we have shuffled the code around so the patch needed > to be refreshed against linux-next. Although I do wonder why we are > still working on this code since it has never worked on 64 bit systems > so probably all the users gave up a decade ago. So this is untested ? If so please make it very clear in the commit message because the kernel is IMHO getting too full of polished, neat, recently modified, never tested, never used code. I agree it would be better if the driver was simply deleted. I've not even seen an ATP870 bug report in years. Alan From mboxrd@z Thu Jan 1 00:00:00 1970 From: One Thousand Gnomes Date: Wed, 09 Dec 2015 11:53:39 +0000 Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init() Message-Id: <20151209115339.46a09d94@lxorguk.ukuu.org.uk> List-Id: References: <55B9CA3B.1030205@suse.de> <20151209102453.GE3173@mwanda> In-Reply-To: <20151209102453.GE3173@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: "James E.J. Bottomley" , Ondrej Zary , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hannes Reinecke On Wed, 9 Dec 2015 13:24:53 +0300 Dan Carpenter wrote: > On 64 bit CPUs there is a memory corruption bug on probe(). It should > be a u32 pointer instead of an unsigned long pointer or we write past > the end of the setupdata[] array. > > Signed-off-by: Dan Carpenter > Reviewed-by: Hannes Reinecke > --- > Resending because we have shuffled the code around so the patch needed > to be refreshed against linux-next. Although I do wonder why we are > still working on this code since it has never worked on 64 bit systems > so probably all the users gave up a decade ago. So this is untested ? If so please make it very clear in the commit message because the kernel is IMHO getting too full of polished, neat, recently modified, never tested, never used code. I agree it would be better if the driver was simply deleted. I've not even seen an ATP870 bug report in years. Alan