From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbbLIRir (ORCPT ); Wed, 9 Dec 2015 12:38:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:60501 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700AbbLIRiq (ORCPT ); Wed, 9 Dec 2015 12:38:46 -0500 Date: Wed, 9 Dec 2015 18:38:29 +0100 From: Borislav Petkov To: Scott Wood Cc: Michael Ellerman , linux-kernel@vger.kernel.org, Stephen Rothwell , linux-next@vger.kernel.org, Johannes Thumshirn Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8) Message-ID: <20151209173829.GD10518@pd.tnic> References: <20151208154910.78d27c03@canb.auug.org.au> <1449657167.17265.4.camel@ellerman.id.au> <20151209111747.GA10518@pd.tnic> <20151209160301.GB10518@pd.tnic> <1449679809.15946.167.camel@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1449679809.15946.167.camel@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 09, 2015 at 10:50:09AM -0600, Scott Wood wrote: > It's not "a driver's probe function". There is no driver whose .probe() is > mpc85xx_pci_err_probe() -- the name is historical. >>From looking at it, it behaves a lot like a probe function. Irrespective of what it is or it isn't, calling it from outside a driver which can be built as a module is a no-no. So I'd appreciate it if someone could test Johannes' patch on the relevant hardware. Thanks. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8) Date: Wed, 9 Dec 2015 18:38:29 +0100 Message-ID: <20151209173829.GD10518@pd.tnic> References: <20151208154910.78d27c03@canb.auug.org.au> <1449657167.17265.4.camel@ellerman.id.au> <20151209111747.GA10518@pd.tnic> <20151209160301.GB10518@pd.tnic> <1449679809.15946.167.camel@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx2.suse.de ([195.135.220.15]:60501 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700AbbLIRiq (ORCPT ); Wed, 9 Dec 2015 12:38:46 -0500 Content-Disposition: inline In-Reply-To: <1449679809.15946.167.camel@freescale.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Scott Wood Cc: Michael Ellerman , linux-kernel@vger.kernel.org, Stephen Rothwell , linux-next@vger.kernel.org, Johannes Thumshirn On Wed, Dec 09, 2015 at 10:50:09AM -0600, Scott Wood wrote: > It's not "a driver's probe function". There is no driver whose .prob= e() is > mpc85xx_pci_err_probe() -- the name is historical. =46rom looking at it, it behaves a lot like a probe function. Irrespect= ive of what it is or it isn't, calling it from outside a driver which can b= e built as a module is a no-no. So I'd appreciate it if someone could tes= t Johannes' patch on the relevant hardware. Thanks. --=20 Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Nort= on, HRB 21284 (AG N=C3=BCrnberg) --=20