From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752915AbbLIRs7 (ORCPT ); Wed, 9 Dec 2015 12:48:59 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:50838 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282AbbLIRs5 (ORCPT ); Wed, 9 Dec 2015 12:48:57 -0500 Date: Wed, 9 Dec 2015 20:48:19 +0300 From: Dan Carpenter To: One Thousand Gnomes Cc: "James E.J. Bottomley" , Ondrej Zary , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hannes Reinecke Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init() Message-ID: <20151209174819.GB5177@mwanda> References: <55B9CA3B.1030205@suse.de> <20151209102453.GE3173@mwanda> <20151209115339.46a09d94@lxorguk.ukuu.org.uk> <20151209134512.GA5177@mwanda> <20151209141459.41a237c9@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151209141459.41a237c9@lxorguk.ukuu.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should add a tag to indicate that we are sending a patch for a crappy driver. IMHO-this-driver-is-garbage: Your Name If it got 10 votes of no confidence it would be moved to staging and then deleted. Anyway, realistically, let's just apply this fix. It's tempting to think we could delete all atp885 related code, but maybe people are still using it with 32 bit kernels. Or someone could delete it, but I'm not brave enough to be the one to do it. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 09 Dec 2015 17:48:19 +0000 Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init() Message-Id: <20151209174819.GB5177@mwanda> List-Id: References: <55B9CA3B.1030205@suse.de> <20151209102453.GE3173@mwanda> <20151209115339.46a09d94@lxorguk.ukuu.org.uk> <20151209134512.GA5177@mwanda> <20151209141459.41a237c9@lxorguk.ukuu.org.uk> In-Reply-To: <20151209141459.41a237c9@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: One Thousand Gnomes Cc: "James E.J. Bottomley" , Ondrej Zary , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hannes Reinecke We should add a tag to indicate that we are sending a patch for a crappy driver. IMHO-this-driver-is-garbage: Your Name If it got 10 votes of no confidence it would be moved to staging and then deleted. Anyway, realistically, let's just apply this fix. It's tempting to think we could delete all atp885 related code, but maybe people are still using it with 32 bit kernels. Or someone could delete it, but I'm not brave enough to be the one to do it. regards, dan carpenter