From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753462AbbLIS26 (ORCPT ); Wed, 9 Dec 2015 13:28:58 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:43889 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200AbbLIS25 (ORCPT ); Wed, 9 Dec 2015 13:28:57 -0500 Date: Wed, 9 Dec 2015 21:28:22 +0300 From: Dan Carpenter To: Julia Lawall Cc: One Thousand Gnomes , "James E.J. Bottomley" , Ondrej Zary , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hannes Reinecke Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init() Message-ID: <20151209182822.GC5284@mwanda> References: <55B9CA3B.1030205@suse.de> <20151209102453.GE3173@mwanda> <20151209115339.46a09d94@lxorguk.ukuu.org.uk> <20151209134512.GA5177@mwanda> <20151209141459.41a237c9@lxorguk.ukuu.org.uk> <20151209174819.GB5177@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 09, 2015 at 07:11:15PM +0100, Julia Lawall wrote: > Forgive my ignorance, but what is the exact procedure? For example, the > following file: drivers/pcmcia/vrc4173_cardu.c contains the following > code: INIT_WORK(&socket->tq_work, cardu_bh, socket);. The last time > INIT_WORK took three arguments was Linux 2.6.19, so I think no one has > been compiling this code recently. There would be the .c file and the > associated .h file to move to staging, but it's less clear to me eg what > to do with the Kconfig entry and the Makefile entry. And is there > anything else to take into account? You should just delete that code along with the Kconfig and Makefile entries. Don't bother moving it to staging. The move to staging is supposed to give people one last chance to yell if they absolutely need the code. No one has compiled this code for years so no one will miss it. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 09 Dec 2015 18:28:22 +0000 Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init() Message-Id: <20151209182822.GC5284@mwanda> List-Id: References: <55B9CA3B.1030205@suse.de> <20151209102453.GE3173@mwanda> <20151209115339.46a09d94@lxorguk.ukuu.org.uk> <20151209134512.GA5177@mwanda> <20151209141459.41a237c9@lxorguk.ukuu.org.uk> <20151209174819.GB5177@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: One Thousand Gnomes , "James E.J. Bottomley" , Ondrej Zary , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hannes Reinecke On Wed, Dec 09, 2015 at 07:11:15PM +0100, Julia Lawall wrote: > Forgive my ignorance, but what is the exact procedure? For example, the > following file: drivers/pcmcia/vrc4173_cardu.c contains the following > code: INIT_WORK(&socket->tq_work, cardu_bh, socket);. The last time > INIT_WORK took three arguments was Linux 2.6.19, so I think no one has > been compiling this code recently. There would be the .c file and the > associated .h file to move to staging, but it's less clear to me eg what > to do with the Kconfig entry and the Makefile entry. And is there > anything else to take into account? You should just delete that code along with the Kconfig and Makefile entries. Don't bother moving it to staging. The move to staging is supposed to give people one last chance to yell if they absolutely need the code. No one has compiled this code for years so no one will miss it. regards, dan carpenter