* [Buildroot] [PATCH] gutenprint: fix host installation
@ 2016-04-12 16:56 Baruch Siach
2016-04-12 21:30 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2016-04-12 16:56 UTC (permalink / raw
To: buildroot
Set DESTDIR to avoid installation attempt into build host directories.
Fixes:
http://autobuild.buildroot.net/results/bca/bca299631949c7699682af41e3f1373dd10866ed/
http://autobuild.buildroot.net/results/294/294dfc02ee95caaac4be9fd632c399bb2c7d3f83/
http://autobuild.buildroot.net/results/8ce/8ce0c14d92f34245a87758db60c618916be48586/
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/gutenprint/gutenprint.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk
index 7e3024d400af..2ee411f66cc3 100644
--- a/package/gutenprint/gutenprint.mk
+++ b/package/gutenprint/gutenprint.mk
@@ -69,6 +69,8 @@ HOST_GUTENPRINT_CONF_OPTS = \
--disable-testpattern \
--without-cups
+HOST_GUTENPRINT_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install
+
# Needed by autoreconf
define GUTENPRINT_CREATE_M4_DIR
mkdir -p $(@D)/m4local
--
2.8.0.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] gutenprint: fix host installation
2016-04-12 16:56 [Buildroot] [PATCH] gutenprint: fix host installation Baruch Siach
@ 2016-04-12 21:30 ` Peter Korsgaard
2016-04-14 2:45 ` Waldemar Brodkorb
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2016-04-12 21:30 UTC (permalink / raw
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Set DESTDIR to avoid installation attempt into build host directories.
> Fixes:
> http://autobuild.buildroot.net/results/bca/bca299631949c7699682af41e3f1373dd10866ed/
> http://autobuild.buildroot.net/results/294/294dfc02ee95caaac4be9fd632c399bb2c7d3f83/
> http://autobuild.buildroot.net/results/8ce/8ce0c14d92f34245a87758db60c618916be48586/
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Hmm, this sounds fishy. DESTDIR is normally only needed when the
installation directory is different from where the files will be used at
runtime (E.G. like for our target installation). Host-gutenprint should
be configured to install and run in HOST_DIR, so if you pass
DESTDIR=$(HOST_DIR) the files ends up in $(HOST_DIR)/$(HOST_DIR)/usr/..
The error sounds more like it misdetects the location of (host-)cups. We
do pass --without-cups to the configure script though, so I wonder why
it still wants to install cups files.
Care to take a 2nd look?
> ---
> package/gutenprint/gutenprint.mk | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk
> index 7e3024d400af..2ee411f66cc3 100644
> --- a/package/gutenprint/gutenprint.mk
> +++ b/package/gutenprint/gutenprint.mk
> @@ -69,6 +69,8 @@ HOST_GUTENPRINT_CONF_OPTS = \
> --disable-testpattern \
> --without-cups
> +HOST_GUTENPRINT_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install
> +
> # Needed by autoreconf
> define GUTENPRINT_CREATE_M4_DIR
> mkdir -p $(@D)/m4local
> --
> 2.8.0.rc3
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] gutenprint: fix host installation
2016-04-12 21:30 ` Peter Korsgaard
@ 2016-04-14 2:45 ` Waldemar Brodkorb
2016-04-14 5:44 ` Baruch Siach
0 siblings, 1 reply; 4+ messages in thread
From: Waldemar Brodkorb @ 2016-04-14 2:45 UTC (permalink / raw
To: buildroot
Peter Korsgaard wrote,
> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
>
> > Set DESTDIR to avoid installation attempt into build host directories.
> > Fixes:
> > http://autobuild.buildroot.net/results/bca/bca299631949c7699682af41e3f1373dd10866ed/
> > http://autobuild.buildroot.net/results/294/294dfc02ee95caaac4be9fd632c399bb2c7d3f83/
> > http://autobuild.buildroot.net/results/8ce/8ce0c14d92f34245a87758db60c618916be48586/
>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> Hmm, this sounds fishy. DESTDIR is normally only needed when the
> installation directory is different from where the files will be used at
> runtime (E.G. like for our target installation). Host-gutenprint should
> be configured to install and run in HOST_DIR, so if you pass
> DESTDIR=$(HOST_DIR) the files ends up in $(HOST_DIR)/$(HOST_DIR)/usr/..
>
> The error sounds more like it misdetects the location of (host-)cups. We
> do pass --without-cups to the configure script though, so I wonder why
> it still wants to install cups files.
>
> Care to take a 2nd look?
Have you seen this try to fix it?
https://patchwork.ozlabs.org/patch/605452/
best regards
Waldemar
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] gutenprint: fix host installation
2016-04-14 2:45 ` Waldemar Brodkorb
@ 2016-04-14 5:44 ` Baruch Siach
0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2016-04-14 5:44 UTC (permalink / raw
To: buildroot
Hi Waldemar,
On Thu, Apr 14, 2016 at 04:45:06AM +0200, Waldemar Brodkorb wrote:
> > >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> >
> > > Set DESTDIR to avoid installation attempt into build host directories.
> > > Fixes:
> > > http://autobuild.buildroot.net/results/bca/bca299631949c7699682af41e3f1373dd10866ed/
> > > http://autobuild.buildroot.net/results/294/294dfc02ee95caaac4be9fd632c399bb2c7d3f83/
> > > http://autobuild.buildroot.net/results/8ce/8ce0c14d92f34245a87758db60c618916be48586/
> >
> > > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >
> > Hmm, this sounds fishy. DESTDIR is normally only needed when the
> > installation directory is different from where the files will be used at
> > runtime (E.G. like for our target installation). Host-gutenprint should
> > be configured to install and run in HOST_DIR, so if you pass
> > DESTDIR=$(HOST_DIR) the files ends up in $(HOST_DIR)/$(HOST_DIR)/usr/..
> >
> > The error sounds more like it misdetects the location of (host-)cups. We
> > do pass --without-cups to the configure script though, so I wonder why
> > it still wants to install cups files.
> >
> > Care to take a 2nd look?
>
> Have you seen this try to fix it?
> https://patchwork.ozlabs.org/patch/605452/
That looks like a better fix to me.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-14 5:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-12 16:56 [Buildroot] [PATCH] gutenprint: fix host installation Baruch Siach
2016-04-12 21:30 ` Peter Korsgaard
2016-04-14 2:45 ` Waldemar Brodkorb
2016-04-14 5:44 ` Baruch Siach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.