* [PATCH 1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex
@ 2016-09-03 6:53 Chris Wilson
2016-09-03 6:53 ` [PATCH 2/2] drm/i915: debugfs/i915_gem_interrupt_info does not struct_mutex Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2016-09-03 6:53 UTC (permalink / raw
To: intel-gfx
i915_gem_seqno_info() supplies its own spinlocks to access the waiers,
and doesn't need any GGTT or mmio access.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_debugfs.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 19777a1abb9c..d4176c4d1c42 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -714,21 +714,11 @@ static void i915_ring_seqno_info(struct seq_file *m,
static int i915_gem_seqno_info(struct seq_file *m, void *data)
{
struct drm_i915_private *dev_priv = node_to_i915(m->private);
- struct drm_device *dev = &dev_priv->drm;
struct intel_engine_cs *engine;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
- intel_runtime_pm_get(dev_priv);
for_each_engine(engine, dev_priv)
i915_ring_seqno_info(m, engine);
- intel_runtime_pm_put(dev_priv);
- mutex_unlock(&dev->struct_mutex);
-
return 0;
}
--
2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] drm/i915: debugfs/i915_gem_interrupt_info does not struct_mutex
2016-09-03 6:53 [PATCH 1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex Chris Wilson
@ 2016-09-03 6:53 ` Chris Wilson
2016-09-03 10:10 ` Matthew Auld
2016-09-03 7:21 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex Patchwork
2016-09-03 10:12 ` [PATCH 1/2] " Matthew Auld
2 siblings, 1 reply; 5+ messages in thread
From: Chris Wilson @ 2016-09-03 6:53 UTC (permalink / raw
To: intel-gfx
i915_gem_interrupt_info() owns looks at mmio registers, and the waiters
under a spinlock. It doesn't need struct_mutex (but does need the rpm
wakelock for mmio access). Maybe useful using get_if_notidle?
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_debugfs.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index d4176c4d1c42..c02763de802f 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -726,13 +726,9 @@ static int i915_gem_seqno_info(struct seq_file *m, void *data)
static int i915_interrupt_info(struct seq_file *m, void *data)
{
struct drm_i915_private *dev_priv = node_to_i915(m->private);
- struct drm_device *dev = &dev_priv->drm;
struct intel_engine_cs *engine;
- int ret, i, pipe;
+ int i, pipe;
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
intel_runtime_pm_get(dev_priv);
if (IS_CHERRYVIEW(dev_priv)) {
@@ -908,7 +904,6 @@ static int i915_interrupt_info(struct seq_file *m, void *data)
i915_ring_seqno_info(m, engine);
}
intel_runtime_pm_put(dev_priv);
- mutex_unlock(&dev->struct_mutex);
return 0;
}
--
2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex
2016-09-03 6:53 [PATCH 1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex Chris Wilson
2016-09-03 6:53 ` [PATCH 2/2] drm/i915: debugfs/i915_gem_interrupt_info does not struct_mutex Chris Wilson
@ 2016-09-03 7:21 ` Patchwork
2016-09-03 10:12 ` [PATCH 1/2] " Matthew Auld
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-09-03 7:21 UTC (permalink / raw
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex
URL : https://patchwork.freedesktop.org/series/11956/
State : success
== Summary ==
Series 11956v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/11956/revisions/1/mbox/
fi-bdw-5557u total:252 pass:233 dwarn:2 dfail:1 fail:1 skip:15
fi-bsw-n3050 total:252 pass:203 dwarn:1 dfail:1 fail:1 skip:46
fi-hsw-4770k total:252 pass:226 dwarn:2 dfail:1 fail:1 skip:22
fi-hsw-4770r total:252 pass:222 dwarn:2 dfail:1 fail:1 skip:26
fi-ivb-3520m total:252 pass:217 dwarn:2 dfail:1 fail:1 skip:31
fi-skl-6260u total:252 pass:233 dwarn:2 dfail:1 fail:1 skip:15
fi-skl-6700k total:252 pass:219 dwarn:3 dfail:1 fail:1 skip:28
fi-snb-2520m total:252 pass:204 dwarn:2 dfail:1 fail:2 skip:43
fi-snb-2600 total:252 pass:204 dwarn:2 dfail:1 fail:1 skip:44
Results at /archive/results/CI_IGT_test/Patchwork_2466/
9537f6c371650d0f3e3dfdc462a745c5cb53c14c drm-intel-nightly: 2016y-09m-02d-15h-39m-13s UTC integration manifest
843bd88 drm/i915: debugfs/i915_gem_interrupt_info does not struct_mutex
d5bb1fb drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] drm/i915: debugfs/i915_gem_interrupt_info does not struct_mutex
2016-09-03 6:53 ` [PATCH 2/2] drm/i915: debugfs/i915_gem_interrupt_info does not struct_mutex Chris Wilson
@ 2016-09-03 10:10 ` Matthew Auld
0 siblings, 0 replies; 5+ messages in thread
From: Matthew Auld @ 2016-09-03 10:10 UTC (permalink / raw
To: Chris Wilson; +Cc: Intel Graphics Development
On 3 September 2016 at 07:53, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> i915_gem_interrupt_info() owns looks at mmio registers, and the waiters
> under a spinlock. It doesn't need struct_mutex (but does need the rpm
> wakelock for mmio access). Maybe useful using get_if_notidle?
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
"owns looks"?
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex
2016-09-03 6:53 [PATCH 1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex Chris Wilson
2016-09-03 6:53 ` [PATCH 2/2] drm/i915: debugfs/i915_gem_interrupt_info does not struct_mutex Chris Wilson
2016-09-03 7:21 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex Patchwork
@ 2016-09-03 10:12 ` Matthew Auld
2 siblings, 0 replies; 5+ messages in thread
From: Matthew Auld @ 2016-09-03 10:12 UTC (permalink / raw
To: Chris Wilson; +Cc: Intel Graphics Development
On 3 September 2016 at 07:53, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> i915_gem_seqno_info() supplies its own spinlocks to access the waiers,
> and doesn't need any GGTT or mmio access.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
s/waiers/waiters
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-03 10:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-03 6:53 [PATCH 1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex Chris Wilson
2016-09-03 6:53 ` [PATCH 2/2] drm/i915: debugfs/i915_gem_interrupt_info does not struct_mutex Chris Wilson
2016-09-03 10:10 ` Matthew Auld
2016-09-03 7:21 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex Patchwork
2016-09-03 10:12 ` [PATCH 1/2] " Matthew Auld
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.