All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH BlueZ] lib/sdp: Remove deprecated VIDEO_CONF profile id
@ 2016-12-10 22:59 Tomasz Gorochowik
  2017-01-16  7:32 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Gorochowik @ 2016-12-10 22:59 UTC (permalink / raw
  To: linux-bluetooth; +Cc: Tomasz Gorochowik

Commit 75e0c32af6bf ("lib/sdp: Replace VIDEO_CONF_SVCLASS_ID with
AV_REMOTE_CONTROLLER_SVCLASS_ID") removed the deprecated
VIDEO_CONF_SVCLASS_ID definition, but left the corresponding profile
definition..

According to the specification linked below A/V_RemoteControlController
UUID can only be used as a service class so its profile definition
should be removed.

https://www.bluetooth.org/en-us/specification/assigned-numbers/service-discovery
---
 lib/sdp.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/sdp.h b/lib/sdp.h
index cc10e9f..f586eb5 100644
--- a/lib/sdp.h
+++ b/lib/sdp.h
@@ -176,7 +176,6 @@ extern "C" {
 #define AV_REMOTE_TARGET_PROFILE_ID	AV_REMOTE_TARGET_SVCLASS_ID
 #define ADVANCED_AUDIO_PROFILE_ID	ADVANCED_AUDIO_SVCLASS_ID
 #define AV_REMOTE_PROFILE_ID		AV_REMOTE_SVCLASS_ID
-#define VIDEO_CONF_PROFILE_ID		VIDEO_CONF_SVCLASS_ID
 #define INTERCOM_PROFILE_ID		INTERCOM_SVCLASS_ID
 #define FAX_PROFILE_ID			FAX_SVCLASS_ID
 #define HEADSET_AGW_PROFILE_ID		HEADSET_AGW_SVCLASS_ID
-- 
2.10.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH BlueZ] lib/sdp: Remove deprecated VIDEO_CONF profile id
  2016-12-10 22:59 [PATCH BlueZ] lib/sdp: Remove deprecated VIDEO_CONF profile id Tomasz Gorochowik
@ 2017-01-16  7:32 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2017-01-16  7:32 UTC (permalink / raw
  To: Tomasz Gorochowik; +Cc: linux-bluetooth

Hi, Tomasz,

On Sat, Dec 10, 2016, Tomasz Gorochowik wrote:
> Commit 75e0c32af6bf ("lib/sdp: Replace VIDEO_CONF_SVCLASS_ID with
> AV_REMOTE_CONTROLLER_SVCLASS_ID") removed the deprecated
> VIDEO_CONF_SVCLASS_ID definition, but left the corresponding profile
> definition..
> 
> According to the specification linked below A/V_RemoteControlController
> UUID can only be used as a service class so its profile definition
> should be removed.
> 
> https://www.bluetooth.org/en-us/specification/assigned-numbers/service-discovery
> ---
>  lib/sdp.h | 1 -
>  1 file changed, 1 deletion(-)

Applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-16  7:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-10 22:59 [PATCH BlueZ] lib/sdp: Remove deprecated VIDEO_CONF profile id Tomasz Gorochowik
2017-01-16  7:32 ` Johan Hedberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.