* [PATCH 3/4] staging: atomisp: remove useless #ifdef ISP2401 on top of atomisp_cmd.c
@ 2017-03-15 5:55 ` Daeseok Youn
0 siblings, 0 replies; 6+ messages in thread
From: Daeseok Youn @ 2017-03-15 5:55 UTC (permalink / raw
To: mchehab
Cc: gregkh, daeseok.youn, alan, dan.carpenter, singhalsimran0,
linux-media, devel, linux-kernel, kernel-janitors
There is no reason to have "#ifdef ISP2401" condition
on top of atomisp_cmd.c file
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
index 6160119..82e7382 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
@@ -1,6 +1,3 @@
-#ifdef ISP2401
-
-#endif
/*
* Support for Medifield PNW Camera Imaging ISP subsystem.
*
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] staging: atomisp: remove useless #ifdef ISP2401 on top of atomisp_cmd.c
@ 2017-03-15 5:55 ` Daeseok Youn
0 siblings, 0 replies; 6+ messages in thread
From: Daeseok Youn @ 2017-03-15 5:55 UTC (permalink / raw
To: mchehab
Cc: gregkh, daeseok.youn, alan, dan.carpenter, singhalsimran0,
linux-media, devel, linux-kernel, kernel-janitors
There is no reason to have "#ifdef ISP2401" condition
on top of atomisp_cmd.c file
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
index 6160119..82e7382 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
@@ -1,6 +1,3 @@
-#ifdef ISP2401
-
-#endif
/*
* Support for Medifield PNW Camera Imaging ISP subsystem.
*
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] staging: atomisp: remove useless condition in if-statements
2017-03-15 5:55 ` Daeseok Youn
@ 2017-03-20 11:00 ` Daeseok Youn
-1 siblings, 0 replies; 6+ messages in thread
From: Daeseok Youn @ 2017-03-20 11:00 UTC (permalink / raw
To: mchehab
Cc: gregkh, daeseok.youn, alan, singhalsimran0, dan.carpenter,
linux-media, devel, linux-kernel, kernel-janitors
The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if-
statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY',
it could not enter the next if-statement. But the "next" if-statement
has the condition to check whether the css_pipe_id equals to
'CSS_PIPE_ID_COPY' or not. It should be removed.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
index 6bdd19e..929ed80 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
@@ -910,8 +910,7 @@ static struct atomisp_video_pipe *__atomisp_get_pipe(
} else if (asd->run_mode->val == ATOMISP_RUN_MODE_VIDEO) {
/* For online video or SDV video pipe. */
if (css_pipe_id == CSS_PIPE_ID_VIDEO ||
- css_pipe_id == CSS_PIPE_ID_COPY ||
- css_pipe_id == CSS_PIPE_ID_YUVPP) {
+ css_pipe_id == CSS_PIPE_ID_COPY) {
if (buf_type == CSS_BUFFER_TYPE_OUTPUT_FRAME)
return &asd->video_out_video_capture;
return &asd->video_out_preview;
@@ -919,8 +918,7 @@ static struct atomisp_video_pipe *__atomisp_get_pipe(
} else if (asd->run_mode->val == ATOMISP_RUN_MODE_PREVIEW) {
/* For online preview or ZSL preview pipe. */
if (css_pipe_id == CSS_PIPE_ID_PREVIEW ||
- css_pipe_id == CSS_PIPE_ID_COPY ||
- css_pipe_id == CSS_PIPE_ID_YUVPP)
+ css_pipe_id == CSS_PIPE_ID_COPY)
return &asd->video_out_preview;
}
/* For capture pipe. */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] staging: atomisp: remove useless condition in if-statements
@ 2017-03-20 11:00 ` Daeseok Youn
0 siblings, 0 replies; 6+ messages in thread
From: Daeseok Youn @ 2017-03-20 11:00 UTC (permalink / raw
To: mchehab
Cc: gregkh, daeseok.youn, alan, singhalsimran0, dan.carpenter,
linux-media, devel, linux-kernel, kernel-janitors
The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if-
statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY',
it could not enter the next if-statement. But the "next" if-statement
has the condition to check whether the css_pipe_id equals to
'CSS_PIPE_ID_COPY' or not. It should be removed.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
index 6bdd19e..929ed80 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
@@ -910,8 +910,7 @@ static struct atomisp_video_pipe *__atomisp_get_pipe(
} else if (asd->run_mode->val = ATOMISP_RUN_MODE_VIDEO) {
/* For online video or SDV video pipe. */
if (css_pipe_id = CSS_PIPE_ID_VIDEO ||
- css_pipe_id = CSS_PIPE_ID_COPY ||
- css_pipe_id = CSS_PIPE_ID_YUVPP) {
+ css_pipe_id = CSS_PIPE_ID_COPY) {
if (buf_type = CSS_BUFFER_TYPE_OUTPUT_FRAME)
return &asd->video_out_video_capture;
return &asd->video_out_preview;
@@ -919,8 +918,7 @@ static struct atomisp_video_pipe *__atomisp_get_pipe(
} else if (asd->run_mode->val = ATOMISP_RUN_MODE_PREVIEW) {
/* For online preview or ZSL preview pipe. */
if (css_pipe_id = CSS_PIPE_ID_PREVIEW ||
- css_pipe_id = CSS_PIPE_ID_COPY ||
- css_pipe_id = CSS_PIPE_ID_YUVPP)
+ css_pipe_id = CSS_PIPE_ID_COPY)
return &asd->video_out_preview;
}
/* For capture pipe. */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] staging: atomisp: remove useless condition in if-statements
2017-03-20 11:00 ` Daeseok Youn
@ 2017-03-20 11:14 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-03-20 11:14 UTC (permalink / raw
To: Daeseok Youn
Cc: mchehab, gregkh, alan, singhalsimran0, linux-media, devel,
linux-kernel, kernel-janitors
On Mon, Mar 20, 2017 at 08:00:06PM +0900, Daeseok Youn wrote:
> The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if-
> statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY',
> it could not enter the next if-statement. But the "next" if-statement
> has the condition to check whether the css_pipe_id equals to
> 'CSS_PIPE_ID_COPY' or not. It should be removed.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
The patch is correct but the changelog is not.
s/CSS_PIPE_ID_COPY/CSS_PIPE_ID_YUVPP/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] staging: atomisp: remove useless condition in if-statements
@ 2017-03-20 11:14 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-03-20 11:14 UTC (permalink / raw
To: Daeseok Youn
Cc: mchehab, gregkh, alan, singhalsimran0, linux-media, devel,
linux-kernel, kernel-janitors
On Mon, Mar 20, 2017 at 08:00:06PM +0900, Daeseok Youn wrote:
> The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if-
> statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY',
> it could not enter the next if-statement. But the "next" if-statement
> has the condition to check whether the css_pipe_id equals to
> 'CSS_PIPE_ID_COPY' or not. It should be removed.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
The patch is correct but the changelog is not.
s/CSS_PIPE_ID_COPY/CSS_PIPE_ID_YUVPP/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-20 11:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-15 5:55 [PATCH 3/4] staging: atomisp: remove useless #ifdef ISP2401 on top of atomisp_cmd.c Daeseok Youn
2017-03-15 5:55 ` Daeseok Youn
-- strict thread matches above, loose matches on Subject: below --
2017-03-20 11:00 [PATCH 3/4] staging: atomisp: remove useless condition in if-statements Daeseok Youn
2017-03-20 11:00 ` Daeseok Youn
2017-03-20 11:14 ` Dan Carpenter
2017-03-20 11:14 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.