* [PATCH] crypto: glue_helper: remove redundant check on nbytes < bsize
@ 2017-05-10 13:04 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2017-05-10 13:04 UTC (permalink / raw
To: Herbert Xu, David S . Miller, Thomas Gleixner, Ingo Molnar,
H . Peter Anvin, x86, linux-crypto
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a check to see if nbytes < bsize (and a jump to label 'done' if
it is true) inside the proceeding do-while loop so it is impossible for
the second nbytes < bsize check to be true, hence is it redundant and
can be removed. Remove it.
Detected by CoverityScan, CID#712347 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/crypto/glue_helper.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/crypto/glue_helper.c b/arch/x86/crypto/glue_helper.c
index 24ac9fad832d..d61e57960fe0 100644
--- a/arch/x86/crypto/glue_helper.c
+++ b/arch/x86/crypto/glue_helper.c
@@ -176,9 +176,6 @@ __glue_cbc_decrypt_128bit(const struct common_glue_ctx *gctx,
src -= 1;
dst -= 1;
} while (nbytes >= func_bytes);
-
- if (nbytes < bsize)
- goto done;
}
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] crypto: glue_helper: remove redundant check on nbytes < bsize
@ 2017-05-10 13:04 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2017-05-10 13:04 UTC (permalink / raw
To: Herbert Xu, David S . Miller, Thomas Gleixner, Ingo Molnar,
H . Peter Anvin, x86, linux-crypto
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a check to see if nbytes < bsize (and a jump to label 'done' if
it is true) inside the proceeding do-while loop so it is impossible for
the second nbytes < bsize check to be true, hence is it redundant and
can be removed. Remove it.
Detected by CoverityScan, CID#712347 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/crypto/glue_helper.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/crypto/glue_helper.c b/arch/x86/crypto/glue_helper.c
index 24ac9fad832d..d61e57960fe0 100644
--- a/arch/x86/crypto/glue_helper.c
+++ b/arch/x86/crypto/glue_helper.c
@@ -176,9 +176,6 @@ __glue_cbc_decrypt_128bit(const struct common_glue_ctx *gctx,
src -= 1;
dst -= 1;
} while (nbytes >= func_bytes);
-
- if (nbytes < bsize)
- goto done;
}
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-10 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-10 13:04 [PATCH] crypto: glue_helper: remove redundant check on nbytes < bsize Colin King
2017-05-10 13:04 ` Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.