All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* Remove !HIGHMEM from mmci-spi
@ 2017-07-18 12:19 Ian Molton
  2017-07-18 12:19 ` [PATCH] MMC: Remove HIGHMEM dependency from mmc-spi driver Ian Molton
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Molton @ 2017-07-18 12:19 UTC (permalink / raw
  To: linux-mmc; +Cc: ulf.hansson

Hi folks,

I cannot find anything to support the need for !HIGHMEM to be
set in this driver. Let's remove the dependency.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] MMC: Remove HIGHMEM dependency from mmc-spi driver
  2017-07-18 12:19 Remove !HIGHMEM from mmci-spi Ian Molton
@ 2017-07-18 12:19 ` Ian Molton
  2017-07-27 14:48   ` Ulf Hansson
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Molton @ 2017-07-18 12:19 UTC (permalink / raw
  To: linux-mmc; +Cc: ulf.hansson

I cannot see why this is needed. kmap() should be safe in this case.

Signed-off-by: Ian Molton <ian@mnementh.co.uk>
---
 drivers/mmc/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 5755b69f2f72..a8980e9e688b 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -494,7 +494,7 @@ config MMC_GOLDFISH
 
 config MMC_SPI
 	tristate "MMC/SD/SDIO over SPI"
-	depends on SPI_MASTER && !HIGHMEM && HAS_DMA
+	depends on SPI_MASTER && HAS_DMA
 	select CRC7
 	select CRC_ITU_T
 	help
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] MMC: Remove HIGHMEM dependency from mmc-spi driver
  2017-07-18 12:19 ` [PATCH] MMC: Remove HIGHMEM dependency from mmc-spi driver Ian Molton
@ 2017-07-27 14:48   ` Ulf Hansson
  0 siblings, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2017-07-27 14:48 UTC (permalink / raw
  To: Ian Molton; +Cc: linux-mmc@vger.kernel.org

On 18 July 2017 at 14:19, Ian Molton <ian@mnementh.co.uk> wrote:
> I cannot see why this is needed. kmap() should be safe in this case.
>
> Signed-off-by: Ian Molton <ian@mnementh.co.uk>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 5755b69f2f72..a8980e9e688b 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -494,7 +494,7 @@ config MMC_GOLDFISH
>
>  config MMC_SPI
>         tristate "MMC/SD/SDIO over SPI"
> -       depends on SPI_MASTER && !HIGHMEM && HAS_DMA
> +       depends on SPI_MASTER && HAS_DMA
>         select CRC7
>         select CRC_ITU_T
>         help
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-27 14:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-18 12:19 Remove !HIGHMEM from mmci-spi Ian Molton
2017-07-18 12:19 ` [PATCH] MMC: Remove HIGHMEM dependency from mmc-spi driver Ian Molton
2017-07-27 14:48   ` Ulf Hansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.