* [PATCH] ieee802154: atusb: fix firmware version check to enable frame retries
@ 2017-09-22 8:44 Stefan Schmidt
2017-09-26 13:45 ` Stefan Schmidt
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Schmidt @ 2017-09-22 8:44 UTC (permalink / raw
To: linux-wpan; +Cc: Alexander Aring, Stefan Schmidt
Geert reported: as fw_ver_maj is unsigned char, gcc 4.1.2 complains:
warning: comparison is always true due to limited range of data type
Besides the warning the old check would also fail for firmware versions
like 1.x with x < 3. These would support frame retries, but the driver
would not enable the feature.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
---
drivers/net/ieee802154/atusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 115fa3f37a86..6b3cdf4bd667 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -1060,7 +1060,7 @@ static int atusb_probe(struct usb_interface *interface,
atusb_get_and_show_build(atusb);
atusb_set_extended_addr(atusb);
- if (atusb->fw_ver_maj >= 0 && atusb->fw_ver_min >= 3)
+ if ((atusb->fw_ver_maj == 0 && atusb->fw_ver_min >= 3) || atusb->fw_ver_maj > 0)
hw->flags |= IEEE802154_HW_FRAME_RETRIES;
ret = atusb_get_and_clear_error(atusb);
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ieee802154: atusb: fix firmware version check to enable frame retries
2017-09-22 8:44 [PATCH] ieee802154: atusb: fix firmware version check to enable frame retries Stefan Schmidt
@ 2017-09-26 13:45 ` Stefan Schmidt
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Schmidt @ 2017-09-26 13:45 UTC (permalink / raw
To: linux-wpan; +Cc: Alexander Aring
Hello.
On 09/22/2017 10:44 AM, Stefan Schmidt wrote:
> Geert reported: as fw_ver_maj is unsigned char, gcc 4.1.2 complains:
>
> warning: comparison is always true due to limited range of data type
>
> Besides the warning the old check would also fail for firmware versions
> like 1.x with x < 3. These would support frame retries, but the driver
> would not enable the feature.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
> ---
> drivers/net/ieee802154/atusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
> index 115fa3f37a86..6b3cdf4bd667 100644
> --- a/drivers/net/ieee802154/atusb.c
> +++ b/drivers/net/ieee802154/atusb.c
> @@ -1060,7 +1060,7 @@ static int atusb_probe(struct usb_interface *interface,
> atusb_get_and_show_build(atusb);
> atusb_set_extended_addr(atusb);
>
> - if (atusb->fw_ver_maj >= 0 && atusb->fw_ver_min >= 3)
> + if ((atusb->fw_ver_maj == 0 && atusb->fw_ver_min >= 3) || atusb->fw_ver_maj > 0)
> hw->flags |= IEEE802154_HW_FRAME_RETRIES;
>
> ret = atusb_get_and_clear_error(atusb);
>
This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-26 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 8:44 [PATCH] ieee802154: atusb: fix firmware version check to enable frame retries Stefan Schmidt
2017-09-26 13:45 ` Stefan Schmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.