* [PATCH] afs: cell: Remove unnecessary code in afs_lookup_cell
@ 2017-11-17 22:40 Gustavo A. R. Silva
2017-11-20 22:21 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-17 22:40 UTC (permalink / raw
To: David Howells; +Cc: linux-afs, linux-kernel, Gustavo A. R. Silva
Due to recent changes this piece of code is no longer needed.
Addresses-Coverity-ID: 1462033
Link: https://lkml.kernel.org/r/4923.1510957307@warthog.procyon.org.uk
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
fs/afs/cell.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/fs/afs/cell.c b/fs/afs/cell.c
index 1858c91..9bb921d 100644
--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -207,13 +207,8 @@ struct afs_cell *afs_lookup_cell(struct afs_net *net,
rcu_read_lock();
cell = afs_lookup_cell_rcu(net, name, namesz);
rcu_read_unlock();
- if (!IS_ERR(cell)) {
- if (excl) {
- afs_put_cell(net, cell);
- return ERR_PTR(-EEXIST);
- }
+ if (!IS_ERR(cell))
goto wait_for_cell;
- }
}
/* Assume we're probably going to create a cell and preallocate and
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] afs: cell: Remove unnecessary code in afs_lookup_cell
2017-11-17 22:40 [PATCH] afs: cell: Remove unnecessary code in afs_lookup_cell Gustavo A. R. Silva
@ 2017-11-20 22:21 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2017-11-20 22:21 UTC (permalink / raw
To: Gustavo A. R. Silva; +Cc: dhowells, linux-afs, linux-kernel
Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
> Due to recent changes this piece of code is no longer needed.
>
> Addresses-Coverity-ID: 1462033
> Link: https://lkml.kernel.org/r/4923.1510957307@warthog.procyon.org.uk
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied, thanks.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-20 22:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-17 22:40 [PATCH] afs: cell: Remove unnecessary code in afs_lookup_cell Gustavo A. R. Silva
2017-11-20 22:21 ` David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.