* [Buildroot] [PATCH] toolchain/toolchain-external: libatomic should also be copied for musl toolchains
@ 2018-01-16 22:48 Thomas Petazzoni
2018-01-17 18:16 ` Yann E. MORIN
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-01-16 22:48 UTC (permalink / raw
To: buildroot
libatomic, like libgcc_s, is provided by gcc, so there is no reason to
copy it over only for the glibc and uclibc cases, it should also be
copied for the musl case. Without this, a program linked with
libatomic on a musl system will fail to run due to the missing
library.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
index b9ad1720a1..3bf9fac412 100644
--- a/toolchain/toolchain-external/pkg-toolchain-external.mk
+++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
@@ -108,10 +108,10 @@ endif
# Definitions of the list of libraries that should be copied to the target.
#
-TOOLCHAIN_EXTERNAL_LIBS += ld*.so* libgcc_s.so.*
+TOOLCHAIN_EXTERNAL_LIBS += ld*.so* libgcc_s.so.* libatomic.so.*
ifeq ($(BR2_TOOLCHAIN_EXTERNAL_GLIBC)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC),y)
-TOOLCHAIN_EXTERNAL_LIBS += libatomic.so.* libc.so.* libcrypt.so.* libdl.so.* libm.so.* libnsl.so.* libresolv.so.* librt.so.* libutil.so.*
+TOOLCHAIN_EXTERNAL_LIBS += libc.so.* libcrypt.so.* libdl.so.* libm.so.* libnsl.so.* libresolv.so.* librt.so.* libutil.so.*
ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
TOOLCHAIN_EXTERNAL_LIBS += libpthread.so.*
ifneq ($(BR2_PACKAGE_GDB)$(BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY),)
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain/toolchain-external: libatomic should also be copied for musl toolchains
2018-01-16 22:48 [Buildroot] [PATCH] toolchain/toolchain-external: libatomic should also be copied for musl toolchains Thomas Petazzoni
@ 2018-01-17 18:16 ` Yann E. MORIN
2018-01-17 21:38 ` Thomas Petazzoni
2018-01-21 20:24 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2018-01-17 18:16 UTC (permalink / raw
To: buildroot
Thomas, All,
On 2018-01-16 23:48 +0100, Thomas Petazzoni spake thusly:
> libatomic, like libgcc_s, is provided by gcc, so there is no reason to
> copy it over only for the glibc and uclibc cases, it should also be
> copied for the musl case. Without this, a program linked with
> libatomic on a musl system will fail to run due to the missing
> library.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> index b9ad1720a1..3bf9fac412 100644
> --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> @@ -108,10 +108,10 @@ endif
> # Definitions of the list of libraries that should be copied to the target.
> #
>
> -TOOLCHAIN_EXTERNAL_LIBS += ld*.so* libgcc_s.so.*
> +TOOLCHAIN_EXTERNAL_LIBS += ld*.so* libgcc_s.so.* libatomic.so.*
>
> ifeq ($(BR2_TOOLCHAIN_EXTERNAL_GLIBC)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC),y)
> -TOOLCHAIN_EXTERNAL_LIBS += libatomic.so.* libc.so.* libcrypt.so.* libdl.so.* libm.so.* libnsl.so.* libresolv.so.* librt.so.* libutil.so.*
> +TOOLCHAIN_EXTERNAL_LIBS += libc.so.* libcrypt.so.* libdl.so.* libm.so.* libnsl.so.* libresolv.so.* librt.so.* libutil.so.*
> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> TOOLCHAIN_EXTERNAL_LIBS += libpthread.so.*
> ifneq ($(BR2_PACKAGE_GDB)$(BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY),)
> --
> 2.14.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain/toolchain-external: libatomic should also be copied for musl toolchains
2018-01-16 22:48 [Buildroot] [PATCH] toolchain/toolchain-external: libatomic should also be copied for musl toolchains Thomas Petazzoni
2018-01-17 18:16 ` Yann E. MORIN
@ 2018-01-17 21:38 ` Thomas Petazzoni
2018-01-21 20:24 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-01-17 21:38 UTC (permalink / raw
To: buildroot
Hello,
On Tue, 16 Jan 2018 23:48:08 +0100, Thomas Petazzoni wrote:
> libatomic, like libgcc_s, is provided by gcc, so there is no reason to
> copy it over only for the glibc and uclibc cases, it should also be
> copied for the musl case. Without this, a program linked with
> libatomic on a musl system will fail to run due to the missing
> library.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain/toolchain-external: libatomic should also be copied for musl toolchains
2018-01-16 22:48 [Buildroot] [PATCH] toolchain/toolchain-external: libatomic should also be copied for musl toolchains Thomas Petazzoni
2018-01-17 18:16 ` Yann E. MORIN
2018-01-17 21:38 ` Thomas Petazzoni
@ 2018-01-21 20:24 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-01-21 20:24 UTC (permalink / raw
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> libatomic, like libgcc_s, is provided by gcc, so there is no reason to
> copy it over only for the glibc and uclibc cases, it should also be
> copied for the musl case. Without this, a program linked with
> libatomic on a musl system will fail to run due to the missing
> library.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Committed to 2017.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-21 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-16 22:48 [Buildroot] [PATCH] toolchain/toolchain-external: libatomic should also be copied for musl toolchains Thomas Petazzoni
2018-01-17 18:16 ` Yann E. MORIN
2018-01-17 21:38 ` Thomas Petazzoni
2018-01-21 20:24 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.