* [PATCH] net: phy: replace bool members in struct phy_device with bit-fields
@ 2018-05-23 6:05 Heiner Kallweit
2018-05-23 22:11 ` Andrew Lunn
2018-05-24 19:36 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2018-05-23 6:05 UTC (permalink / raw
To: Florian Fainelli, Andrew Lunn; +Cc: netdev@vger.kernel.org
In struct phy_device we have a number of flags being defined as type
bool. Similar to e.g. struct pci_dev we can save some space by using
bit-fields.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
include/linux/phy.h | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 073235e70..6cd090984 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -406,13 +406,17 @@ struct phy_device {
u32 phy_id;
struct phy_c45_device_ids c45_ids;
- bool is_c45;
- bool is_internal;
- bool is_pseudo_fixed_link;
- bool has_fixups;
- bool suspended;
- bool sysfs_links;
- bool loopback_enabled;
+ unsigned is_c45:1;
+ unsigned is_internal:1;
+ unsigned is_pseudo_fixed_link:1;
+ unsigned has_fixups:1;
+ unsigned suspended:1;
+ unsigned sysfs_links:1;
+ unsigned loopback_enabled:1;
+
+ unsigned autoneg:1;
+ /* The most recently read link state */
+ unsigned link:1;
enum phy_state state;
@@ -429,9 +433,6 @@ struct phy_device {
int pause;
int asym_pause;
- /* The most recently read link state */
- int link;
-
/* Enabled Interrupts */
u32 interrupts;
@@ -444,8 +445,6 @@ struct phy_device {
/* Energy efficient ethernet modes which should be prohibited */
u32 eee_broken_modes;
- int autoneg;
-
int link_timeout;
#ifdef CONFIG_LED_TRIGGER_PHY
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: replace bool members in struct phy_device with bit-fields
2018-05-23 6:05 [PATCH] net: phy: replace bool members in struct phy_device with bit-fields Heiner Kallweit
@ 2018-05-23 22:11 ` Andrew Lunn
2018-05-24 19:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-05-23 22:11 UTC (permalink / raw
To: Heiner Kallweit; +Cc: Florian Fainelli, netdev@vger.kernel.org
On Wed, May 23, 2018 at 08:05:20AM +0200, Heiner Kallweit wrote:
> In struct phy_device we have a number of flags being defined as type
> bool. Similar to e.g. struct pci_dev we can save some space by using
> bit-fields.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: replace bool members in struct phy_device with bit-fields
2018-05-23 6:05 [PATCH] net: phy: replace bool members in struct phy_device with bit-fields Heiner Kallweit
2018-05-23 22:11 ` Andrew Lunn
@ 2018-05-24 19:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-05-24 19:36 UTC (permalink / raw
To: hkallweit1; +Cc: f.fainelli, andrew, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Wed, 23 May 2018 08:05:20 +0200
> In struct phy_device we have a number of flags being defined as type
> bool. Similar to e.g. struct pci_dev we can save some space by using
> bit-fields.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-24 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-23 6:05 [PATCH] net: phy: replace bool members in struct phy_device with bit-fields Heiner Kallweit
2018-05-23 22:11 ` Andrew Lunn
2018-05-24 19:36 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.