All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH radeon-alex] drm/amdgpu: vcn_v1_0_is_idle() can be static
  2018-05-24 18:54 [radeon-alex:drm-next-4.18-wip 114/129] drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:689:6: sparse: symbol 'vcn_v1_0_is_idle' was not declared. Should it be static? kbuild test robot
@ 2018-05-24 18:54 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-05-24 18:54 UTC (permalink / raw
  To: Rex Zhu; +Cc: Alex Deucher, kbuild-all, dri-devel


Fixes: 9b4c412a654c ("drm/amdgpu: Add static CG control for VCN on RV")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 vcn_v1_0.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
index 7a366418..2b4a789 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
@@ -686,14 +686,14 @@ static int vcn_v1_0_stop(struct amdgpu_device *adev)
 	return 0;
 }
 
-bool vcn_v1_0_is_idle(void *handle)
+static bool vcn_v1_0_is_idle(void *handle)
 {
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
 	return (RREG32_SOC15(VCN, 0, mmUVD_STATUS) == 0x2);
 }
 
-int vcn_v1_0_wait_for_idle(void *handle)
+static int vcn_v1_0_wait_for_idle(void *handle)
 {
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 	int ret = 0;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [radeon-alex:drm-next-4.18-wip 114/129] drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:689:6: sparse: symbol 'vcn_v1_0_is_idle' was not declared. Should it be static?
@ 2018-05-24 18:54 kbuild test robot
  2018-05-24 18:54 ` [RFC PATCH radeon-alex] drm/amdgpu: vcn_v1_0_is_idle() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-05-24 18:54 UTC (permalink / raw
  To: Rex Zhu; +Cc: Alex Deucher, kbuild-all, dri-devel

tree:   git://people.freedesktop.org/~agd5f/linux.git drm-next-4.18-wip
head:   27bd044dd054fed87166c831b6d38bc609e733cc
commit: 9b4c412a654ce71ad0e81044d3300677a7668ac8 [114/129] drm/amdgpu: Add static CG control for VCN on RV
reproduce:
        # apt-get install sparse
        git checkout 9b4c412a654ce71ad0e81044d3300677a7668ac8
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:689:6: sparse: symbol 'vcn_v1_0_is_idle' was not declared. Should it be static?
>> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:696:5: sparse: symbol 'vcn_v1_0_wait_for_idle' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-24 18:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-24 18:54 [radeon-alex:drm-next-4.18-wip 114/129] drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:689:6: sparse: symbol 'vcn_v1_0_is_idle' was not declared. Should it be static? kbuild test robot
2018-05-24 18:54 ` [RFC PATCH radeon-alex] drm/amdgpu: vcn_v1_0_is_idle() can be static kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.