* [PATCH v5] block: add verifier for cmdline partition
@ 2018-05-10 3:06 Wang YanQing
2018-06-05 9:38 ` Wang YanQing
2018-06-05 15:21 ` Jens Axboe
0 siblings, 2 replies; 5+ messages in thread
From: Wang YanQing @ 2018-05-10 3:06 UTC (permalink / raw
To: axboe
Cc: gregkh, pombredanne, tglx, caizhiyong, rdunlap, jiangheng,
linux-block, linux-kernel
I meet strange filesystem corruption issue recently, the reason
is there are overlaps partitions in cmdline partition argument.
This patch add verifier for cmdline partition, then if there are
overlaps partitions, cmdline_partition will log a warning. We don't
treat overlaps partition as a error:
"
Caizhiyong <caizhiyong@hisilicon.com> said:
Partition overlap was intentionally designed in this cmdline partition.
reference http://lists.infradead.org/pipermail/linux-mtd/2013-August/048092.html
"
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
Changes
v4-v5:
1:Delete unnecessary blank line at begin and end of logs.
2:Delete newline character in log, pr_* will add newline
automatically.
v3-v4:
1:Fix grammar typo, reported by Randy Dunlap.
2:Delete unnecessary type casting, reported by Caizhiyong.
3:Record the reason why we can't treat overlapping partitions
as errors into changelog.
v2-v3:
1:Fix log one pair of overlaps partitions twice in cmdline_parts_verifier.
2:Fix out of bound access in cmdline_parts_verifier.
v1-v2:
1:Don't treat overlaps partition as a error, but log a warning.
Hi! Jens Axboe
What is your suggestion?
block/partitions/cmdline.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/block/partitions/cmdline.c b/block/partitions/cmdline.c
index e333583..60fb3df 100644
--- a/block/partitions/cmdline.c
+++ b/block/partitions/cmdline.c
@@ -58,6 +58,62 @@ static int __init cmdline_parts_setup(char *s)
}
__setup("blkdevparts=", cmdline_parts_setup);
+static bool has_overlaps(sector_t from, sector_t size,
+ sector_t from2, sector_t size2)
+{
+ sector_t end = from + size;
+ sector_t end2 = from2 + size2;
+
+ if (from >= from2 && from < end2)
+ return true;
+
+ if (end > from2 && end <= end2)
+ return true;
+
+ if (from2 >= from && from2 < end)
+ return true;
+
+ if (end2 > from && end2 <= end)
+ return true;
+
+ return false;
+}
+
+static inline void overlaps_warns_header(void)
+{
+ pr_warn("Overlapping partitions are used in command line partitions.");
+ pr_warn("Don't use filesystems on overlapping partitions:");
+}
+
+static void cmdline_parts_verifier(int slot, struct parsed_partitions *state)
+{
+ int i;
+ bool header = true;
+
+ for (; slot < state->limit && state->parts[slot].has_info; slot++) {
+ for (i = slot+1; i < state->limit && state->parts[i].has_info;
+ i++) {
+ if (has_overlaps(state->parts[slot].from,
+ state->parts[slot].size,
+ state->parts[i].from,
+ state->parts[i].size)) {
+ if (header) {
+ header = false;
+ overlaps_warns_header();
+ }
+ pr_warn("%s[%llu,%llu] overlaps with "
+ "%s[%llu,%llu].",
+ state->parts[slot].info.volname,
+ (u64)state->parts[slot].from << 9,
+ (u64)state->parts[slot].size << 9,
+ state->parts[i].info.volname,
+ (u64)state->parts[i].from << 9,
+ (u64)state->parts[i].size << 9);
+ }
+ }
+ }
+}
+
/*
* Purpose: allocate cmdline partitions.
* Returns:
@@ -93,6 +149,7 @@ int cmdline_partition(struct parsed_partitions *state)
disk_size = get_capacity(state->bdev->bd_disk) << 9;
cmdline_parts_set(parts, disk_size, 1, add_part, (void *)state);
+ cmdline_parts_verifier(1, state);
strlcat(state->pp_buf, "\n", PAGE_SIZE);
--
1.8.5.6.2.g3d8a54e.dirty
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v5] block: add verifier for cmdline partition
2018-05-10 3:06 [PATCH v5] block: add verifier for cmdline partition Wang YanQing
@ 2018-06-05 9:38 ` Wang YanQing
2018-06-05 10:54 ` Caizhiyong
2018-06-05 15:21 ` Jens Axboe
1 sibling, 1 reply; 5+ messages in thread
From: Wang YanQing @ 2018-06-05 9:38 UTC (permalink / raw
To: axboe, gregkh, pombredanne, tglx, caizhiyong, rdunlap, jiangheng,
linux-block, linux-kernel
On Thu, May 10, 2018 at 11:06:37AM +0800, Wang YanQing wrote:
> I meet strange filesystem corruption issue recently, the reason
> is there are overlaps partitions in cmdline partition argument.
>
> This patch add verifier for cmdline partition, then if there are
> overlaps partitions, cmdline_partition will log a warning. We don't
> treat overlaps partition as a error:
> "
> Caizhiyong <caizhiyong@hisilicon.com> said:
> Partition overlap was intentionally designed in this cmdline partition.
> reference http://lists.infradead.org/pipermail/linux-mtd/2013-August/048092.html
> "
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> ---
> Changes
> v4-v5:
> 1:Delete unnecessary blank line at begin and end of logs.
> 2:Delete newline character in log, pr_* will add newline
> automatically.
>
> v3-v4:
> 1:Fix grammar typo, reported by Randy Dunlap.
> 2:Delete unnecessary type casting, reported by Caizhiyong.
> 3:Record the reason why we can't treat overlapping partitions
> as errors into changelog.
>
> v2-v3:
> 1:Fix log one pair of overlaps partitions twice in cmdline_parts_verifier.
> 2:Fix out of bound access in cmdline_parts_verifier.
>
> v1-v2:
> 1:Don't treat overlaps partition as a error, but log a warning.
>
> Hi! Jens Axboe
>
> What is your suggestion?
Hi! All
I just want to know what is the status about this patch?
ACK or NACK is welcome.
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v5] block: add verifier for cmdline partition
2018-06-05 9:38 ` Wang YanQing
@ 2018-06-05 10:54 ` Caizhiyong
0 siblings, 0 replies; 5+ messages in thread
From: Caizhiyong @ 2018-06-05 10:54 UTC (permalink / raw
To: Wang YanQing, axboe@kernel.dk, gregkh@linuxfoundation.org,
pombredanne@nexb.com, tglx@linutronix.de, rdunlap@infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiangheng
ACK.
the patch is OK for me
> -----Original Message-----
> From: Wang YanQing [mailto:udknight@gmail.com]
> Sent: Tuesday, June 05, 2018 5:39 PM
> To: axboe@kernel.dk; gregkh@linuxfoundation.org;
> pombredanne@nexb.com; tglx@linutronix.de; Caizhiyong
> <caizhiyong@hisilicon.com>; rdunlap@infradead.org; Jiangheng
> <jiangheng@hisilicon.com>; linux-block@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v5] block: add verifier for cmdline partition
>
> On Thu, May 10, 2018 at 11:06:37AM +0800, Wang YanQing wrote:
> > I meet strange filesystem corruption issue recently, the reason
> > is there are overlaps partitions in cmdline partition argument.
> >
> > This patch add verifier for cmdline partition, then if there are
> > overlaps partitions, cmdline_partition will log a warning. We don't
> > treat overlaps partition as a error:
> > "
> > Caizhiyong <caizhiyong@hisilicon.com> said:
> > Partition overlap was intentionally designed in this cmdline partition.
> > reference http://lists.infradead.org/pipermail/linux-mtd/2013-
> August/048092.html
> > "
> >
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
> > ---
> > Changes
> > v4-v5:
> > 1:Delete unnecessary blank line at begin and end of logs.
> > 2:Delete newline character in log, pr_* will add newline
> > automatically.
> >
> > v3-v4:
> > 1:Fix grammar typo, reported by Randy Dunlap.
> > 2:Delete unnecessary type casting, reported by Caizhiyong.
> > 3:Record the reason why we can't treat overlapping partitions
> > as errors into changelog.
> >
> > v2-v3:
> > 1:Fix log one pair of overlaps partitions twice in cmdline_parts_verifier.
> > 2:Fix out of bound access in cmdline_parts_verifier.
> >
> > v1-v2:
> > 1:Don't treat overlaps partition as a error, but log a warning.
> >
> > Hi! Jens Axboe
> >
> > What is your suggestion?
> Hi! All
>
> I just want to know what is the status about this patch?
>
> ACK or NACK is welcome.
>
> Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v5] block: add verifier for cmdline partition
@ 2018-06-05 10:54 ` Caizhiyong
0 siblings, 0 replies; 5+ messages in thread
From: Caizhiyong @ 2018-06-05 10:54 UTC (permalink / raw
To: Wang YanQing, axboe@kernel.dk, gregkh@linuxfoundation.org,
pombredanne@nexb.com, tglx@linutronix.de, rdunlap@infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiangheng
ACK.
the patch is OK for me
> -----Original Message-----
> From: Wang YanQing [mailto:udknight@gmail.com]
> Sent: Tuesday, June 05, 2018 5:39 PM
> To: axboe@kernel.dk; gregkh@linuxfoundation.org;
> pombredanne@nexb.com; tglx@linutronix.de; Caizhiyong
> <caizhiyong@hisilicon.com>; rdunlap@infradead.org; Jiangheng
> <jiangheng@hisilicon.com>; linux-block@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v5] block: add verifier for cmdline partition
>=20
> On Thu, May 10, 2018 at 11:06:37AM +0800, Wang YanQing wrote:
> > I meet strange filesystem corruption issue recently, the reason
> > is there are overlaps partitions in cmdline partition argument.
> >
> > This patch add verifier for cmdline partition, then if there are
> > overlaps partitions, cmdline_partition will log a warning. We don't
> > treat overlaps partition as a error:
> > "
> > Caizhiyong <caizhiyong@hisilicon.com> said:
> > Partition overlap was intentionally designed in this cmdline partition.
> > reference http://lists.infradead.org/pipermail/linux-mtd/2013-
> August/048092.html
> > "
> >
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
> > ---
> > Changes
> > v4-v5:
> > 1:Delete unnecessary blank line at begin and end of logs.
> > 2:Delete newline character in log, pr_* will add newline
> > automatically.
> >
> > v3-v4:
> > 1:Fix grammar typo, reported by Randy Dunlap.
> > 2:Delete unnecessary type casting, reported by Caizhiyong.
> > 3:Record the reason why we can't treat overlapping partitions
> > as errors into changelog.
> >
> > v2-v3:
> > 1:Fix log one pair of overlaps partitions twice in cmdline_parts_verif=
ier.
> > 2:Fix out of bound access in cmdline_parts_verifier.
> >
> > v1-v2:
> > 1:Don't treat overlaps partition as a error, but log a warning.
> >
> > Hi! Jens Axboe
> >
> > What is your suggestion?
> Hi! All
>=20
> I just want to know what is the status about this patch?
>=20
> ACK or NACK is welcome.
>=20
> Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5] block: add verifier for cmdline partition
2018-05-10 3:06 [PATCH v5] block: add verifier for cmdline partition Wang YanQing
2018-06-05 9:38 ` Wang YanQing
@ 2018-06-05 15:21 ` Jens Axboe
1 sibling, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2018-06-05 15:21 UTC (permalink / raw
To: Wang YanQing, gregkh, pombredanne, tglx, caizhiyong, rdunlap,
jiangheng, linux-block, linux-kernel
On 5/9/18 9:06 PM, Wang YanQing wrote:
> I meet strange filesystem corruption issue recently, the reason
> is there are overlaps partitions in cmdline partition argument.
>
> This patch add verifier for cmdline partition, then if there are
> overlaps partitions, cmdline_partition will log a warning. We don't
> treat overlaps partition as a error:
> "
> Caizhiyong <caizhiyong@hisilicon.com> said:
> Partition overlap was intentionally designed in this cmdline partition.
> reference http://lists.infradead.org/pipermail/linux-mtd/2013-August/048092.html
> "
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-05 15:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-10 3:06 [PATCH v5] block: add verifier for cmdline partition Wang YanQing
2018-06-05 9:38 ` Wang YanQing
2018-06-05 10:54 ` Caizhiyong
2018-06-05 10:54 ` Caizhiyong
2018-06-05 15:21 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.