* [PATCH] nvmet: use Retain Async Event bit to clear AEN
@ 2018-07-26 3:05 Chaitanya Kulkarni
2018-07-26 9:19 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Chaitanya Kulkarni @ 2018-07-26 3:05 UTC (permalink / raw
In the current implementation, we clear the AEN bit when we get the
"get log page" command if given log page is associated with AEN.
This patch allows optionally retaining the AEN for the ctrl
under consideration when Retain Asynchronous Event (RAE) bit is set
as a part of "get log page" command.
This allows the host to read the Log page and optionally retaining the
AEN associated with this log page when using userspace tools like
nvme-cli.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
---
drivers/nvme/target/admin-cmd.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 16a9b24270f9..de60dd6bd78c 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -19,6 +19,19 @@
#include <asm/unaligned.h>
#include "nvmet.h"
+/*
+ * This helper allows us to clear the AEN based on the RAE bit,
+ * Please use this helper when processing the log pages which are
+ * associated with the AEN.
+ */
+static inline void nvmet_clear_aen(struct nvmet_req *req)
+{
+ int rae = le32_to_cpu(req->cmd->common.cdw10[0]) & 1 << 15;
+
+ if (!rae)
+ clear_bit(NVME_AEN_CFG_NS_ATTR, &req->sq->ctrl->aen_masked);
+}
+
u32 nvmet_get_log_page_len(struct nvme_command *cmd)
{
u32 len = le16_to_cpu(cmd->get_log_page.numdu);
@@ -176,7 +189,7 @@ static void nvmet_execute_get_log_changed_ns(struct nvmet_req *req)
if (!status)
status = nvmet_zero_sgl(req, len, req->data_len - len);
ctrl->nr_changed_ns = 0;
- clear_bit(NVME_AEN_CFG_NS_ATTR, &ctrl->aen_masked);
+ nvmet_clear_aen(req);
mutex_unlock(&ctrl->lock);
out:
nvmet_req_complete(req, status);
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvmet: use Retain Async Event bit to clear AEN
2018-07-26 3:05 [PATCH] nvmet: use Retain Async Event bit to clear AEN Chaitanya Kulkarni
@ 2018-07-26 9:19 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2018-07-26 9:19 UTC (permalink / raw
On Wed, Jul 25, 2018@08:05:20PM -0700, Chaitanya Kulkarni wrote:
> In the current implementation, we clear the AEN bit when we get the
> "get log page" command if given log page is associated with AEN.
> This patch allows optionally retaining the AEN for the ctrl
> under consideration when Retain Asynchronous Event (RAE) bit is set
> as a part of "get log page" command.
>
> This allows the host to read the Log page and optionally retaining the
> AEN associated with this log page when using userspace tools like
> nvme-cli.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
> ---
> drivers/nvme/target/admin-cmd.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
> index 16a9b24270f9..de60dd6bd78c 100644
> --- a/drivers/nvme/target/admin-cmd.c
> +++ b/drivers/nvme/target/admin-cmd.c
> @@ -19,6 +19,19 @@
> #include <asm/unaligned.h>
> #include "nvmet.h"
>
> +/*
> + * This helper allows us to clear the AEN based on the RAE bit,
> + * Please use this helper when processing the log pages which are
> + * associated with the AEN.
> + */
> +static inline void nvmet_clear_aen(struct nvmet_req *req)
> +{
> + int rae = le32_to_cpu(req->cmd->common.cdw10[0]) & 1 << 15;
> +
> + if (!rae)
> + clear_bit(NVME_AEN_CFG_NS_ATTR, &req->sq->ctrl->aen_masked);
> +}
I think this will need the bit for the aen passed in so that we can
reuse it for other log pages (e.g. the upcoming ANA one).
Otherwise it looks fine to me.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-26 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-26 3:05 [PATCH] nvmet: use Retain Async Event bit to clear AEN Chaitanya Kulkarni
2018-07-26 9:19 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.