* [PATCH] irq: ingenic: Drop dependency on MACH_INGENIC
@ 2018-08-21 13:49 Paul Cercueil
2018-08-23 2:30 ` kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: Paul Cercueil @ 2018-08-21 13:49 UTC (permalink / raw
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: od, linux-kernel, Paul Cercueil
Depending on MACH_INGENIC prevent us from creating a generic kernel
that works on more than one MIPS board. Instead, we just depend on
MIPS being set.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/irqchip/Kconfig | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index e9233db16e03..04628af89b60 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -269,9 +269,13 @@ config MIPS_GIC
select MIPS_CM
config INGENIC_IRQ
- bool
- depends on MACH_INGENIC
- default y
+ bool "Ingenic JZ47xx IRQ controller"
+ depends on MIPS
+ default MACH_INGENIC
+ help
+ Support the interrupt controller present on JZ47xx SoCs from Ingenic.
+
+ If compiling for an Ingenic JZ47xx SoC, you want to say Y here.
config RENESAS_H8300H_INTC
bool
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irq: ingenic: Drop dependency on MACH_INGENIC
2018-08-21 13:49 [PATCH] irq: ingenic: Drop dependency on MACH_INGENIC Paul Cercueil
@ 2018-08-23 2:30 ` kbuild test robot
2018-08-23 12:50 ` Paul Cercueil
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-08-23 2:30 UTC (permalink / raw
To: Paul Cercueil
Cc: kbuild-all, Thomas Gleixner, Jason Cooper, Marc Zyngier, od,
linux-kernel, Paul Cercueil
[-- Attachment #1: Type: text/plain, Size: 2131 bytes --]
Hi Paul,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/irq/core]
[also build test WARNING on v4.18 next-20180822]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Paul-Cercueil/irq-ingenic-Drop-dependency-on-MACH_INGENIC/20180822-083429
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=mips
All warnings (new ones prefixed by >>):
In file included from drivers//irqchip/irq-ingenic.c:30:0:
>> arch/mips/include/asm/mach-jz4740/irq.h:63:0: warning: "NR_IRQS" redefined
#define NR_IRQS (JZ4740_IRQ_ADC_BASE + 6)
In file included from arch/mips/include/asm/irq.h:18:0,
from include/linux/irq.h:23,
from include/asm-generic/hardirq.h:13,
from arch/mips/include/asm/hardirq.h:16,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from drivers//irqchip/irq-ingenic.c:19:
arch/mips/include/asm/mach-generic/irq.h:12:0: note: this is the location of the previous definition
#define NR_IRQS 128
vim +/NR_IRQS +63 arch/mips/include/asm/mach-jz4740/irq.h
9869848d Lars-Peter Clausen 2010-07-17 62
9869848d Lars-Peter Clausen 2010-07-17 @63 #define NR_IRQS (JZ4740_IRQ_ADC_BASE + 6)
9869848d Lars-Peter Clausen 2010-07-17 64
:::::: The code at line 63 was first introduced by commit
:::::: 9869848d12601cdddf097a36aebe0b10dc5d177b MIPS: JZ4740: Add IRQ handler code
:::::: TO: Lars-Peter Clausen <lars@metafoo.de>
:::::: CC: Ralf Baechle <ralf@linux-mips.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 56393 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irq: ingenic: Drop dependency on MACH_INGENIC
2018-08-23 2:30 ` kbuild test robot
@ 2018-08-23 12:50 ` Paul Cercueil
0 siblings, 0 replies; 3+ messages in thread
From: Paul Cercueil @ 2018-08-23 12:50 UTC (permalink / raw
To: kbuild test robot
Cc: kbuild-all, Thomas Gleixner, Jason Cooper, Marc Zyngier, od,
linux-kernel
OK, forget this patch.
I need to drop the <asm/mach-jz4740/irq.h> include first and
there's a bit of work to do before I can achieve that.
-Paul Cercueil
Le jeu. 23 août 2018 à 4:30, kbuild test robot <lkp@intel.com> a
écrit :
> Hi Paul,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on tip/irq/core]
> [also build test WARNING on v4.18 next-20180822]
> [if your patch is applied to the wrong git tree, please drop us a
> note to help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Paul-Cercueil/irq-ingenic-Drop-dependency-on-MACH_INGENIC/20180822-083429
> config: mips-allmodconfig (attached as .config)
> compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.2.0 make.cross ARCH=mips
>
> All warnings (new ones prefixed by >>):
>
> In file included from drivers//irqchip/irq-ingenic.c:30:0:
>>> arch/mips/include/asm/mach-jz4740/irq.h:63:0: warning: "NR_IRQS"
>>> redefined
> #define NR_IRQS (JZ4740_IRQ_ADC_BASE + 6)
>
> In file included from arch/mips/include/asm/irq.h:18:0,
> from include/linux/irq.h:23,
> from include/asm-generic/hardirq.h:13,
> from arch/mips/include/asm/hardirq.h:16,
> from include/linux/hardirq.h:9,
> from include/linux/interrupt.h:11,
> from drivers//irqchip/irq-ingenic.c:19:
> arch/mips/include/asm/mach-generic/irq.h:12:0: note: this is the
> location of the previous definition
> #define NR_IRQS 128
>
>
> vim +/NR_IRQS +63 arch/mips/include/asm/mach-jz4740/irq.h
>
> 9869848d Lars-Peter Clausen 2010-07-17 62
> 9869848d Lars-Peter Clausen 2010-07-17 @63 #define NR_IRQS
> (JZ4740_IRQ_ADC_BASE + 6)
> 9869848d Lars-Peter Clausen 2010-07-17 64
>
> :::::: The code at line 63 was first introduced by commit
> :::::: 9869848d12601cdddf097a36aebe0b10dc5d177b MIPS: JZ4740: Add IRQ
> handler code
>
> :::::: TO: Lars-Peter Clausen <lars@metafoo.de>
> :::::: CC: Ralf Baechle <ralf@linux-mips.org>
>
> ---
> 0-DAY kernel test infrastructure Open Source
> Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel
> Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-23 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-21 13:49 [PATCH] irq: ingenic: Drop dependency on MACH_INGENIC Paul Cercueil
2018-08-23 2:30 ` kbuild test robot
2018-08-23 12:50 ` Paul Cercueil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.