* [RESEND PATCH] mm: percpu: remove unnecessary unlikely()
@ 2018-09-07 18:10 Igor Stoppa
2018-09-07 18:39 ` Dennis Zhou
0 siblings, 1 reply; 3+ messages in thread
From: Igor Stoppa @ 2018-09-07 18:10 UTC (permalink / raw
To: Tejun Heo, Christoph Lameter, Dennis Zhou
Cc: igor.stoppa, Igor Stoppa, zijun_hu, linux-mm, linux-kernel
WARN_ON() already contains an unlikely(), so it's not necessary to
wrap it into another.
Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com>
Acked-by: Dennis Zhou <dennisszhou@gmail.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: zijun_hu <zijun_hu@htc.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
---
mm/percpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/percpu.c b/mm/percpu.c
index a749d4d96e3e..f5c2796fe63e 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -2588,7 +2588,7 @@ int __init pcpu_page_first_chunk(size_t reserved_size,
BUG_ON(ai->nr_groups != 1);
upa = ai->alloc_size/ai->unit_size;
nr_g0_units = roundup(num_possible_cpus(), upa);
- if (unlikely(WARN_ON(ai->groups[0].nr_units != nr_g0_units))) {
+ if (WARN_ON(ai->groups[0].nr_units != nr_g0_units)) {
pcpu_free_alloc_info(ai);
return -EINVAL;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] mm: percpu: remove unnecessary unlikely()
2018-09-07 18:10 [RESEND PATCH] mm: percpu: remove unnecessary unlikely() Igor Stoppa
@ 2018-09-07 18:39 ` Dennis Zhou
2018-09-07 19:24 ` Igor Stoppa
0 siblings, 1 reply; 3+ messages in thread
From: Dennis Zhou @ 2018-09-07 18:39 UTC (permalink / raw
To: Igor Stoppa
Cc: Tejun Heo, Christoph Lameter, Igor Stoppa, zijun_hu, linux-mm,
linux-kernel
Hi Igor,
On Fri, Sep 07, 2018 at 09:10:35PM +0300, Igor Stoppa wrote:
> WARN_ON() already contains an unlikely(), so it's not necessary to
> wrap it into another.
>
> Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com>
> Acked-by: Dennis Zhou <dennisszhou@gmail.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: zijun_hu <zijun_hu@htc.com>
> Cc: Christoph Lameter <cl@linux.com>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> ---
> mm/percpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/percpu.c b/mm/percpu.c
> index a749d4d96e3e..f5c2796fe63e 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -2588,7 +2588,7 @@ int __init pcpu_page_first_chunk(size_t reserved_size,
> BUG_ON(ai->nr_groups != 1);
> upa = ai->alloc_size/ai->unit_size;
> nr_g0_units = roundup(num_possible_cpus(), upa);
> - if (unlikely(WARN_ON(ai->groups[0].nr_units != nr_g0_units))) {
> + if (WARN_ON(ai->groups[0].nr_units != nr_g0_units)) {
> pcpu_free_alloc_info(ai);
> return -EINVAL;
> }
> --
> 2.17.1
>
Sorry for the delay. I'll be taking over the percpu tree and am in the
process of getting a tree. I'm still keeping track of this and will take
it for the next release.
Thanks,
Dennis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] mm: percpu: remove unnecessary unlikely()
2018-09-07 18:39 ` Dennis Zhou
@ 2018-09-07 19:24 ` Igor Stoppa
0 siblings, 0 replies; 3+ messages in thread
From: Igor Stoppa @ 2018-09-07 19:24 UTC (permalink / raw
To: Dennis Zhou
Cc: Tejun Heo, Christoph Lameter, Igor Stoppa, zijun_hu, linux-mm,
linux-kernel
On 07/09/18 21:39, Dennis Zhou wrote:
> Sorry for the delay. I'll be taking over the percpu tree and am in the
> process of getting a tree. I'm still keeping track of this and will take
> it for the next release.
ok, np!
--
thank you, igor
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-07 19:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-07 18:10 [RESEND PATCH] mm: percpu: remove unnecessary unlikely() Igor Stoppa
2018-09-07 18:39 ` Dennis Zhou
2018-09-07 19:24 ` Igor Stoppa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.