From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lee.jones@linaro.org, linux-omap@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v7 1/6] dt-bindings: ti-lmu: Remove LM3697
Date: Fri, 14 Sep 2018 10:23:58 +0200 [thread overview]
Message-ID: <20180914082358.GB21830@amd> (raw)
In-Reply-To: <7950fa32-c8f9-52bb-06b0-0c1cc93b6bc9@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
Hi!
> All be it the analog side of these devices may be the same but the digital side for each chip is different.
> The register maps are not the same, the number of supported LED strings are not
> the same, there are features not supported by this driver and will
> be a pain to add.
Digital side looks similar enough that Milo was able to share code
between them.
Yes, obviously register map will be different.
> Adding features will be a complete night mare especially for the LM3632 which also support Torch and Flash.
>
>
> Here are where a single driver will start getting messy and support difficult
> LM3533 has ALS and an ADC for an ALS analog sensor
> LM3631 has no ALS functionality
> LM3632 has strobe/torch functionality and no ramp support
> LM3633 has lvled support coupled with the hvled support
> LM3695 does not even appear to be available publicly
> LM3697 is the only device that that this driver could be used for as is.
We already been through this once. More than one of these has ramp
support, and more than one has overvoltage protection. (Plus, all of
them are LED drivers).
Surely non-ugly design can be done where the code is shared?
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-09-14 8:24 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 17:08 [PATCH v7 0/6] LM3697 dedicated LED driver Dan Murphy
2018-09-11 17:08 ` Dan Murphy
2018-09-11 17:08 ` [PATCH v7 1/6] dt-bindings: ti-lmu: Remove LM3697 Dan Murphy
2018-09-11 17:08 ` Dan Murphy
2018-09-11 18:14 ` Lee Jones
2018-09-11 20:05 ` Pavel Machek
2018-09-11 21:48 ` Dan Murphy
2018-09-11 21:48 ` Dan Murphy
2018-09-12 21:49 ` Pavel Machek
2018-09-13 15:15 ` Dan Murphy
2018-09-13 15:15 ` Dan Murphy
2018-09-14 8:18 ` Pavel Machek
2018-09-14 20:15 ` Jacek Anaszewski
2018-09-14 20:15 ` Jacek Anaszewski
2018-09-14 21:42 ` Pavel Machek
2018-09-15 20:00 ` Jacek Anaszewski
2018-09-17 15:24 ` Dan Murphy
2018-09-17 15:24 ` Dan Murphy
2018-09-17 19:22 ` Jacek Anaszewski
2018-09-17 21:23 ` Dan Murphy
2018-09-17 21:23 ` Dan Murphy
2018-09-20 22:04 ` Pavel Machek
2018-09-21 12:44 ` Dan Murphy
2018-09-21 12:44 ` Dan Murphy
2018-09-14 8:23 ` Pavel Machek [this message]
2018-09-12 18:35 ` Jacek Anaszewski
2018-09-11 17:08 ` [PATCH v7 2/6] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2018-09-11 17:08 ` Dan Murphy
2018-09-11 18:13 ` Lee Jones
2018-09-11 17:08 ` [PATCH v7 3/6] dt-bindings: leds: Add bindings for lm3697 driver Dan Murphy
2018-09-11 17:08 ` Dan Murphy
2018-09-24 16:18 ` Rob Herring
2018-09-24 18:02 ` Pavel Machek
2018-09-25 19:39 ` Rob Herring
2018-09-25 21:19 ` Dan Murphy
2018-09-25 21:19 ` Dan Murphy
2018-09-11 17:08 ` [PATCH v7 4/6] leds: lm3697: Introduce the " Dan Murphy
2018-09-11 17:08 ` Dan Murphy
2018-09-11 17:08 ` [PATCH v7 5/6] dt-bindings: leds: Add runtime ramp node for LM3697 Dan Murphy
2018-09-11 17:08 ` Dan Murphy
2018-09-11 17:08 ` [PATCH v7 6/6] leds: lm3697: Add ramp rate feature Dan Murphy
2018-09-11 17:08 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914082358.GB21830@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.