* [-next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'
@ 2018-09-29 9:54 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2018-09-29 9:54 UTC (permalink / raw
To: Johan Hovold, Greg Kroah-Hartman; +Cc: YueHaibing, linux-usb, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/usb/serial/cypress_m8.c: In function 'cypress_send':
drivers/usb/serial/cypress_m8.c:689:33: warning:
variable 'actual_size' set but not used [-Wunused-but-set-variable]
drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios':
drivers/usb/serial/cypress_m8.c:866:18: warning:
variable 'iflag' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/usb/serial/cypress_m8.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index 31c6091..98dff12 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -686,7 +686,7 @@ static int cypress_write(struct tty_struct *tty, struct usb_serial_port *port,
static void cypress_send(struct usb_serial_port *port)
{
- int count = 0, result, offset, actual_size;
+ int count = 0, result, offset;
struct cypress_private *priv = usb_get_serial_port_data(port);
struct device *dev = &port->dev;
unsigned long flags;
@@ -758,12 +758,6 @@ static void cypress_send(struct usb_serial_port *port)
priv->write_urb_in_use = 1;
spin_unlock_irqrestore(&priv->lock, flags);
- if (priv->cmd_ctrl)
- actual_size = 1;
- else
- actual_size = count +
- (priv->pkt_fmt == packet_format_1 ? 2 : 1);
-
usb_serial_debug_data(dev, __func__, port->interrupt_out_size,
port->interrupt_out_urb->transfer_buffer);
@@ -863,7 +857,7 @@ static void cypress_set_termios(struct tty_struct *tty,
struct cypress_private *priv = usb_get_serial_port_data(port);
struct device *dev = &port->dev;
int data_bits, stop_bits, parity_type, parity_enable;
- unsigned cflag, iflag;
+ unsigned int cflag;
unsigned long flags;
__u8 oldlines;
int linechange = 0;
@@ -899,7 +893,6 @@ static void cypress_set_termios(struct tty_struct *tty,
tty->termios.c_cflag &= ~(CMSPAR|CRTSCTS);
cflag = tty->termios.c_cflag;
- iflag = tty->termios.c_iflag;
/* check if there are new settings */
if (old_termios) {
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH -next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'
@ 2018-09-29 9:54 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2018-09-29 9:54 UTC (permalink / raw
To: Johan Hovold, Greg Kroah-Hartman; +Cc: YueHaibing, linux-usb, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/usb/serial/cypress_m8.c: In function 'cypress_send':
drivers/usb/serial/cypress_m8.c:689:33: warning:
variable 'actual_size' set but not used [-Wunused-but-set-variable]
drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios':
drivers/usb/serial/cypress_m8.c:866:18: warning:
variable 'iflag' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/usb/serial/cypress_m8.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index 31c6091..98dff12 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -686,7 +686,7 @@ static int cypress_write(struct tty_struct *tty, struct usb_serial_port *port,
static void cypress_send(struct usb_serial_port *port)
{
- int count = 0, result, offset, actual_size;
+ int count = 0, result, offset;
struct cypress_private *priv = usb_get_serial_port_data(port);
struct device *dev = &port->dev;
unsigned long flags;
@@ -758,12 +758,6 @@ static void cypress_send(struct usb_serial_port *port)
priv->write_urb_in_use = 1;
spin_unlock_irqrestore(&priv->lock, flags);
- if (priv->cmd_ctrl)
- actual_size = 1;
- else
- actual_size = count +
- (priv->pkt_fmt = packet_format_1 ? 2 : 1);
-
usb_serial_debug_data(dev, __func__, port->interrupt_out_size,
port->interrupt_out_urb->transfer_buffer);
@@ -863,7 +857,7 @@ static void cypress_set_termios(struct tty_struct *tty,
struct cypress_private *priv = usb_get_serial_port_data(port);
struct device *dev = &port->dev;
int data_bits, stop_bits, parity_type, parity_enable;
- unsigned cflag, iflag;
+ unsigned int cflag;
unsigned long flags;
__u8 oldlines;
int linechange = 0;
@@ -899,7 +893,6 @@ static void cypress_set_termios(struct tty_struct *tty,
tty->termios.c_cflag &= ~(CMSPAR|CRTSCTS);
cflag = tty->termios.c_cflag;
- iflag = tty->termios.c_iflag;
/* check if there are new settings */
if (old_termios) {
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [-next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'
2018-09-29 9:54 ` [PATCH -next] " YueHaibing
@ 2018-09-30 16:02 ` Johan Hovold
-1 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2018-09-30 16:02 UTC (permalink / raw
To: YueHaibing; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb, kernel-janitors
On Sat, Sep 29, 2018 at 09:54:03AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/cypress_m8.c: In function 'cypress_send':
> drivers/usb/serial/cypress_m8.c:689:33: warning:
> variable 'actual_size' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios':
> drivers/usb/serial/cypress_m8.c:866:18: warning:
> variable 'iflag' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/usb/serial/cypress_m8.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
> index 31c6091..98dff12 100644
> --- a/drivers/usb/serial/cypress_m8.c
> +++ b/drivers/usb/serial/cypress_m8.c
> @@ -686,7 +686,7 @@ static int cypress_write(struct tty_struct *tty, struct usb_serial_port *port,
>
> static void cypress_send(struct usb_serial_port *port)
> {
> - int count = 0, result, offset, actual_size;
> + int count = 0, result, offset;
> struct cypress_private *priv = usb_get_serial_port_data(port);
> struct device *dev = &port->dev;
> unsigned long flags;
> @@ -758,12 +758,6 @@ static void cypress_send(struct usb_serial_port *port)
> priv->write_urb_in_use = 1;
> spin_unlock_irqrestore(&priv->lock, flags);
>
> - if (priv->cmd_ctrl)
> - actual_size = 1;
> - else
> - actual_size = count +
> - (priv->pkt_fmt == packet_format_1 ? 2 : 1);
> -
This looks like we have a bug in the driver, and sure enough we do.
Commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
appropriate") incorrectly started setting the transfer length to the
size of the buffer.
I've prepared a fix to this.
> usb_serial_debug_data(dev, __func__, port->interrupt_out_size,
> port->interrupt_out_urb->transfer_buffer);
>
> @@ -863,7 +857,7 @@ static void cypress_set_termios(struct tty_struct *tty,
> struct cypress_private *priv = usb_get_serial_port_data(port);
> struct device *dev = &port->dev;
> int data_bits, stop_bits, parity_type, parity_enable;
> - unsigned cflag, iflag;
> + unsigned int cflag;
> unsigned long flags;
> __u8 oldlines;
> int linechange = 0;
> @@ -899,7 +893,6 @@ static void cypress_set_termios(struct tty_struct *tty,
> tty->termios.c_cflag &= ~(CMSPAR|CRTSCTS);
>
> cflag = tty->termios.c_cflag;
> - iflag = tty->termios.c_iflag;
>
> /* check if there are new settings */
> if (old_termios) {
Would you mind resending just this chunk as a v2?
Thanks,
Johan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'
@ 2018-09-30 16:02 ` Johan Hovold
0 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2018-09-30 16:02 UTC (permalink / raw
To: YueHaibing; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb, kernel-janitors
On Sat, Sep 29, 2018 at 09:54:03AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/cypress_m8.c: In function 'cypress_send':
> drivers/usb/serial/cypress_m8.c:689:33: warning:
> variable 'actual_size' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios':
> drivers/usb/serial/cypress_m8.c:866:18: warning:
> variable 'iflag' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/usb/serial/cypress_m8.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
> index 31c6091..98dff12 100644
> --- a/drivers/usb/serial/cypress_m8.c
> +++ b/drivers/usb/serial/cypress_m8.c
> @@ -686,7 +686,7 @@ static int cypress_write(struct tty_struct *tty, struct usb_serial_port *port,
>
> static void cypress_send(struct usb_serial_port *port)
> {
> - int count = 0, result, offset, actual_size;
> + int count = 0, result, offset;
> struct cypress_private *priv = usb_get_serial_port_data(port);
> struct device *dev = &port->dev;
> unsigned long flags;
> @@ -758,12 +758,6 @@ static void cypress_send(struct usb_serial_port *port)
> priv->write_urb_in_use = 1;
> spin_unlock_irqrestore(&priv->lock, flags);
>
> - if (priv->cmd_ctrl)
> - actual_size = 1;
> - else
> - actual_size = count +
> - (priv->pkt_fmt = packet_format_1 ? 2 : 1);
> -
This looks like we have a bug in the driver, and sure enough we do.
Commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
appropriate") incorrectly started setting the transfer length to the
size of the buffer.
I've prepared a fix to this.
> usb_serial_debug_data(dev, __func__, port->interrupt_out_size,
> port->interrupt_out_urb->transfer_buffer);
>
> @@ -863,7 +857,7 @@ static void cypress_set_termios(struct tty_struct *tty,
> struct cypress_private *priv = usb_get_serial_port_data(port);
> struct device *dev = &port->dev;
> int data_bits, stop_bits, parity_type, parity_enable;
> - unsigned cflag, iflag;
> + unsigned int cflag;
> unsigned long flags;
> __u8 oldlines;
> int linechange = 0;
> @@ -899,7 +893,6 @@ static void cypress_set_termios(struct tty_struct *tty,
> tty->termios.c_cflag &= ~(CMSPAR|CRTSCTS);
>
> cflag = tty->termios.c_cflag;
> - iflag = tty->termios.c_iflag;
>
> /* check if there are new settings */
> if (old_termios) {
Would you mind resending just this chunk as a v2?
Thanks,
Johan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [-next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'
2018-09-29 9:54 ` [PATCH -next] " YueHaibing
@ 2018-10-01 7:19 ` Dan Carpenter
-1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2018-10-01 7:19 UTC (permalink / raw
To: Johan Hovold; +Cc: YueHaibing, Greg Kroah-Hartman, linux-usb, kernel-janitors
On Sun, Sep 30, 2018 at 06:02:24PM +0200, Johan Hovold wrote:
> On Sat, Sep 29, 2018 at 09:54:03AM +0000, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/usb/serial/cypress_m8.c: In function 'cypress_send':
> > drivers/usb/serial/cypress_m8.c:689:33: warning:
> > variable 'actual_size' set but not used [-Wunused-but-set-variable]
> >
> > drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios':
> > drivers/usb/serial/cypress_m8.c:866:18: warning:
> > variable 'iflag' set but not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/usb/serial/cypress_m8.c | 11 ++---------
> > 1 file changed, 2 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
> > index 31c6091..98dff12 100644
> > --- a/drivers/usb/serial/cypress_m8.c
> > +++ b/drivers/usb/serial/cypress_m8.c
> > @@ -686,7 +686,7 @@ static int cypress_write(struct tty_struct *tty, struct usb_serial_port *port,
> >
> > static void cypress_send(struct usb_serial_port *port)
> > {
> > - int count = 0, result, offset, actual_size;
> > + int count = 0, result, offset;
> > struct cypress_private *priv = usb_get_serial_port_data(port);
> > struct device *dev = &port->dev;
> > unsigned long flags;
> > @@ -758,12 +758,6 @@ static void cypress_send(struct usb_serial_port *port)
> > priv->write_urb_in_use = 1;
> > spin_unlock_irqrestore(&priv->lock, flags);
> >
> > - if (priv->cmd_ctrl)
> > - actual_size = 1;
> > - else
> > - actual_size = count +
> > - (priv->pkt_fmt == packet_format_1 ? 2 : 1);
> > -
>
> This looks like we have a bug in the driver, and sure enough we do.
> Commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
> appropriate") incorrectly started setting the transfer length to the
> size of the buffer.
>
This is like the third time recently where we've had found a real bug.
YueHaibing, could you mention in the commit message where the variable
became unused? It would help reviewing. It's not a Fixes tag but it
would look like this:
"After commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
appropriate") then we don't use actual_size any more so that can
be removed."
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'
@ 2018-10-01 7:19 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2018-10-01 7:19 UTC (permalink / raw
To: Johan Hovold; +Cc: YueHaibing, Greg Kroah-Hartman, linux-usb, kernel-janitors
On Sun, Sep 30, 2018 at 06:02:24PM +0200, Johan Hovold wrote:
> On Sat, Sep 29, 2018 at 09:54:03AM +0000, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/usb/serial/cypress_m8.c: In function 'cypress_send':
> > drivers/usb/serial/cypress_m8.c:689:33: warning:
> > variable 'actual_size' set but not used [-Wunused-but-set-variable]
> >
> > drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios':
> > drivers/usb/serial/cypress_m8.c:866:18: warning:
> > variable 'iflag' set but not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/usb/serial/cypress_m8.c | 11 ++---------
> > 1 file changed, 2 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
> > index 31c6091..98dff12 100644
> > --- a/drivers/usb/serial/cypress_m8.c
> > +++ b/drivers/usb/serial/cypress_m8.c
> > @@ -686,7 +686,7 @@ static int cypress_write(struct tty_struct *tty, struct usb_serial_port *port,
> >
> > static void cypress_send(struct usb_serial_port *port)
> > {
> > - int count = 0, result, offset, actual_size;
> > + int count = 0, result, offset;
> > struct cypress_private *priv = usb_get_serial_port_data(port);
> > struct device *dev = &port->dev;
> > unsigned long flags;
> > @@ -758,12 +758,6 @@ static void cypress_send(struct usb_serial_port *port)
> > priv->write_urb_in_use = 1;
> > spin_unlock_irqrestore(&priv->lock, flags);
> >
> > - if (priv->cmd_ctrl)
> > - actual_size = 1;
> > - else
> > - actual_size = count +
> > - (priv->pkt_fmt = packet_format_1 ? 2 : 1);
> > -
>
> This looks like we have a bug in the driver, and sure enough we do.
> Commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
> appropriate") incorrectly started setting the transfer length to the
> size of the buffer.
>
This is like the third time recently where we've had found a real bug.
YueHaibing, could you mention in the commit message where the variable
became unused? It would help reviewing. It's not a Fixes tag but it
would look like this:
"After commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
appropriate") then we don't use actual_size any more so that can
be removed."
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* [-next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'
2018-09-29 9:54 ` [PATCH -next] " YueHaibing
@ 2018-10-04 1:35 ` YueHaibing
-1 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2018-10-04 1:35 UTC (permalink / raw
To: Dan Carpenter, Johan Hovold
Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors
On 2018/10/1 15:19, Dan Carpenter wrote:
> On Sun, Sep 30, 2018 at 06:02:24PM +0200, Johan Hovold wrote:
>> On Sat, Sep 29, 2018 at 09:54:03AM +0000, YueHaibing wrote:
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> drivers/usb/serial/cypress_m8.c: In function 'cypress_send':
>>> drivers/usb/serial/cypress_m8.c:689:33: warning:
>>> variable 'actual_size' set but not used [-Wunused-but-set-variable]
>>>
>>> drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios':
>>> drivers/usb/serial/cypress_m8.c:866:18: warning:
>>> variable 'iflag' set but not used [-Wunused-but-set-variable]
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>> drivers/usb/serial/cypress_m8.c | 11 ++---------
>>> 1 file changed, 2 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
>>> index 31c6091..98dff12 100644
>>> --- a/drivers/usb/serial/cypress_m8.c
>>> +++ b/drivers/usb/serial/cypress_m8.c
>>> @@ -686,7 +686,7 @@ static int cypress_write(struct tty_struct *tty, struct usb_serial_port *port,
>>>
>>> static void cypress_send(struct usb_serial_port *port)
>>> {
>>> - int count = 0, result, offset, actual_size;
>>> + int count = 0, result, offset;
>>> struct cypress_private *priv = usb_get_serial_port_data(port);
>>> struct device *dev = &port->dev;
>>> unsigned long flags;
>>> @@ -758,12 +758,6 @@ static void cypress_send(struct usb_serial_port *port)
>>> priv->write_urb_in_use = 1;
>>> spin_unlock_irqrestore(&priv->lock, flags);
>>>
>>> - if (priv->cmd_ctrl)
>>> - actual_size = 1;
>>> - else
>>> - actual_size = count +
>>> - (priv->pkt_fmt == packet_format_1 ? 2 : 1);
>>> -
>>
>> This looks like we have a bug in the driver, and sure enough we do.
>> Commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
>> appropriate") incorrectly started setting the transfer length to the
>> size of the buffer.
>>
>
> This is like the third time recently where we've had found a real bug.
>
> YueHaibing, could you mention in the commit message where the variable
> became unused? It would help reviewing. It's not a Fixes tag but it
> would look like this:
Ok, will do it.
>
> "After commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
> appropriate") then we don't use actual_size any more so that can
> be removed."
>
>
> regards,
> dan carpenter
>
>
> .
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'
@ 2018-10-04 1:35 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2018-10-04 1:35 UTC (permalink / raw
To: Dan Carpenter, Johan Hovold
Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors
On 2018/10/1 15:19, Dan Carpenter wrote:
> On Sun, Sep 30, 2018 at 06:02:24PM +0200, Johan Hovold wrote:
>> On Sat, Sep 29, 2018 at 09:54:03AM +0000, YueHaibing wrote:
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> drivers/usb/serial/cypress_m8.c: In function 'cypress_send':
>>> drivers/usb/serial/cypress_m8.c:689:33: warning:
>>> variable 'actual_size' set but not used [-Wunused-but-set-variable]
>>>
>>> drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios':
>>> drivers/usb/serial/cypress_m8.c:866:18: warning:
>>> variable 'iflag' set but not used [-Wunused-but-set-variable]
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>> drivers/usb/serial/cypress_m8.c | 11 ++---------
>>> 1 file changed, 2 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
>>> index 31c6091..98dff12 100644
>>> --- a/drivers/usb/serial/cypress_m8.c
>>> +++ b/drivers/usb/serial/cypress_m8.c
>>> @@ -686,7 +686,7 @@ static int cypress_write(struct tty_struct *tty, struct usb_serial_port *port,
>>>
>>> static void cypress_send(struct usb_serial_port *port)
>>> {
>>> - int count = 0, result, offset, actual_size;
>>> + int count = 0, result, offset;
>>> struct cypress_private *priv = usb_get_serial_port_data(port);
>>> struct device *dev = &port->dev;
>>> unsigned long flags;
>>> @@ -758,12 +758,6 @@ static void cypress_send(struct usb_serial_port *port)
>>> priv->write_urb_in_use = 1;
>>> spin_unlock_irqrestore(&priv->lock, flags);
>>>
>>> - if (priv->cmd_ctrl)
>>> - actual_size = 1;
>>> - else
>>> - actual_size = count +
>>> - (priv->pkt_fmt = packet_format_1 ? 2 : 1);
>>> -
>>
>> This looks like we have a bug in the driver, and sure enough we do.
>> Commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
>> appropriate") incorrectly started setting the transfer length to the
>> size of the buffer.
>>
>
> This is like the third time recently where we've had found a real bug.
>
> YueHaibing, could you mention in the commit message where the variable
> became unused? It would help reviewing. It's not a Fixes tag but it
> would look like this:
Ok, will do it.
>
> "After commit 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where
> appropriate") then we don't use actual_size any more so that can
> be removed."
>
>
> regards,
> dan carpenter
>
>
> .
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-10-04 1:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-30 16:02 [-next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag' Johan Hovold
2018-09-30 16:02 ` [PATCH -next] " Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-10-04 1:35 [-next] " YueHaibing
2018-10-04 1:35 ` [PATCH -next] " YueHaibing
2018-10-01 7:19 [-next] " Dan Carpenter
2018-10-01 7:19 ` [PATCH -next] " Dan Carpenter
2018-09-29 9:54 [-next] " YueHaibing
2018-09-29 9:54 ` [PATCH -next] " YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.