From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/2] mmc: mtk-sd: fix possible incomplete read ops
Date: Sat, 26 Jan 2019 22:52:19 -0500 [thread overview]
Message-ID: <20190127035219.GS6906@bill-the-cat> (raw)
In-Reply-To: <20190117170601.20676-1-fparent@baylibre.com>
On Thu, Jan 17, 2019 at 06:06:00PM +0100, Fabien Parent wrote:
> The code is checking for incomplete read when it see the INT_XFER_COMPL
> flag, but it forget to first check whether there is anything left in the
> FIFO to copy to the RX buffer. This means that sometimes we will get
> errors because of erroneous incomplete read operation.
>
> This commit fixes the driver re-ordering the code so that we first
> check for data inside the RX fifo and only after check the status
> of the INT_XFER_COMPL flag.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190126/d091f59b/attachment.sig>
prev parent reply other threads:[~2019-01-27 3:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 17:06 [U-Boot] [PATCH 1/2] mmc: mtk-sd: fix possible incomplete read ops Fabien Parent
2019-01-17 17:06 ` [U-Boot] [PATCH 2/2] mmc: mtk-sd: fix SPL compilation when GPIO=y and SPL_GPIO=n Fabien Parent
2019-01-27 3:52 ` [U-Boot] [U-Boot, " Tom Rini
2019-01-27 3:52 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127035219.GS6906@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.