* [Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf
@ 2019-02-12 14:53 Philippe Mathieu-Daudé
2019-02-12 16:02 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-12 14:53 UTC (permalink / raw
To: qemu-trivial, qemu-devel
Cc: Thomas Huth, BALATON Zoltan, Michael S. Tsirkin, Paolo Bonzini,
Philippe Mathieu-Daudé
Avoid to clutter stdout until explicitly requested (with -d unimp):
$ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin
dma: command df not supported
dma: command df not supported
dma: command df not supported
dma: command df not supported
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/dma/i8257.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
index 52675e97c9..3e1f13a4aa 100644
--- a/hw/dma/i8257.c
+++ b/hw/dma/i8257.c
@@ -26,6 +26,7 @@
#include "hw/isa/isa.h"
#include "hw/dma/i8257.h"
#include "qemu/main-loop.h"
+#include "qemu/log.h"
#include "trace.h"
#define I8257(obj) \
@@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data,
switch (iport) {
case 0x00: /* command */
if ((data != 0) && (data & CMD_NOT_SUPPORTED)) {
- dolog("command %"PRIx64" not supported\n", data);
+ qemu_log_mask(LOG_UNIMP, "%s: cmd 0x%02"PRIx64" not supported\n",
+ __func__, data);
return;
}
d->command = data;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf
2019-02-12 14:53 [Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf Philippe Mathieu-Daudé
@ 2019-02-12 16:02 ` Thomas Huth
2019-02-13 9:47 ` Stefano Garzarella
2019-02-14 10:02 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2019-02-12 16:02 UTC (permalink / raw
To: Philippe Mathieu-Daudé, qemu-trivial, qemu-devel
Cc: BALATON Zoltan, Michael S. Tsirkin, Paolo Bonzini
On 2019-02-12 15:53, Philippe Mathieu-Daudé wrote:
> Avoid to clutter stdout until explicitly requested (with -d unimp):
>
> $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin
> dma: command df not supported
> dma: command df not supported
> dma: command df not supported
> dma: command df not supported
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/dma/i8257.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
> index 52675e97c9..3e1f13a4aa 100644
> --- a/hw/dma/i8257.c
> +++ b/hw/dma/i8257.c
> @@ -26,6 +26,7 @@
> #include "hw/isa/isa.h"
> #include "hw/dma/i8257.h"
> #include "qemu/main-loop.h"
> +#include "qemu/log.h"
> #include "trace.h"
>
> #define I8257(obj) \
> @@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data,
> switch (iport) {
> case 0x00: /* command */
> if ((data != 0) && (data & CMD_NOT_SUPPORTED)) {
> - dolog("command %"PRIx64" not supported\n", data);
> + qemu_log_mask(LOG_UNIMP, "%s: cmd 0x%02"PRIx64" not supported\n",
> + __func__, data);
> return;
> }
> d->command = data;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf
2019-02-12 14:53 [Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf Philippe Mathieu-Daudé
2019-02-12 16:02 ` Thomas Huth
@ 2019-02-13 9:47 ` Stefano Garzarella
2019-02-14 10:02 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2019-02-13 9:47 UTC (permalink / raw
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, qemu-devel, Paolo Bonzini, Thomas Huth,
Michael S. Tsirkin
On Tue, Feb 12, 2019 at 03:53:22PM +0100, Philippe Mathieu-Daudé wrote:
> Avoid to clutter stdout until explicitly requested (with -d unimp):
>
> $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin
> dma: command df not supported
> dma: command df not supported
> dma: command df not supported
> dma: command df not supported
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/dma/i8257.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf
2019-02-12 14:53 [Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf Philippe Mathieu-Daudé
2019-02-12 16:02 ` Thomas Huth
2019-02-13 9:47 ` Stefano Garzarella
@ 2019-02-14 10:02 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-02-14 10:02 UTC (permalink / raw
To: Philippe Mathieu-Daudé, qemu-trivial, qemu-devel
Cc: Paolo Bonzini, Thomas Huth, Michael S. Tsirkin, BALATON Zoltan
On 12/02/2019 15:53, Philippe Mathieu-Daudé wrote:
> Avoid to clutter stdout until explicitly requested (with -d unimp):
>
> $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin
> dma: command df not supported
> dma: command df not supported
> dma: command df not supported
> dma: command df not supported
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/dma/i8257.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
> index 52675e97c9..3e1f13a4aa 100644
> --- a/hw/dma/i8257.c
> +++ b/hw/dma/i8257.c
> @@ -26,6 +26,7 @@
> #include "hw/isa/isa.h"
> #include "hw/dma/i8257.h"
> #include "qemu/main-loop.h"
> +#include "qemu/log.h"
> #include "trace.h"
>
> #define I8257(obj) \
> @@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data,
> switch (iport) {
> case 0x00: /* command */
> if ((data != 0) && (data & CMD_NOT_SUPPORTED)) {
> - dolog("command %"PRIx64" not supported\n", data);
> + qemu_log_mask(LOG_UNIMP, "%s: cmd 0x%02"PRIx64" not supported\n",
> + __func__, data);
> return;
> }
> d->command = data;
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-14 10:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-12 14:53 [Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf Philippe Mathieu-Daudé
2019-02-12 16:02 ` Thomas Huth
2019-02-13 9:47 ` Stefano Garzarella
2019-02-14 10:02 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.