From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com,
alexpe@mellanox.com, mlxsw@mellanox.com,
Ido Schimmel <idosch@mellanox.com>
Subject: [PATCH net 4/7] mlxsw: spectrum_flower: Fix TOS matching
Date: Tue, 11 Jun 2019 10:19:43 +0300 [thread overview]
Message-ID: <20190611071946.11089-5-idosch@idosch.org> (raw)
In-Reply-To: <20190611071946.11089-1-idosch@idosch.org>
From: Jiri Pirko <jiri@mellanox.com>
The TOS value was not extracted correctly. Fix it.
Fixes: 87996f91f739 ("mlxsw: spectrum_flower: Add support for ip tos")
Reported-by: Alexander Petrovskiy <alexpe@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
index 15f804453cd6..96b23c856f4d 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
@@ -247,8 +247,8 @@ static int mlxsw_sp_flower_parse_ip(struct mlxsw_sp *mlxsw_sp,
match.mask->tos & 0x3);
mlxsw_sp_acl_rulei_keymask_u32(rulei, MLXSW_AFK_ELEMENT_IP_DSCP,
- match.key->tos >> 6,
- match.mask->tos >> 6);
+ match.key->tos >> 2,
+ match.mask->tos >> 2);
return 0;
}
--
2.20.1
next prev parent reply other threads:[~2019-06-11 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 7:19 [PATCH net 0/7] mlxsw: Various fixes Ido Schimmel
2019-06-11 7:19 ` [PATCH net 1/7] mlxsw: spectrum: Use different seeds for ECMP and LAG hash Ido Schimmel
2019-06-11 7:19 ` [PATCH net 2/7] mlxsw: spectrum_router: Refresh nexthop neighbour when it becomes dead Ido Schimmel
2019-06-11 7:19 ` [PATCH net 3/7] selftests: mlxsw: Test nexthop offload indication Ido Schimmel
2019-06-11 7:19 ` Ido Schimmel [this message]
2019-06-11 7:19 ` [PATCH net 5/7] selftests: tc_flower: Add TOS matching test Ido Schimmel
2019-06-11 7:19 ` [PATCH net 6/7] mlxsw: spectrum_buffers: Reduce pool size on Spectrum-2 Ido Schimmel
2019-06-11 7:19 ` [PATCH net 7/7] mlxsw: spectrum: Disallow prio-tagged packets when PVID is removed Ido Schimmel
2019-06-12 18:08 ` [PATCH net 0/7] mlxsw: Various fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611071946.11089-5-idosch@idosch.org \
--to=idosch@idosch.org \
--cc=alexpe@mellanox.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.