* [PATCH] drm/amd: fix hotplug race at startup
@ 2019-06-14 11:29 Young Xiao
2019-06-14 15:00 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Young Xiao @ 2019-06-14 11:29 UTC (permalink / raw
To: alexander.deucher, christian.koenig, David1.Zhou, airlied, daniel,
amd-gfx, dri-devel, linux-kernel
Cc: Young Xiao
We should check mode_config_initialized flag in amdgpu_hotplug_work_func.
See commit 7f98ca454ad3 ("drm/radeon: fix hotplug race at startup") for details.
Signed-off-by: Young Xiao <92siuyang@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
index af4c3b1..13186d6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
@@ -85,6 +85,9 @@ static void amdgpu_hotplug_work_func(struct work_struct *work)
struct drm_mode_config *mode_config = &dev->mode_config;
struct drm_connector *connector;
+ if (!adev->mode_info.mode_config_initialized)
+ return;
+
mutex_lock(&mode_config->mutex);
list_for_each_entry(connector, &mode_config->connector_list, head)
amdgpu_connector_hotplug(connector);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd: fix hotplug race at startup
@ 2019-06-14 15:00 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2019-06-14 15:00 UTC (permalink / raw
To: Young Xiao
Cc: alexander.deucher, christian.koenig, David1.Zhou, airlied, daniel,
amd-gfx, dri-devel, linux-kernel
On Fri, Jun 14, 2019 at 07:29:23PM +0800, Young Xiao wrote:
> We should check mode_config_initialized flag in amdgpu_hotplug_work_func.
>
> See commit 7f98ca454ad3 ("drm/radeon: fix hotplug race at startup") for details.
>
> Signed-off-by: Young Xiao <92siuyang@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> index af4c3b1..13186d6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> @@ -85,6 +85,9 @@ static void amdgpu_hotplug_work_func(struct work_struct *work)
> struct drm_mode_config *mode_config = &dev->mode_config;
> struct drm_connector *connector;
>
> + if (!adev->mode_info.mode_config_initialized)
> + return;
I think you want to delay your hotplug initialization until you're ready
to serve hotplug events, this here is fairly racy ...
-Daniel
> +
> mutex_lock(&mode_config->mutex);
> list_for_each_entry(connector, &mode_config->connector_list, head)
> amdgpu_connector_hotplug(connector);
> --
> 2.7.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd: fix hotplug race at startup
@ 2019-06-14 15:00 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2019-06-14 15:00 UTC (permalink / raw
To: Young Xiao
Cc: David1.Zhou-5C7GfCeVMHo, airlied-cv59FeDIM0c,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, daniel-/w4YWyX8dFk,
alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo
On Fri, Jun 14, 2019 at 07:29:23PM +0800, Young Xiao wrote:
> We should check mode_config_initialized flag in amdgpu_hotplug_work_func.
>
> See commit 7f98ca454ad3 ("drm/radeon: fix hotplug race at startup") for details.
>
> Signed-off-by: Young Xiao <92siuyang@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> index af4c3b1..13186d6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> @@ -85,6 +85,9 @@ static void amdgpu_hotplug_work_func(struct work_struct *work)
> struct drm_mode_config *mode_config = &dev->mode_config;
> struct drm_connector *connector;
>
> + if (!adev->mode_info.mode_config_initialized)
> + return;
I think you want to delay your hotplug initialization until you're ready
to serve hotplug events, this here is fairly racy ...
-Daniel
> +
> mutex_lock(&mode_config->mutex);
> list_for_each_entry(connector, &mode_config->connector_list, head)
> amdgpu_connector_hotplug(connector);
> --
> 2.7.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-14 15:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-14 11:29 [PATCH] drm/amd: fix hotplug race at startup Young Xiao
2019-06-14 15:00 ` Daniel Vetter
2019-06-14 15:00 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.