* [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source
@ 2019-09-16 8:29 ` Anson Huang
0 siblings, 0 replies; 7+ messages in thread
From: Anson Huang @ 2019-09-16 8:29 UTC (permalink / raw
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
devicetree, linux-arm-kernel, linux-kernel
Cc: Linux-imx
i.MX7S/D's GPT ipg clock should be from GPT clock root and
controlled by CCM's GPT CCGR, using correct clock source for
GPT ipg clock instead of IMX7D_CLK_DUMMY.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 710f850..e2e604d 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -448,7 +448,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x302d0000 0x10000>;
interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT1_ROOT_CLK>,
<&clks IMX7D_GPT1_ROOT_CLK>;
clock-names = "ipg", "per";
};
@@ -457,7 +457,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x302e0000 0x10000>;
interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT2_ROOT_CLK>,
<&clks IMX7D_GPT2_ROOT_CLK>;
clock-names = "ipg", "per";
status = "disabled";
@@ -467,7 +467,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x302f0000 0x10000>;
interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT3_ROOT_CLK>,
<&clks IMX7D_GPT3_ROOT_CLK>;
clock-names = "ipg", "per";
status = "disabled";
@@ -477,7 +477,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x30300000 0x10000>;
interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT4_ROOT_CLK>,
<&clks IMX7D_GPT4_ROOT_CLK>;
clock-names = "ipg", "per";
status = "disabled";
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source
@ 2019-09-16 8:29 ` Anson Huang
0 siblings, 0 replies; 7+ messages in thread
From: Anson Huang @ 2019-09-16 8:29 UTC (permalink / raw
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
devicetree, linux-arm-kernel, linux-kernel
Cc: Linux-imx
i.MX7S/D's GPT ipg clock should be from GPT clock root and
controlled by CCM's GPT CCGR, using correct clock source for
GPT ipg clock instead of IMX7D_CLK_DUMMY.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 710f850..e2e604d 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -448,7 +448,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x302d0000 0x10000>;
interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT1_ROOT_CLK>,
<&clks IMX7D_GPT1_ROOT_CLK>;
clock-names = "ipg", "per";
};
@@ -457,7 +457,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x302e0000 0x10000>;
interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT2_ROOT_CLK>,
<&clks IMX7D_GPT2_ROOT_CLK>;
clock-names = "ipg", "per";
status = "disabled";
@@ -467,7 +467,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x302f0000 0x10000>;
interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT3_ROOT_CLK>,
<&clks IMX7D_GPT3_ROOT_CLK>;
clock-names = "ipg", "per";
status = "disabled";
@@ -477,7 +477,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x30300000 0x10000>;
interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT4_ROOT_CLK>,
<&clks IMX7D_GPT4_ROOT_CLK>;
clock-names = "ipg", "per";
status = "disabled";
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source
2019-09-16 8:29 ` Anson Huang
(?)
@ 2019-10-06 8:32 ` Shawn Guo
-1 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2019-10-06 8:32 UTC (permalink / raw
To: Anson Huang
Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, devicetree,
linux-arm-kernel, linux-kernel, Linux-imx
On Mon, Sep 16, 2019 at 04:29:09PM +0800, Anson Huang wrote:
> i.MX7S/D's GPT ipg clock should be from GPT clock root and
> controlled by CCM's GPT CCGR, using correct clock source for
> GPT ipg clock instead of IMX7D_CLK_DUMMY.
So both 'ipg' and 'per' clock are coming from GPT root clock?
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
It looks like a fix, so do we need a Fixes tag here?
Shawn
> ---
> arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 710f850..e2e604d 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -448,7 +448,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302d0000 0x10000>;
> interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT1_ROOT_CLK>,
> <&clks IMX7D_GPT1_ROOT_CLK>;
> clock-names = "ipg", "per";
> };
> @@ -457,7 +457,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302e0000 0x10000>;
> interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT2_ROOT_CLK>,
> <&clks IMX7D_GPT2_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -467,7 +467,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302f0000 0x10000>;
> interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT3_ROOT_CLK>,
> <&clks IMX7D_GPT3_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -477,7 +477,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x30300000 0x10000>;
> interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT4_ROOT_CLK>,
> <&clks IMX7D_GPT4_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source
@ 2019-10-06 8:32 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2019-10-06 8:32 UTC (permalink / raw
To: Anson Huang
Cc: mark.rutland, devicetree, s.hauer, linux-kernel, robh+dt,
Linux-imx, kernel, festevam, linux-arm-kernel
On Mon, Sep 16, 2019 at 04:29:09PM +0800, Anson Huang wrote:
> i.MX7S/D's GPT ipg clock should be from GPT clock root and
> controlled by CCM's GPT CCGR, using correct clock source for
> GPT ipg clock instead of IMX7D_CLK_DUMMY.
So both 'ipg' and 'per' clock are coming from GPT root clock?
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
It looks like a fix, so do we need a Fixes tag here?
Shawn
> ---
> arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 710f850..e2e604d 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -448,7 +448,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302d0000 0x10000>;
> interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT1_ROOT_CLK>,
> <&clks IMX7D_GPT1_ROOT_CLK>;
> clock-names = "ipg", "per";
> };
> @@ -457,7 +457,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302e0000 0x10000>;
> interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT2_ROOT_CLK>,
> <&clks IMX7D_GPT2_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -467,7 +467,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302f0000 0x10000>;
> interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT3_ROOT_CLK>,
> <&clks IMX7D_GPT3_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -477,7 +477,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x30300000 0x10000>;
> interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT4_ROOT_CLK>,
> <&clks IMX7D_GPT4_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source
@ 2019-10-06 8:32 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2019-10-06 8:32 UTC (permalink / raw
To: Anson Huang
Cc: mark.rutland, devicetree, s.hauer, linux-kernel, robh+dt,
Linux-imx, kernel, festevam, linux-arm-kernel
On Mon, Sep 16, 2019 at 04:29:09PM +0800, Anson Huang wrote:
> i.MX7S/D's GPT ipg clock should be from GPT clock root and
> controlled by CCM's GPT CCGR, using correct clock source for
> GPT ipg clock instead of IMX7D_CLK_DUMMY.
So both 'ipg' and 'per' clock are coming from GPT root clock?
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
It looks like a fix, so do we need a Fixes tag here?
Shawn
> ---
> arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 710f850..e2e604d 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -448,7 +448,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302d0000 0x10000>;
> interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT1_ROOT_CLK>,
> <&clks IMX7D_GPT1_ROOT_CLK>;
> clock-names = "ipg", "per";
> };
> @@ -457,7 +457,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302e0000 0x10000>;
> interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT2_ROOT_CLK>,
> <&clks IMX7D_GPT2_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -467,7 +467,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302f0000 0x10000>;
> interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT3_ROOT_CLK>,
> <&clks IMX7D_GPT3_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -477,7 +477,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x30300000 0x10000>;
> interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT4_ROOT_CLK>,
> <&clks IMX7D_GPT4_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source
2019-10-06 8:32 ` Shawn Guo
@ 2019-10-07 0:45 ` Anson Huang
-1 siblings, 0 replies; 7+ messages in thread
From: Anson Huang @ 2019-10-07 0:45 UTC (permalink / raw
To: Shawn Guo
Cc: robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dl-linux-imx
Hi, Shawn
> On Mon, Sep 16, 2019 at 04:29:09PM +0800, Anson Huang wrote:
> > i.MX7S/D's GPT ipg clock should be from GPT clock root and controlled
> > by CCM's GPT CCGR, using correct clock source for GPT ipg clock
> > instead of IMX7D_CLK_DUMMY.
>
> So both 'ipg' and 'per' clock are coming from GPT root clock?
Yes.
>
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> It looks like a fix, so do we need a Fixes tag here?
Sure, will add a fixes tag in V2.
Thanks,
Anson.
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source
@ 2019-10-07 0:45 ` Anson Huang
0 siblings, 0 replies; 7+ messages in thread
From: Anson Huang @ 2019-10-07 0:45 UTC (permalink / raw
To: Shawn Guo
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, dl-linux-imx, kernel@pengutronix.de,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Hi, Shawn
> On Mon, Sep 16, 2019 at 04:29:09PM +0800, Anson Huang wrote:
> > i.MX7S/D's GPT ipg clock should be from GPT clock root and controlled
> > by CCM's GPT CCGR, using correct clock source for GPT ipg clock
> > instead of IMX7D_CLK_DUMMY.
>
> So both 'ipg' and 'per' clock are coming from GPT root clock?
Yes.
>
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> It looks like a fix, so do we need a Fixes tag here?
Sure, will add a fixes tag in V2.
Thanks,
Anson.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-07 0:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-16 8:29 [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source Anson Huang
2019-09-16 8:29 ` Anson Huang
2019-10-06 8:32 ` Shawn Guo
2019-10-06 8:32 ` Shawn Guo
2019-10-06 8:32 ` Shawn Guo
2019-10-07 0:45 ` Anson Huang
2019-10-07 0:45 ` Anson Huang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.