From: Daniel Walker <danielwa@cisco.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Lasse Collin <lasse.collin@tukaani.org>,
Yu Sun <yusun2@cisco.com>,
xe-linux-external@cisco.com, Daniel Walker <dwalker@fifo99.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] lib/xz: Fix XZ_DYNALLOC to avoid useless memory reallocations.
Date: Fri, 8 Nov 2019 12:27:54 -0800 [thread overview]
Message-ID: <20191108202754.GG18744@zorba> (raw)
In-Reply-To: <20191108200040.20259-2-danielwa@cisco.com>
On Fri, Nov 08, 2019 at 12:00:40PM -0800, Daniel Walker wrote:
> From: Lasse Collin <lasse.collin@tukaani.org>
>
> s->dict.allocated was initialized to 0 but never set after
> a successful allocation, thus the code always thought that
> the dictionary buffer has to be reallocated.
>
> For the original commit to xz-embedded.git, please refer to:
> https://git.tukaani.org/?p=xz-embedded.git;a=commit;h=40d291b
>
> Signed-off-by: Yu Sun <yusun2@cisco.com>
Yu made me aware that Lasse had sent this on Nov. 4. I would recommend you
take that patch, and disregard this one. Cisco is using it and we would like
to see it merged.
Daniel
next prev parent reply other threads:[~2019-11-08 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 20:00 [PATCH 2/2] lib/xz: Fix XZ_DYNALLOC to avoid useless memory reallocations Daniel Walker
2019-11-08 20:27 ` Daniel Walker [this message]
2019-11-08 20:50 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108202754.GG18744@zorba \
--to=danielwa@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=dwalker@fifo99.com \
--cc=lasse.collin@tukaani.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xe-linux-external@cisco.com \
--cc=yusun2@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.