* [Buildroot] [PATCH v2] SDL_mixer: Prefer Tremor over libvorbis
@ 2019-12-12 17:18 Paul Cercueil
2019-12-12 20:54 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Paul Cercueil @ 2019-12-12 17:18 UTC (permalink / raw
To: buildroot
When Tremor is enabled, configure SDL_mixer to use this Vorbis decoding
library instead of libvorbis. Since Tremor does fixed-point math, it is
safe to assume that if it's enabled then it is faster than libvorbis on
the target architecture.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Notes:
v2: Remove Config.in option; enable Tremor support if Tremor is enabled
in the config.
package/sdl_mixer/sdl_mixer.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/sdl_mixer/sdl_mixer.mk b/package/sdl_mixer/sdl_mixer.mk
index 81ace86498..d6f7b42deb 100644
--- a/package/sdl_mixer/sdl_mixer.mk
+++ b/package/sdl_mixer/sdl_mixer.mk
@@ -42,11 +42,16 @@ else
SDL_MIXER_CONF_OPTS += --disable-music-mod-modplug
endif
+ifeq ($(BR2_PACKAGE_TREMOR),y)
+SDL_MIXER_CONF_OPTS += --enable-music-ogg-tremor
+SDL_MIXER_DEPENDENCIES += tremor
+else
ifeq ($(BR2_PACKAGE_LIBVORBIS),y)
SDL_MIXER_CONF_OPTS += --enable-music-ogg
SDL_MIXER_DEPENDENCIES += libvorbis
else
SDL_MIXER_CONF_OPTS += --disable-music-ogg
endif
+endif
$(eval $(autotools-package))
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v2] SDL_mixer: Prefer Tremor over libvorbis
2019-12-12 17:18 [Buildroot] [PATCH v2] SDL_mixer: Prefer Tremor over libvorbis Paul Cercueil
@ 2019-12-12 20:54 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-12-12 20:54 UTC (permalink / raw
To: buildroot
Hello,
On Thu, 12 Dec 2019 18:18:59 +0100
Paul Cercueil <paul@crapouillou.net> wrote:
> When Tremor is enabled, configure SDL_mixer to use this Vorbis decoding
> library instead of libvorbis. Since Tremor does fixed-point math, it is
> safe to assume that if it's enabled then it is faster than libvorbis on
> the target architecture.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
The expected format/capitalization for the commit title is:
package/sdl_mixer: prefer tremor over libvorbis
> +ifeq ($(BR2_PACKAGE_TREMOR),y)
> +SDL_MIXER_CONF_OPTS += --enable-music-ogg-tremor
> +SDL_MIXER_DEPENDENCIES += tremor
> +else
> ifeq ($(BR2_PACKAGE_LIBVORBIS),y)
> SDL_MIXER_CONF_OPTS += --enable-music-ogg
> SDL_MIXER_DEPENDENCIES += libvorbis
> else
> SDL_MIXER_CONF_OPTS += --disable-music-ogg
> endif
> +endif
These conditions are better written like this:
ifeq ...
else ifeq ...
else ...
endif
Note how having the "ifeq" on the same line as the "else" avoids the
need for an additional "endif" at the end of condition.
I fixed both minor nits, and applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-12 20:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-12 17:18 [Buildroot] [PATCH v2] SDL_mixer: Prefer Tremor over libvorbis Paul Cercueil
2019-12-12 20:54 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.