From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3CDC2BA83 for ; Wed, 12 Feb 2020 10:24:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A307E20873 for ; Wed, 12 Feb 2020 10:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727581AbgBLKYr (ORCPT ); Wed, 12 Feb 2020 05:24:47 -0500 Received: from mga14.intel.com ([192.55.52.115]:40755 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgBLKYr (ORCPT ); Wed, 12 Feb 2020 05:24:47 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 02:24:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="237671207" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 12 Feb 2020 02:24:43 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1j1pCG-000uto-8C; Wed, 12 Feb 2020 12:24:44 +0200 Date: Wed, 12 Feb 2020 12:24:44 +0200 From: Andy Shevchenko To: Jarkko Nikula Cc: Rajat Jain , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Evan Green , rajatxjain@gmail.com, evgreen@google.com, shobhit.srivastava@intel.com, porselvan.muthukrishnan@intel.com Subject: Re: Message-ID: <20200212102444.GR10400@smile.fi.intel.com> References: <20200211223400.107604-1-rajatja@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12, 2020 at 11:30:51AM +0200, Jarkko Nikula wrote: > On 2/12/20 12:34 AM, Rajat Jain wrote: > This patch subject is missing from mail subject. > I'm thinking can this be done only once after resume and may other LPSS > blocks need the same? I.e. should this be done in drivers/mfd/intel-lpss.c? On resume we restore the previously saved context, can we be sure that values we saved during suspend are correct? If above won't show any issue, it might be best place to have this quirk applied in intel_lpss_suspend() / intel_lpss_resume() callbacks as Jarkko suggested. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28102C2BA83 for ; Wed, 12 Feb 2020 10:24:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC4FE2082F for ; Wed, 12 Feb 2020 10:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WRWn+51r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC4FE2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KQ6GqgubKo48obDyrYbg1rSxirVQukOMDD7uZvGf1P0=; b=WRWn+51rXhC394 OneIGO2TXnoAIkLGAQpheoq+Lo5vsPqSanNLJvwsdbX4S2pIR+22fpbBvMsB1jC0xez6dn8TkYO7G ukLccw27+PlbIJeBkSzUD3EJozLs/ElOLMHOto8pBJGCjd5BGO2ruwrtwUu7jwjKhl5IsM/wL8ZIE kwOKIsixZphRlEBwdRv2DM9aqzJB3CPpZxkzLVHj53abAwQCeQYxZIHe2MMWf5qUT1sf/7m890NBC OZxLXV1+gRI0Yv5VyfcAUdHIEeVJbHd725JwcwRZfxRnd/Jdw+PWZTghIoWAUTrSLC9Ht7UdXbG4T dVxA8U4SfB45UfKGaexQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1pCM-0005ZJ-5F; Wed, 12 Feb 2020 10:24:50 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1pCJ-0005YE-2s for linux-arm-kernel@lists.infradead.org; Wed, 12 Feb 2020 10:24:48 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 02:24:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="237671207" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 12 Feb 2020 02:24:43 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1j1pCG-000uto-8C; Wed, 12 Feb 2020 12:24:44 +0200 Date: Wed, 12 Feb 2020 12:24:44 +0200 From: Andy Shevchenko To: Jarkko Nikula Subject: Re: Message-ID: <20200212102444.GR10400@smile.fi.intel.com> References: <20200211223400.107604-1-rajatja@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200212_022447_142529_520FF4EA X-CRM114-Status: UNSURE ( 9.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Evan Green , rajatxjain@gmail.com, shobhit.srivastava@intel.com, linux-kernel@vger.kernel.org, Haojian Zhuang , linux-spi@vger.kernel.org, Mark Brown , evgreen@google.com, Daniel Mack , Rajat Jain , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, porselvan.muthukrishnan@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 12, 2020 at 11:30:51AM +0200, Jarkko Nikula wrote: > On 2/12/20 12:34 AM, Rajat Jain wrote: > This patch subject is missing from mail subject. > I'm thinking can this be done only once after resume and may other LPSS > blocks need the same? I.e. should this be done in drivers/mfd/intel-lpss.c? On resume we restore the previously saved context, can we be sure that values we saved during suspend are correct? If above won't show any issue, it might be best place to have this quirk applied in intel_lpss_suspend() / intel_lpss_resume() callbacks as Jarkko suggested. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: Date: Wed, 12 Feb 2020 12:24:44 +0200 Message-ID: <20200212102444.GR10400@smile.fi.intel.com> References: <20200211223400.107604-1-rajatja@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Rajat Jain , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Evan Green , rajatxjain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, evgreen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, shobhit.srivastava-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, porselvan.muthukrishnan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org To: Jarkko Nikula Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Wed, Feb 12, 2020 at 11:30:51AM +0200, Jarkko Nikula wrote: > On 2/12/20 12:34 AM, Rajat Jain wrote: > This patch subject is missing from mail subject. > I'm thinking can this be done only once after resume and may other LPSS > blocks need the same? I.e. should this be done in drivers/mfd/intel-lpss.c? On resume we restore the previously saved context, can we be sure that values we saved during suspend are correct? If above won't show any issue, it might be best place to have this quirk applied in intel_lpss_suspend() / intel_lpss_resume() callbacks as Jarkko suggested. -- With Best Regards, Andy Shevchenko