All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH/next v2, 1/1] package/font-awesome: make it compatible with fontconfig
@ 2020-02-25 16:33 Fabrice Fontaine
  2020-02-25 16:38 ` Baruch Siach
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2020-02-25 16:33 UTC (permalink / raw
  To: buildroot

This commit installs font-awesome in the standard fonts directory
making it available systemwide.

Thanks to baruch for his technical critique.
Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com>
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Arnout Vandecappelle):
 - Keep only install of otf file and don't remove install of other files

 package/font-awesome/font-awesome.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/font-awesome/font-awesome.mk b/package/font-awesome/font-awesome.mk
index 666346be0e..85e5a239c5 100644
--- a/package/font-awesome/font-awesome.mk
+++ b/package/font-awesome/font-awesome.mk
@@ -10,6 +10,8 @@ FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files)
 FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
 
 define FONT_AWESOME_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/
+	cp $(@D)/fonts/*.otf $(TARGET_DIR)/usr/share/fonts/font-awesome
 	mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
 	$(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
 		cp -dpfr $(@D)/$(d) $(TARGET_DIR)/usr/share/font-awesome$(sep))
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH/next v2, 1/1] package/font-awesome: make it compatible with fontconfig
  2020-02-25 16:33 [Buildroot] [PATCH/next v2, 1/1] package/font-awesome: make it compatible with fontconfig Fabrice Fontaine
@ 2020-02-25 16:38 ` Baruch Siach
  0 siblings, 0 replies; 2+ messages in thread
From: Baruch Siach @ 2020-02-25 16:38 UTC (permalink / raw
  To: buildroot

Hi Fabrice,

On Tue, Feb 25, 2020 at 05:33:43PM +0100, Fabrice Fontaine wrote:
> This commit installs font-awesome in the standard fonts directory
> making it available systemwide.
> 
> Thanks to baruch for his technical critique.
> Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Arnout Vandecappelle):
>  - Keep only install of otf file and don't remove install of other files
> 
>  package/font-awesome/font-awesome.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/font-awesome/font-awesome.mk b/package/font-awesome/font-awesome.mk
> index 666346be0e..85e5a239c5 100644
> --- a/package/font-awesome/font-awesome.mk
> +++ b/package/font-awesome/font-awesome.mk
> @@ -10,6 +10,8 @@ FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files)
>  FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
>  
>  define FONT_AWESOME_INSTALL_TARGET_CMDS
> +	mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/
> +	cp $(@D)/fonts/*.otf $(TARGET_DIR)/usr/share/fonts/font-awesome

Maybe just create a symlink in $(TARGET_DIR)/usr/share/fonts/font-awesome 
pointing to ../font-awesome? This would avoid duplication of *.otf files.

Does that work?

baruch

>  	mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
>  	$(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
>  		cp -dpfr $(@D)/$(d) $(TARGET_DIR)/usr/share/font-awesome$(sep))

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-25 16:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-25 16:33 [Buildroot] [PATCH/next v2, 1/1] package/font-awesome: make it compatible with fontconfig Fabrice Fontaine
2020-02-25 16:38 ` Baruch Siach

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.