* [PATCH -next] platform/x86: wmi: Make two functions static
@ 2020-04-02 7:15 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2020-04-02 7:15 UTC (permalink / raw
To: dvhart, andy, 2pi, yuehaibing; +Cc: platform-driver-x86, linux-kernel
Fix sparse warnings:
drivers/platform/x86/xiaomi-wmi.c:26:5: warning: symbol 'xiaomi_wmi_probe' was not declared. Should it be static?
drivers/platform/x86/xiaomi-wmi.c:51:6: warning: symbol 'xiaomi_wmi_notify' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/platform/x86/xiaomi-wmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c
index 601cbb282f54..54a2546bb93b 100644
--- a/drivers/platform/x86/xiaomi-wmi.c
+++ b/drivers/platform/x86/xiaomi-wmi.c
@@ -23,7 +23,7 @@ struct xiaomi_wmi {
unsigned int key_code;
};
-int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
+static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
{
struct xiaomi_wmi *data;
@@ -48,7 +48,7 @@ int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
return input_register_device(data->input_dev);
}
-void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
+static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
{
struct xiaomi_wmi *data;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next] platform/x86: wmi: Make two functions static
@ 2020-04-02 7:15 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2020-04-02 7:15 UTC (permalink / raw
To: dvhart, andy, 2pi, yuehaibing; +Cc: platform-driver-x86, linux-kernel
Fix sparse warnings:
drivers/platform/x86/xiaomi-wmi.c:26:5: warning: symbol 'xiaomi_wmi_probe' was not declared. Should it be static?
drivers/platform/x86/xiaomi-wmi.c:51:6: warning: symbol 'xiaomi_wmi_notify' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/platform/x86/xiaomi-wmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c
index 601cbb282f54..54a2546bb93b 100644
--- a/drivers/platform/x86/xiaomi-wmi.c
+++ b/drivers/platform/x86/xiaomi-wmi.c
@@ -23,7 +23,7 @@ struct xiaomi_wmi {
unsigned int key_code;
};
-int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
+static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
{
struct xiaomi_wmi *data;
@@ -48,7 +48,7 @@ int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
return input_register_device(data->input_dev);
}
-void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
+static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
{
struct xiaomi_wmi *data;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] platform/x86: wmi: Make two functions static
2020-04-02 7:15 ` YueHaibing
(?)
@ 2020-04-17 13:40 ` Andy Shevchenko
-1 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-04-17 13:40 UTC (permalink / raw
To: YueHaibing
Cc: Darren Hart, Andy Shevchenko, Mattias Jacobsson, Platform Driver,
Linux Kernel Mailing List
On Thu, Apr 2, 2020 at 10:16 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix sparse warnings:
>
> drivers/platform/x86/xiaomi-wmi.c:26:5: warning: symbol 'xiaomi_wmi_probe' was not declared. Should it be static?
> drivers/platform/x86/xiaomi-wmi.c:51:6: warning: symbol 'xiaomi_wmi_notify' was not declared. Should it be static?
>
Pushed to my review and testing queue, thanks!
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/platform/x86/xiaomi-wmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c
> index 601cbb282f54..54a2546bb93b 100644
> --- a/drivers/platform/x86/xiaomi-wmi.c
> +++ b/drivers/platform/x86/xiaomi-wmi.c
> @@ -23,7 +23,7 @@ struct xiaomi_wmi {
> unsigned int key_code;
> };
>
> -int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
> +static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
> {
> struct xiaomi_wmi *data;
>
> @@ -48,7 +48,7 @@ int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
> return input_register_device(data->input_dev);
> }
>
> -void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
> +static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
> {
> struct xiaomi_wmi *data;
>
> --
> 2.17.1
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-17 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-02 7:15 [PATCH -next] platform/x86: wmi: Make two functions static YueHaibing
2020-04-02 7:15 ` YueHaibing
2020-04-17 13:40 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.