All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH mvebu-dt64] arm64: dts: armada-3720-turris-mox: fix SFP binding
@ 2020-05-06 19:29 Marek Behún
  2020-05-17 16:58 ` Gregory CLEMENT
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Behún @ 2020-05-06 19:29 UTC (permalink / raw
  To: Gregory CLEMENT; +Cc: SoC Team, arm-soc, Linux ARM, Marek Behún

The sfp compatible should be 'sff,sfp', not 'sff,sfp+'. We used patched
kernel where the latter was working.

Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox")
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
---
 arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
index bb42d1e6a4e9..6a2ec6625880 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
@@ -95,7 +95,7 @@ sdhci1_pwrseq: sdhci1-pwrseq {
 	};
 
 	sfp: sfp {
-		compatible = "sff,sfp+";
+		compatible = "sff,sfp";
 		i2c-bus = <&i2c0>;
 		los-gpio = <&moxtet_sfp 0 GPIO_ACTIVE_HIGH>;
 		tx-fault-gpio = <&moxtet_sfp 1 GPIO_ACTIVE_HIGH>;
-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH mvebu-dt64] arm64: dts: armada-3720-turris-mox: fix SFP binding
  2020-05-06 19:29 [PATCH mvebu-dt64] arm64: dts: armada-3720-turris-mox: fix SFP binding Marek Behún
@ 2020-05-17 16:58 ` Gregory CLEMENT
  0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2020-05-17 16:58 UTC (permalink / raw
  To: Marek Behún; +Cc: SoC Team, arm-soc, Linux ARM, Marek Behún

Marek Behún <marek.behun@nic.cz> writes:

> The sfp compatible should be 'sff,sfp', not 'sff,sfp+'. We used patched
> kernel where the latter was working.
>
> Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox")
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>

Applied on mvebu/dt64

Thanks,

Gregory


> ---
>  arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> index bb42d1e6a4e9..6a2ec6625880 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> @@ -95,7 +95,7 @@ sdhci1_pwrseq: sdhci1-pwrseq {
>  	};
>  
>  	sfp: sfp {
> -		compatible = "sff,sfp+";
> +		compatible = "sff,sfp";
>  		i2c-bus = <&i2c0>;
>  		los-gpio = <&moxtet_sfp 0 GPIO_ACTIVE_HIGH>;
>  		tx-fault-gpio = <&moxtet_sfp 1 GPIO_ACTIVE_HIGH>;
> -- 
> 2.24.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-17 16:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-06 19:29 [PATCH mvebu-dt64] arm64: dts: armada-3720-turris-mox: fix SFP binding Marek Behún
2020-05-17 16:58 ` Gregory CLEMENT

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.