* [PATCHv2 4/5] second: Fix typo'd operator
@ 2020-05-23 20:26 Matt Turner
0 siblings, 0 replies; 2+ messages in thread
From: Matt Turner @ 2020-05-23 20:26 UTC (permalink / raw
To: sparclinux
Note that this does change the behavior of the code. After the patch
only < 2.6 PROMs will fail (which is probably correct), instead of every
2.* like now.
Signed-off-by: Matt Turner <mattst88@gmail.com>
---
second/disk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/second/disk.c b/second/disk.c
index 40234b3..b81a465 100644
--- a/second/disk.c
+++ b/second/disk.c
@@ -293,7 +293,7 @@ int silo_disk_read(char *buff, int size, unsigned long long offset)
if (!net) {
if (prom_vers != PROM_P1275) {
if (((romvec->pv_printrev >> 16) < 2 ||
- ((romvec->pv_printrev >> 16) = 2 && (romvec->pv_printrev && 0xffff) < 6))
+ ((romvec->pv_printrev >> 16) = 2 && (romvec->pv_printrev & 0xffff) < 6))
&& offset >= 0x40000000) {
printf ("Buggy old PROMs don't allow reading past 1GB from start of the disk. Send complaints to SMCC\n");
return -1;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2 4/5] second: Fix typo'd operator
@ 2020-06-03 1:38 David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-03 1:38 UTC (permalink / raw
To: sparclinux
From: Matt Turner <mattst88@gmail.com>
Date: Sat, 23 May 2020 13:26:50 -0700
> Note that this does change the behavior of the code. After the patch
> only < 2.6 PROMs will fail (which is probably correct), instead of every
> 2.* like now.
>
> Signed-off-by: Matt Turner <mattst88@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-03 1:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-23 20:26 [PATCHv2 4/5] second: Fix typo'd operator Matt Turner
-- strict thread matches above, loose matches on Subject: below --
2020-06-03 1:38 David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.