* [PATCH] kernel-fitimage.bbclass: allow passing UBOOT_SIGN_EXTRA_OPTS to uboot-mkimage
@ 2020-06-22 13:50 Torben Hohn
2020-06-22 22:06 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Torben Hohn @ 2020-06-22 13:50 UTC (permalink / raw
To: openembedded-core
To use pkcs11, it is necessary to pass "-N pkcs11".
And there are also a few more options, that are useful.
Pass UBOOT_SIGN_EXTRA_OPTS to uboot-mkimage, when signing the fitImage.
Signed-off-by: Torben Hohn <torben.hohn@linutronix.de>
---
meta/classes/kernel-fitimage.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
index 72b05ff8d1..afb62f1071 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -474,6 +474,7 @@ fitimage_assemble() {
${@'-D "${UBOOT_MKIMAGE_DTCOPTS}"' if len('${UBOOT_MKIMAGE_DTCOPTS}') else ''} \
-F -k "${UBOOT_SIGN_KEYDIR}" \
$add_key_to_u_boot \
+ ${UBOOT_SIGN_EXTRA_OPTS} \
-r arch/${ARCH}/boot/${2}
fi
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [OE-core] [PATCH] kernel-fitimage.bbclass: allow passing UBOOT_SIGN_EXTRA_OPTS to uboot-mkimage
2020-06-22 13:50 [PATCH] kernel-fitimage.bbclass: allow passing UBOOT_SIGN_EXTRA_OPTS to uboot-mkimage Torben Hohn
@ 2020-06-22 22:06 ` Richard Purdie
2020-06-23 7:28 ` Torben Hohn
0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2020-06-22 22:06 UTC (permalink / raw
To: Torben Hohn, openembedded-core
On Mon, 2020-06-22 at 15:50 +0200, Torben Hohn wrote:
> To use pkcs11, it is necessary to pass "-N pkcs11".
> And there are also a few more options, that are useful.
>
> Pass UBOOT_SIGN_EXTRA_OPTS to uboot-mkimage, when signing the
> fitImage.
>
> Signed-off-by: Torben Hohn <torben.hohn@linutronix.de>
> ---
> meta/classes/kernel-fitimage.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/kernel-fitimage.bbclass
> b/meta/classes/kernel-fitimage.bbclass
> index 72b05ff8d1..afb62f1071 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -474,6 +474,7 @@ fitimage_assemble() {
> ${@'-D "${UBOOT_MKIMAGE_DTCOPTS}"' if
> len('${UBOOT_MKIMAGE_DTCOPTS}') else ''} \
> -F -k "${UBOOT_SIGN_KEYDIR}" \
> $add_key_to_u_boot \
> + ${UBOOT_SIGN_EXTRA_OPTS} \
> -r arch/${ARCH}/boot/${2}
> fi
> }
Does this new option need documenting in the class headers? or at least
somewhere? I don't think it currently exists?
At the very least there should be a ??= assignment to "" as a default
somewhere?
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [OE-core] [PATCH] kernel-fitimage.bbclass: allow passing UBOOT_SIGN_EXTRA_OPTS to uboot-mkimage
2020-06-22 22:06 ` [OE-core] " Richard Purdie
@ 2020-06-23 7:28 ` Torben Hohn
0 siblings, 0 replies; 3+ messages in thread
From: Torben Hohn @ 2020-06-23 7:28 UTC (permalink / raw
To: Richard Purdie; +Cc: openembedded-core
On Mon, Jun 22, 2020 at 11:06:53PM +0100, Richard Purdie wrote:
> On Mon, 2020-06-22 at 15:50 +0200, Torben Hohn wrote:
> > To use pkcs11, it is necessary to pass "-N pkcs11".
> > And there are also a few more options, that are useful.
> >
> > Pass UBOOT_SIGN_EXTRA_OPTS to uboot-mkimage, when signing the
> > fitImage.
> >
> > Signed-off-by: Torben Hohn <torben.hohn@linutronix.de>
> > ---
> > meta/classes/kernel-fitimage.bbclass | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/classes/kernel-fitimage.bbclass
> > b/meta/classes/kernel-fitimage.bbclass
> > index 72b05ff8d1..afb62f1071 100644
> > --- a/meta/classes/kernel-fitimage.bbclass
> > +++ b/meta/classes/kernel-fitimage.bbclass
> > @@ -474,6 +474,7 @@ fitimage_assemble() {
> > ${@'-D "${UBOOT_MKIMAGE_DTCOPTS}"' if
> > len('${UBOOT_MKIMAGE_DTCOPTS}') else ''} \
> > -F -k "${UBOOT_SIGN_KEYDIR}" \
> > $add_key_to_u_boot \
> > + ${UBOOT_SIGN_EXTRA_OPTS} \
> > -r arch/${ARCH}/boot/${2}
> > fi
> > }
>
> Does this new option need documenting in the class headers? or at least
> somewhere? I don't think it currently exists?
Yes. its new.
>
> At the very least there should be a ??= assignment to "" as a default
> somewhere?
Shall i put that in meta/classes/uboot-sign.bbclass ?
>
> Cheers,
>
> Richard
>
--
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99
Hinweise zum Datenschutz finden Sie hier (Informations on data privacy
can be found here): https://linutronix.de/kontakt/Datenschutz.php
Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen |
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-23 7:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-22 13:50 [PATCH] kernel-fitimage.bbclass: allow passing UBOOT_SIGN_EXTRA_OPTS to uboot-mkimage Torben Hohn
2020-06-22 22:06 ` [OE-core] " Richard Purdie
2020-06-23 7:28 ` Torben Hohn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.